mirror of
https://github.com/luxfi/onchain-id.git
synced 2026-10-30 15:23:49 +00:00
0407b3bfa4
## [2.0.0] Version 2.0.0 Audited by Hacken, more details [here](https://tokeny.com/wp-content/uploads/2023/04/Tokeny_ONCHAINID_SC-Audit_Report.pdf) ### Breaking changes ## Deprecation Notice - ClaimIssuer `revokeClaim` is now deprecated, usage of `revokeClaimBySignature(bytes signature)` is preferred. ### Added - Add typechain-types (targeting ethers v5). - Add tests cases for `execute` and `approve` methods. - Add method `revokeClaimBySignature(bytes signature)` in ClaimIssuer, prefer using this method instead of the now deprecated `revokeClaim` method. - Add checks on ClaimIssuer to prevent revoking an already revoked claim. - Added Factory for ONCHAINIDs ### Updated - Switch development tooling to hardhat. - Implemented tests for hardhat (using fixture for faster testing time). - Prevent calling `approve` method with a non-request execute nonce (added a require on `executionNone`). - Update NatSpec of `execute` and `approve` methods. --------- Co-authored-by: Joachim <[email protected]>
76 lines
4.6 KiB
TypeScript
76 lines
4.6 KiB
TypeScript
import { loadFixture } from '@nomicfoundation/hardhat-network-helpers';
|
|
import { expect } from "chai";
|
|
import {ethers} from "hardhat";
|
|
|
|
import {deployFactoryFixture, deployIdentityFixture} from "../fixtures";
|
|
|
|
describe('IdFactory', () => {
|
|
describe('add/remove Token factory', () => {
|
|
it('should manipulate Token factory list', async () => {
|
|
const { identityFactory, deployerWallet, aliceWallet, bobWallet } = await loadFixture(deployFactoryFixture);
|
|
|
|
await expect(identityFactory.connect(aliceWallet).addTokenFactory(aliceWallet.address)).to.be.revertedWith('Ownable: caller is not the owner');
|
|
|
|
await expect(identityFactory.connect(deployerWallet).addTokenFactory(ethers.constants.AddressZero)).to.be.revertedWith('invalid argument - zero address');
|
|
|
|
const addTx = await identityFactory.connect(deployerWallet).addTokenFactory(aliceWallet.address);
|
|
await expect(addTx).to.emit(identityFactory, 'TokenFactoryAdded').withArgs(aliceWallet.address);
|
|
|
|
await expect(identityFactory.connect(deployerWallet).addTokenFactory(aliceWallet.address)).to.be.revertedWith('already a factory');
|
|
|
|
await expect(identityFactory.connect(aliceWallet).removeTokenFactory(bobWallet.address)).to.be.revertedWith('Ownable: caller is not the owner');
|
|
|
|
await expect(identityFactory.connect(deployerWallet).removeTokenFactory(ethers.constants.AddressZero)).to.be.revertedWith('invalid argument - zero address');
|
|
|
|
await expect(identityFactory.connect(deployerWallet).removeTokenFactory(bobWallet.address)).to.be.revertedWith('not a factory');
|
|
|
|
const removeTx = await identityFactory.connect(deployerWallet).removeTokenFactory(aliceWallet.address);
|
|
await expect(removeTx).to.emit(identityFactory, 'TokenFactoryRemoved').withArgs(aliceWallet.address);
|
|
});
|
|
});
|
|
|
|
describe('createTokenIdentity', () => {
|
|
it('should revert for being not authorized to deploy token', async () => {
|
|
const { identityFactory, aliceWallet } = await loadFixture(deployFactoryFixture);
|
|
|
|
await expect(identityFactory.connect(aliceWallet).createTokenIdentity(aliceWallet.address, aliceWallet.address, 'TST')).to.be.revertedWith('only Factory or owner can call');
|
|
});
|
|
|
|
it('should revert for token address being zero address', async () => {
|
|
const { identityFactory, deployerWallet, aliceWallet } = await loadFixture(deployFactoryFixture);
|
|
|
|
await expect(identityFactory.connect(deployerWallet).createTokenIdentity(ethers.constants.AddressZero, aliceWallet.address, 'TST')).to.be.revertedWith('invalid argument - zero address');
|
|
});
|
|
|
|
it('should revert for owner being zero address', async () => {
|
|
const { identityFactory, deployerWallet, aliceWallet } = await loadFixture(deployFactoryFixture);
|
|
|
|
await expect(identityFactory.connect(deployerWallet).createTokenIdentity(aliceWallet.address, ethers.constants.AddressZero, 'TST')).to.be.revertedWith('invalid argument - zero address');
|
|
});
|
|
|
|
it('should revert for salt being empty', async () => {
|
|
const { identityFactory, deployerWallet, aliceWallet } = await loadFixture(deployFactoryFixture);
|
|
|
|
await expect(identityFactory.connect(deployerWallet).createTokenIdentity(aliceWallet.address, aliceWallet.address, '')).to.be.revertedWith('invalid argument - empty string');
|
|
});
|
|
|
|
it('should create one identity and then revert for salt/address being already used', async () => {
|
|
const { identityFactory, deployerWallet, aliceWallet, bobWallet } = await loadFixture(deployFactoryFixture);
|
|
|
|
expect(await identityFactory.isSaltTaken('Tokensalt1')).to.be.false;
|
|
|
|
const tx = await identityFactory.connect(deployerWallet).createTokenIdentity(aliceWallet.address, bobWallet.address, 'salt1');
|
|
const tokenIdentityAddress = await identityFactory.getIdentity(aliceWallet.address);
|
|
await expect(tx).to.emit(identityFactory, 'TokenLinked').withArgs(aliceWallet.address, tokenIdentityAddress);
|
|
await expect(tx).to.emit(identityFactory, 'Deployed').withArgs(tokenIdentityAddress);
|
|
|
|
expect(await identityFactory.isSaltTaken('Tokensalt1')).to.be.true;
|
|
expect(await identityFactory.isSaltTaken('Tokensalt2')).to.be.false;
|
|
expect(await identityFactory.getToken(tokenIdentityAddress)).to.deep.equal(aliceWallet.address);
|
|
|
|
await expect(identityFactory.connect(deployerWallet).createTokenIdentity(aliceWallet.address, aliceWallet.address, 'salt1')).to.be.revertedWith('salt already taken');
|
|
await expect(identityFactory.connect(deployerWallet).createTokenIdentity(aliceWallet.address, aliceWallet.address, 'salt2')).to.be.revertedWith('token already linked to an identity');
|
|
});
|
|
});
|
|
});
|