mirror of
https://github.com/luxfi/onchain-id.git
synced 2026-10-30 15:23:49 +00:00
0407b3bfa4
## [2.0.0] Version 2.0.0 Audited by Hacken, more details [here](https://tokeny.com/wp-content/uploads/2023/04/Tokeny_ONCHAINID_SC-Audit_Report.pdf) ### Breaking changes ## Deprecation Notice - ClaimIssuer `revokeClaim` is now deprecated, usage of `revokeClaimBySignature(bytes signature)` is preferred. ### Added - Add typechain-types (targeting ethers v5). - Add tests cases for `execute` and `approve` methods. - Add method `revokeClaimBySignature(bytes signature)` in ClaimIssuer, prefer using this method instead of the now deprecated `revokeClaim` method. - Add checks on ClaimIssuer to prevent revoking an already revoked claim. - Added Factory for ONCHAINIDs ### Updated - Switch development tooling to hardhat. - Implemented tests for hardhat (using fixture for faster testing time). - Prevent calling `approve` method with a non-request execute nonce (added a require on `executionNone`). - Update NatSpec of `execute` and `approve` methods. --------- Co-authored-by: Joachim <[email protected]>
180 lines
7.8 KiB
TypeScript
180 lines
7.8 KiB
TypeScript
import { loadFixture } from '@nomicfoundation/hardhat-network-helpers';
|
|
import { expect } from "chai";
|
|
import {ethers} from "hardhat";
|
|
|
|
import { deployIdentityFixture } from '../fixtures';
|
|
|
|
describe('Identity', () => {
|
|
describe('Key Management', () => {
|
|
describe('Read key methods', () => {
|
|
it('should retrieve an existing key', async () => {
|
|
const { aliceIdentity, aliceWallet } = await loadFixture(deployIdentityFixture);
|
|
|
|
const aliceKeyHash = ethers.utils.keccak256(
|
|
ethers.utils.defaultAbiCoder.encode(['address'], [aliceWallet.address])
|
|
);
|
|
const aliceKey = await aliceIdentity.getKey(aliceKeyHash);
|
|
expect(aliceKey.key).to.equal(aliceKeyHash);
|
|
expect(aliceKey.purposes).to.deep.equal([1]);
|
|
expect(aliceKey.keyType).to.equal(1);
|
|
});
|
|
|
|
it('should retrieve existing key purposes', async () => {
|
|
const { aliceIdentity, aliceWallet } = await loadFixture(deployIdentityFixture);
|
|
|
|
const aliceKeyHash = ethers.utils.keccak256(
|
|
ethers.utils.defaultAbiCoder.encode(['address'], [aliceWallet.address])
|
|
);
|
|
const purposes = await aliceIdentity.getKeyPurposes(aliceKeyHash);
|
|
expect(purposes).to.deep.equal([1]);
|
|
});
|
|
|
|
it('should retrieve existing keys with given purpose', async () => {
|
|
const { aliceIdentity, aliceWallet } = await loadFixture(deployIdentityFixture);
|
|
|
|
const aliceKeyHash = ethers.utils.keccak256(
|
|
ethers.utils.defaultAbiCoder.encode(['address'], [aliceWallet.address])
|
|
);
|
|
const keys = await aliceIdentity.getKeysByPurpose(1);
|
|
expect(keys).to.deep.equal([aliceKeyHash]);
|
|
});
|
|
|
|
it('should return true if a key has a given purpose', async () => {
|
|
const { aliceIdentity, aliceWallet } = await loadFixture(deployIdentityFixture);
|
|
|
|
const aliceKeyHash = ethers.utils.keccak256(
|
|
ethers.utils.defaultAbiCoder.encode(['address'], [aliceWallet.address])
|
|
);
|
|
const hasPurpose = await aliceIdentity.keyHasPurpose(aliceKeyHash, 1);
|
|
expect(hasPurpose).to.equal(true);
|
|
});
|
|
|
|
it('should return false if a key has not a given purpose but is a MANAGEMENT key', async () => {
|
|
const { aliceIdentity, aliceWallet } = await loadFixture(deployIdentityFixture);
|
|
|
|
const aliceKeyHash = ethers.utils.keccak256(
|
|
ethers.utils.defaultAbiCoder.encode(['address'], [aliceWallet.address])
|
|
);
|
|
const hasPurpose = await aliceIdentity.keyHasPurpose(aliceKeyHash, 2);
|
|
expect(hasPurpose).to.equal(true);
|
|
});
|
|
|
|
it('should return false if a key has not a given purpose', async () => {
|
|
const { aliceIdentity, bobWallet } = await loadFixture(deployIdentityFixture);
|
|
|
|
const bobKeyHash = ethers.utils.keccak256(
|
|
ethers.utils.defaultAbiCoder.encode(['address'], [bobWallet.address])
|
|
);
|
|
const hasPurpose = await aliceIdentity.keyHasPurpose(bobKeyHash, 2);
|
|
expect(hasPurpose).to.equal(false);
|
|
});
|
|
});
|
|
|
|
describe('Add key methods', () => {
|
|
describe('when calling as a non-MANAGEMENT key', () => {
|
|
it('should revert because the signer is not a MANAGEMENT key', async () => {
|
|
const { aliceIdentity, bobWallet } = await loadFixture(deployIdentityFixture);
|
|
|
|
const bobKeyHash = ethers.utils.keccak256(
|
|
ethers.utils.defaultAbiCoder.encode(['address'], [bobWallet.address])
|
|
);
|
|
await expect(
|
|
aliceIdentity.connect(bobWallet).addKey(bobKeyHash, 1, 1)
|
|
).to.be.revertedWith('Permissions: Sender does not have management key');
|
|
});
|
|
});
|
|
|
|
describe('when calling as a MANAGEMENT key', () => {
|
|
it('should add the purpose to the existing key', async () => {
|
|
const { aliceIdentity, aliceWallet } = await loadFixture(deployIdentityFixture);
|
|
|
|
const aliceKeyHash = ethers.utils.keccak256(
|
|
ethers.utils.defaultAbiCoder.encode(['address'], [aliceWallet.address])
|
|
);
|
|
await aliceIdentity.connect(aliceWallet).addKey(aliceKeyHash, 2, 1);
|
|
const aliceKey = await aliceIdentity.getKey(aliceKeyHash);
|
|
expect(aliceKey.key).to.equal(aliceKeyHash);
|
|
expect(aliceKey.purposes).to.deep.equal([1, 2]);
|
|
expect(aliceKey.keyType).to.equal(1);
|
|
});
|
|
|
|
it('should add a new key with a purpose', async () => {
|
|
const { aliceIdentity, bobWallet, aliceWallet } = await loadFixture(deployIdentityFixture);
|
|
|
|
const bobKeyHash = ethers.utils.keccak256(
|
|
ethers.utils.defaultAbiCoder.encode(['address'], [bobWallet.address])
|
|
);
|
|
await aliceIdentity.connect(aliceWallet).addKey(bobKeyHash, 1, 1);
|
|
const bobKey = await aliceIdentity.getKey(bobKeyHash);
|
|
expect(bobKey.key).to.equal(bobKeyHash);
|
|
expect(bobKey.purposes).to.deep.equal([1]);
|
|
expect(bobKey.keyType).to.equal(1);
|
|
});
|
|
|
|
it('should revert because key already has the purpose', async () => {
|
|
const { aliceIdentity, aliceWallet } = await loadFixture(deployIdentityFixture);
|
|
|
|
const aliceKeyHash = ethers.utils.keccak256(
|
|
ethers.utils.defaultAbiCoder.encode(['address'], [aliceWallet.address])
|
|
);
|
|
await expect(
|
|
aliceIdentity.connect(aliceWallet).addKey(aliceKeyHash, 1, 1)
|
|
).to.be.revertedWith('Conflict: Key already has purpose');
|
|
});
|
|
});
|
|
});
|
|
|
|
describe('Remove key methods', () => {
|
|
describe('when calling as a non-MANAGEMENT key', () => {
|
|
it('should revert because the signer is not a MANAGEMENT key', async () => {
|
|
const { aliceIdentity, aliceWallet, bobWallet } = await loadFixture(deployIdentityFixture);
|
|
|
|
const aliceKeyHash = ethers.utils.keccak256(
|
|
ethers.utils.defaultAbiCoder.encode(['address'], [aliceWallet.address])
|
|
);
|
|
await expect(
|
|
aliceIdentity.connect(bobWallet).removeKey(aliceKeyHash, 1)
|
|
).to.be.revertedWith('Permissions: Sender does not have management key');
|
|
});
|
|
});
|
|
|
|
describe('when calling as a MANAGEMENT key', () => {
|
|
it('should remove the purpose from the existing key', async () => {
|
|
const { aliceIdentity, aliceWallet } = await loadFixture(deployIdentityFixture);
|
|
|
|
const aliceKeyHash = ethers.utils.keccak256(
|
|
ethers.utils.defaultAbiCoder.encode(['address'], [aliceWallet.address])
|
|
);
|
|
await aliceIdentity.connect(aliceWallet).removeKey(aliceKeyHash, 1);
|
|
const aliceKey = await aliceIdentity.getKey(aliceKeyHash);
|
|
expect(aliceKey.key).to.equal('0x0000000000000000000000000000000000000000000000000000000000000000');
|
|
expect(aliceKey.purposes).to.deep.equal([]);
|
|
expect(aliceKey.keyType).to.equal(0);
|
|
});
|
|
|
|
it('should revert because key does not exists', async () => {
|
|
const { aliceIdentity, aliceWallet, bobWallet } = await loadFixture(deployIdentityFixture);
|
|
|
|
const bobKeyHash = ethers.utils.keccak256(
|
|
ethers.utils.defaultAbiCoder.encode(['address'], [bobWallet.address])
|
|
);
|
|
await expect(
|
|
aliceIdentity.connect(aliceWallet).removeKey(bobKeyHash, 2)
|
|
).to.be.revertedWith("NonExisting: Key isn't registered");
|
|
});
|
|
|
|
it('should revert because key does not have the purpose', async () => {
|
|
const { aliceIdentity, aliceWallet } = await loadFixture(deployIdentityFixture);
|
|
|
|
const aliceKeyHash = ethers.utils.keccak256(
|
|
ethers.utils.defaultAbiCoder.encode(['address'], [aliceWallet.address])
|
|
);
|
|
await expect(
|
|
aliceIdentity.connect(aliceWallet).removeKey(aliceKeyHash, 2)
|
|
).to.be.revertedWith("NonExisting: Key doesn't have such purpose");
|
|
});
|
|
});
|
|
});
|
|
});
|
|
});
|