mirror of
https://github.com/luxfi/pqclean.git
synced 2026-10-30 15:21:55 +00:00
Thom WiggersandGitHub
2f032efd37
We allow a preprocessor macro in Falcon's avx2 sign.c implementation to resolve a x32/x64 compatibility issue. At the same time, simplify the match statements.
51 lines
1.7 KiB
Python
51 lines
1.7 KiB
Python
import pytest
|
|
|
|
import helpers
|
|
from pathlib import Path
|
|
import pqclean
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
'implementation',
|
|
pqclean.Scheme.all_implementations(),
|
|
ids=str,
|
|
)
|
|
@helpers.filtered_test
|
|
def test_preprocessor(implementation: pqclean.Implementation):
|
|
cfiles = implementation.cfiles()
|
|
hfiles = implementation.hfiles()
|
|
errors = []
|
|
for file in hfiles + cfiles:
|
|
code_has_begun = False
|
|
in_comment = True
|
|
with open(file) as f:
|
|
for i, line in enumerate(f):
|
|
line = line.strip()
|
|
if file in hfiles and not code_has_begun and line.startswith('#ifndef'):
|
|
continue
|
|
if line == "":
|
|
continue
|
|
if line.startswith("/*") and not code_has_begun:
|
|
in_comment = True
|
|
continue
|
|
if in_comment and "*/" in line:
|
|
in_comment = False
|
|
continue
|
|
if not code_has_begun and not in_comment and not line.startswith("#ifndef"):
|
|
code_has_begun = True
|
|
if (line.startswith('#if') and
|
|
not Path(file).match("crypto_sign/dilithium[235]/aarch64/fips202x2.c") and
|
|
not Path(file).match("crypto_kem/kyber*/aarch64/fips202x2.c") and
|
|
not Path(file).match("crypto_sign/falcon-*/aarch64/fips202x2.c") and
|
|
not Path(file).match("crypto_sign/falcon-*/avx2/sign.c")):
|
|
errors.append("\n at {}:{}".format(file, i+1))
|
|
if errors:
|
|
raise AssertionError(
|
|
"Prohibited use of preprocessor conditional" + "".join(errors)
|
|
)
|
|
|
|
|
|
if __name__ == '__main__':
|
|
import sys
|
|
pytest.main(sys.argv)
|