Files
proto/p/txs/add_permissionless_validator_tx.go
zeekay f90e6bb5bb refactor(p,x): generic math.Add/Mul, Codec-free sort, LockOut.Bytes
- safemath.Add64/Mul64 → Add/Mul (Go generics; same wire/bounds
  behaviour, fewer per-width copies). Sweep across p/{reward,utxo,txs}
  and the x-side test helpers.
- lux.SortTransferableOutputs / SyntacticVerifier UTXO/Output helpers:
  drop the threaded Codec arg; sort key is now Bytes()+assetID, no
  codec roundtrip per compare. Callers in p/utxo/handler.go,
  p/txs/{add_*,base_tx,builder,executor/*}, p/state, and
  x/txs/executor/syntactic_verifier follow.
- stakeable.LockOut: implement Bytes() returning
  0xFF || BE(Locktime) || inner.Bytes(). 0xFF marker keeps locked
  outputs sorted strictly AFTER unlocked fxs primitives, preserving
  the legacy ordering invariant the SyntacticVerify expects.
- Update test helpers in p/block/{builder,executor}, p/network, p/txs
  to construct outputs without the codec arg and rely on the new sort.
2026-06-04 17:05:03 -07:00

198 lines
6.4 KiB
Go

// Copyright (C) 2019-2025, Lux Industries, Inc. All rights reserved.
// See the file LICENSE for licensing terms.
package txs
import (
"context"
"errors"
"fmt"
"github.com/luxfi/constants"
"github.com/luxfi/crypto/bls"
"github.com/luxfi/ids"
safemath "github.com/luxfi/math"
"github.com/luxfi/proto/p/fx"
"github.com/luxfi/proto/p/reward"
"github.com/luxfi/proto/p/signer"
"github.com/luxfi/runtime"
lux "github.com/luxfi/utxo"
"github.com/luxfi/utxo/secp256k1fx"
"github.com/luxfi/vm/components/verify"
)
var (
_ ValidatorTx = (*AddPermissionlessValidatorTx)(nil)
_ ScheduledStaker = (*AddPermissionlessDelegatorTx)(nil)
errEmptyNodeID = errors.New("validator nodeID cannot be empty")
errNoStake = errors.New("no stake")
errInvalidSigner = errors.New("invalid signer")
errMultipleStakedAssets = errors.New("multiple staked assets")
errValidatorWeightMismatch = errors.New("validator weight mismatch")
)
// AddPermissionlessValidatorTx is an unsigned addPermissionlessValidatorTx
type AddPermissionlessValidatorTx struct {
// Metadata, inputs and outputs
BaseTx `serialize:"true"`
// Describes the validator
Validator `serialize:"true" json:"validator"`
// ID of the chain this validator is validating
Chain ids.ID `serialize:"true" json:"chainID"`
// If the [Chain] is the primary network, [Signer] is the BLS key for this
// validator. If the [Chain] is not the primary network, this value is the
// empty signer
// Note: We do not enforce that the BLS key is unique across all validators.
// This means that validators can share a key if they so choose.
// However, a NodeID does uniquely map to a BLS key
Signer signer.Signer `serialize:"true" json:"signer"`
// Where to send staked tokens when done validating
StakeOuts []*lux.TransferableOutput `serialize:"true" json:"stake"`
// Where to send validation rewards when done validating
ValidatorRewardsOwner fx.Owner `serialize:"true" json:"validationRewardsOwner"`
// Where to send delegation rewards when done validating
DelegatorRewardsOwner fx.Owner `serialize:"true" json:"delegationRewardsOwner"`
// Fee this validator charges delegators as a percentage, times 10,000
// For example, if this validator has DelegationShares=300,000 then they
// take 30% of rewards from delegators
DelegationShares uint32 `serialize:"true" json:"shares"`
}
// InitRuntime sets the FxID fields in the inputs and outputs of this
// [AddPermissionlessValidatorTx]. Also sets the [ctx] to the given [vm.ctx] so
// that the addresses can be json marshalled into human readable format
func (tx *AddPermissionlessValidatorTx) InitRuntime(rt *runtime.Runtime) {
tx.BaseTx.InitRuntime(rt)
for _, out := range tx.StakeOuts {
out.FxID = secp256k1fx.ID
out.InitRuntime(rt)
}
// Owner doesn't have InitRuntime method
// tx.ValidatorRewardsOwner.InitRuntime(rt)
// tx.DelegatorRewardsOwner.InitRuntime(rt)
}
func (tx *AddPermissionlessValidatorTx) ChainID() ids.ID {
return tx.Chain
}
func (tx *AddPermissionlessValidatorTx) NodeID() ids.NodeID {
return tx.Validator.NodeID
}
func (tx *AddPermissionlessValidatorTx) PublicKey() (*bls.PublicKey, bool, error) {
if err := tx.Signer.Verify(); err != nil {
return nil, false, err
}
key := tx.Signer.Key()
return key, key != nil, nil
}
func (tx *AddPermissionlessValidatorTx) PendingPriority() Priority {
if tx.Chain == constants.PrimaryNetworkID {
return PrimaryNetworkValidatorPendingPriority
}
return NetPermissionlessValidatorPendingPriority
}
func (tx *AddPermissionlessValidatorTx) CurrentPriority() Priority {
if tx.Chain == constants.PrimaryNetworkID {
return PrimaryNetworkValidatorCurrentPriority
}
return NetPermissionlessValidatorCurrentPriority
}
func (tx *AddPermissionlessValidatorTx) Stake() []*lux.TransferableOutput {
return tx.StakeOuts
}
func (tx *AddPermissionlessValidatorTx) ValidationRewardsOwner() fx.Owner {
return tx.ValidatorRewardsOwner
}
func (tx *AddPermissionlessValidatorTx) DelegationRewardsOwner() fx.Owner {
return tx.DelegatorRewardsOwner
}
func (tx *AddPermissionlessValidatorTx) Shares() uint32 {
return tx.DelegationShares
}
// SyntacticVerify returns nil iff [tx] is valid
func (tx *AddPermissionlessValidatorTx) SyntacticVerify(rt *runtime.Runtime) error {
switch {
case tx == nil:
return ErrNilTx
case tx.SyntacticallyVerified: // already passed syntactic verification
return nil
case tx.Validator.NodeID == ids.EmptyNodeID:
return errEmptyNodeID
case len(tx.StakeOuts) == 0: // Ensure there is provided stake
return errNoStake
case tx.DelegationShares > reward.PercentDenominator:
return errTooManyShares
}
if err := tx.BaseTx.SyntacticVerify(rt); err != nil {
return fmt.Errorf("failed to verify BaseTx: %w", err)
}
if err := verify.All(&tx.Validator, tx.Signer, tx.ValidatorRewardsOwner, tx.DelegatorRewardsOwner); err != nil {
return fmt.Errorf("failed to verify validator, signer, or rewards owners: %w", err)
}
hasKey := tx.Signer.Key() != nil
isPrimaryNetwork := tx.Chain == constants.PrimaryNetworkID
if hasKey != isPrimaryNetwork {
return fmt.Errorf(
"%w: hasKey=%v != isPrimaryNetwork=%v",
errInvalidSigner,
hasKey,
isPrimaryNetwork,
)
}
for _, out := range tx.StakeOuts {
if err := out.Verify(); err != nil {
return fmt.Errorf("failed to verify output: %w", err)
}
}
firstStakeOutput := tx.StakeOuts[0]
stakedAssetID := firstStakeOutput.AssetID()
totalStakeWeight := firstStakeOutput.Output().Amount()
for _, out := range tx.StakeOuts[1:] {
newWeight, err := safemath.Add(totalStakeWeight, out.Output().Amount())
if err != nil {
return err
}
totalStakeWeight = newWeight
assetID := out.AssetID()
if assetID != stakedAssetID {
return fmt.Errorf("%w: %q and %q", errMultipleStakedAssets, stakedAssetID, assetID)
}
}
switch {
case !lux.IsSortedTransferableOutputs(tx.StakeOuts):
return errOutputsNotSorted
case totalStakeWeight != tx.Wght:
return fmt.Errorf("%w: weight %d != stake %d", errValidatorWeightMismatch, tx.Wght, totalStakeWeight)
}
// cache that this is valid
tx.SyntacticallyVerified = true
return nil
}
func (tx *AddPermissionlessValidatorTx) Visit(visitor Visitor) error {
return visitor.AddPermissionlessValidatorTx(tx)
}
// InitializeWithContext initializes the transaction with consensus context
func (tx *AddPermissionlessValidatorTx) InitializeWithContext(ctx context.Context) error {
// Initialize any context-dependent fields here
return nil
}