mirror of
https://github.com/luxfi/safe-wallet.git
synced 2026-10-30 15:19:21 +00:00
863e8a6f9a
* tests: mock CGW APIs in visual tests for deterministic Chromatic screenshots
25 of 33 visual tests hit the live staging API, causing non-deterministic
screenshots due to changing token prices, balances, and fiat values.
Add mockVisualTestApis() helper that intercepts all CGW endpoints with
shared MSW fixture data (via symlink). Each visual test calls it in
beforeEach(); tests needing specific data override with their own
cy.intercept() after (Cypress last-registered-wins).
* tests: remove functional assertions from visual tests
Visual tests exist solely to load a screen for Chromatic to screenshot.
They should never fail due to data assertions or functional validation.
Removed:
- cy.contains() assertions checking data-dependent values (sepoliaEther)
- cy.contains() assertions checking page headings (can break if text changes)
- Functional assertions: verifyErrorMsgInvalidAddress, verifyNumberErrorValidation,
checkTimeDropdownOptions, verifyBatchIconCount, verifyRandomStringAddress,
verifyTooltipMessage, verifyIncorrectAddressErrorMessage,
verifyEmptyOwnerNameNotAllowed, checkMultichainSubSafeExists
- Stale selector: notifications.notificationsTitle pointed to wrong component
- cy.get().should('be.visible') assertions used as page-load signals
Kept:
- Navigation actions that set up visual state (typing invalid data, clicking buttons)
- main.verifySkeletonsGone() as the canonical page-loaded signal
- main.waitForMuiAnimationsToSettle() for animation settling
* tests: deterministic visual regression tests for Chromatic
- Pin app version and commit hash in visual regression builds
- Mock CGW APIs (chain config, safe info, balances, portfolio) for deterministic screenshots
- Return deterministic safe name when VISUAL_REGRESSION_BUILD is set
- Fix appsEndpoint glob matching /settings/safe-apps page route
- Add clickOnTokenselectorAndSelectToken for mock-compatible token selection
- Remove skeleton assertion from awaitVisualStability
---------
Co-authored-by: Hanzo Dev <[email protected]>
64 lines
2.6 KiB
JavaScript
64 lines
2.6 KiB
JavaScript
import * as constants from './constants'
|
|
|
|
const FIXTURES = {
|
|
chains: 'msw/chains/all.json',
|
|
safeInfo: 'msw/safes/sepolia.json',
|
|
balances: 'msw/balances/safe-token-holder.json',
|
|
portfolio: 'msw/portfolio/safe-token-holder.json',
|
|
positions: 'msw/positions/safe-token-holder.json',
|
|
safeApps: 'msw/safe-apps/mainnet.json',
|
|
}
|
|
|
|
const EMPTY_PAGE = { count: 0, next: null, previous: null, results: [] }
|
|
|
|
const MASTER_COPIES = [
|
|
{ address: '0xd9Db270c1B5E3Bd161E8c8503c55cEFDDe8E6766', version: '1.3.0' },
|
|
{ address: '0x6851D6fDFAfD08c0EF60ac1b9c90E5dE6247cEAC', version: '1.4.1' },
|
|
]
|
|
|
|
/**
|
|
* Mocks volatile CGW API endpoints for deterministic visual regression screenshots.
|
|
* Uses shared MSW fixtures from config/test/msw/fixtures/ (via symlink).
|
|
* Call in beforeEach() of visual tests.
|
|
* Per-test cy.intercept() calls registered AFTER this one override these defaults
|
|
* (Cypress uses last-registered-wins for matching intercepts).
|
|
*/
|
|
export function mockVisualTestApis() {
|
|
// Chain config — prevents empty sidebar when CGW is slow
|
|
cy.fixture(FIXTURES.chains).then((data) => {
|
|
cy.intercept('GET', constants.chainsEndpoint, data)
|
|
cy.intercept('GET', constants.chainConfigEndpoint, (req) => {
|
|
const chainId = req.url.split('/').pop().split('?')[0]
|
|
const chain = data.results.find((c) => c.chainId === chainId)
|
|
req.reply(chain || { statusCode: 404 })
|
|
})
|
|
})
|
|
|
|
// Safe info — dynamically patches address/chainId from the request URL
|
|
cy.fixture(FIXTURES.safeInfo).then((data) => {
|
|
cy.intercept('GET', constants.safeInfoEndpoint, (req) => {
|
|
const parts = req.url.split('/')
|
|
const safeAddress = parts.pop()
|
|
// walk back to find chainId: .../chains/{chainId}/safes/{safeAddress}
|
|
const chainsIdx = parts.indexOf('chains')
|
|
const chainId = chainsIdx !== -1 ? parts[chainsIdx + 1] : data.chainId
|
|
req.reply({
|
|
...data,
|
|
address: { ...data.address, value: safeAddress },
|
|
chainId,
|
|
})
|
|
})
|
|
})
|
|
|
|
cy.fixture(FIXTURES.balances).then((data) => cy.intercept('GET', constants.balancesEndpoint, data))
|
|
cy.fixture(FIXTURES.portfolio).then((data) => cy.intercept('GET', constants.portfolioEndpoint, data))
|
|
cy.fixture(FIXTURES.positions).then((data) => cy.intercept('GET', constants.positionsEndpoint, data))
|
|
cy.fixture(FIXTURES.safeApps).then((data) => cy.intercept('GET', constants.appsEndpoint, data))
|
|
|
|
cy.intercept('GET', constants.masterCopiesEndpoint, MASTER_COPIES)
|
|
cy.intercept('GET', constants.targetedMessagingEndpoint, { outreaches: [] })
|
|
|
|
cy.intercept('GET', constants.queuedEndpoint, EMPTY_PAGE)
|
|
cy.intercept('GET', constants.transactionHistoryEndpoint, EMPTY_PAGE)
|
|
}
|