Files
05cab32f0e tests(web): connect wallet via seeded storage in e2e (#8350)
* tests(web): connect wallet via seeded storage in e2e

Replace the UI-driven connectSigner flow with storage-seeded auto-reconnect
across the Cypress suite. Adds connectSignerViaStorage (seed on visit, or seed
+ reload) and migrates 139 entry connects; keeps UI connectSigner for the 27
connect/switch-flow sites that act on in-page state.

* tests(web): seed batch via single page load in batch e2e

Add optional extraStorage to connectSignerViaStorage so localStorage is
seeded in onBeforeLoad on the initial visit. Split batch_tx into
build-via-UI and pre-seeded describes, dropping addToLocalStorage +
cy.reload() double-loads.

* tests(web): seed state on a single page load across e2e specs

Replace visit-then-write-then-reload double-loads with a single seeded
load (extraStorage on connectSignerViaStorage, or onBeforeLoad on
cy.visit), and drop the arbitrary post-reload settle waits. Covers the
multichain, nested-safes, batch, address-book, safe-selector and
create-safe specs (regression, smoke, visual).

* tests(web): seed state on a single page load in more e2e specs

Fold pre-seeded localStorage into the initial visit (extraStorage /
onBeforeLoad) and drop the follow-up reloads across the address-book,
messages-popup, CF-safe, import/export and load-safe specs. Split specs
whose shared beforeEach served both seeding and non-seeding tests into
nested describes so no test double-loads.

* tests(web): remove redundant wallet reconnect reloads in e2e specs

Pass the URL to connectSignerViaStorage so the wallet is seeded on the
initial visit instead of visiting then reconnecting (which reloaded).
Where a shared beforeEach served both connected and disconnected (or
differently-seeded) tests, split into nested describes so no test
double-loads. Covers proposers, swaps, twaps, assets, swaps_tokens,
sidebar, spending_limits, bulk_execution, proposers_2, safe_selector.

* tests(web): single-load owner-management e2e specs

Split add/remove/replace-owner specs into connected / disconnected /
non-owner / pre-seeded describes so the wallet is seeded on the initial
visit (no reconnect reload) without forcing a connect onto tests that
assert disconnected or non-owner state.

* tests(web): wait for wallet connection after seeded connect

The last wallet reconnects asynchronously after the page loads, so
connectSignerViaStorage now waits for the connected-wallet header chip
(open-account-center) before resolving, instead of letting tests proceed
while still disconnected. Opt out via waitForConnection:false for pages
without that chip (welcome/accounts in safe_selector).

* tests(web): address review on seeded-connect PR

- Drop the explicit 30s timeout on the connected-wallet wait; the repo
  default (10s) is plenty for the post-load reconnect and fails faster.
- Make recovery.cy.js consistent: the remaining connectSigner calls now
  use connectSignerViaStorage like the rest of the file. All connects are
  at test start (none mid-flow), matching the already-converted tests.

* fix: wait for the wallet connection to establish to avoid failing tests due to disconnected wallet

---------

Co-authored-by: vmosharova <[email protected]>
2026-07-31 17:00:56 +02:00

88 lines
3.7 KiB
JavaScript

import * as constants from '../../support/constants.js'
import * as safeapps from '../pages/safeapps.pages.js'
import * as createtx from '../pages/create_tx.pages.js'
import * as navigation from '../pages/navigation.page.js'
import { getSafes, CATEGORIES } from '../../support/safes/safesHandler.js'
import { getEvents, events, checkDataLayerEvents } from '../../support/utils/gtag.js'
import * as wallet from '../../support/utils/wallet.js'
let safeAppSafes = []
let iframeSelector
const walletCredentials = JSON.parse(Cypress.env('CYPRESS_WALLET_CREDENTIALS'))
const signer = walletCredentials.OWNER_4_PRIVATE_KEY
const signer2 = walletCredentials.OWNER_1_PRIVATE_KEY
describe('Transaction Builder happy path tests', { defaultCommandTimeout: 20000 }, () => {
before(async () => {
safeAppSafes = await getSafes(CATEGORIES.safeapps)
})
it(
'Verify a simple batch can be created, signed by second signer and deleted. GA tx_confirm, tx_created',
{ defaultCommandTimeout: 50000 },
() => {
const tx_created = [
{
eventLabel: events.txCreatedTxBuilder.eventLabel,
eventCategory: events.txCreatedTxBuilder.category,
eventType: events.txCreatedTxBuilder.eventType,
event: events.txCreatedTxBuilder.event,
safeAddress: safeAppSafes.SEP_SAFEAPP_SAFE_1.slice(6),
},
]
const tx_confirmed = [
{
eventLabel: events.txConfirmedTxBuilder.eventLabel,
eventCategory: events.txConfirmedTxBuilder.category,
eventType: events.txConfirmedTxBuilder.eventType,
safeAddress: safeAppSafes.SEP_SAFEAPP_SAFE_1.slice(6),
},
]
const appUrl = constants.TX_Builder_url
iframeSelector = `iframe[id="iframe-${encodeURIComponent(appUrl)}"]`
const visitUrl = `/apps/open?safe=${safeAppSafes.SEP_SAFEAPP_SAFE_1}&appUrl=${encodeURIComponent(appUrl)}`
wallet.connectSignerViaStorage(signer, constants.transactionQueueUrl + safeAppSafes.SEP_SAFEAPP_SAFE_1)
cy.wait(5000)
createtx.deleteAllTx()
cy.visit(visitUrl)
navigation.verifyTxBtnStatus(constants.enabledStates.enabled)
cy.enter(iframeSelector).then((getBody) => {
getBody().findByLabelText(safeapps.enterAddressStr).type(constants.SAFE_APP_ADDRESS)
getBody().find(safeapps.contractMethodIndex).parent().click()
getBody().findByRole('option', { name: safeapps.testAddressValue2 }).click()
getBody().findByLabelText(safeapps.newAddressValueStr).type(safeAppSafes.SEP_SAFEAPP_SAFE_2)
getBody().findByText(safeapps.addTransactionStr).click()
getBody().findAllByText(constants.SEPOLIA_CONTRACT_SHORT).should('have.length', 1)
getBody().findByText(safeapps.testAddressValueStr).should('exist')
getBody().findByText(safeapps.createBatchStr).click()
getBody().findByText(safeapps.sendBatchStr).click()
})
createtx.clickOnContinueSignTransactionBtn()
createtx.clickOnSignTransactionBtn()
createtx.clickViewTransaction()
navigation.clickOnWalletExpandMoreIcon()
navigation.clickOnDisconnectBtn()
wallet.connectSigner(signer2)
navigation.verifyTxBtnStatus(constants.enabledStates.enabled)
createtx.clickOnConfirmTransactionBtn()
createtx.clickOnContinueSignTransactionBtn()
createtx.selectComboButtonOption('sign')
createtx.clickOnSignTransactionBtn()
navigation.clickOnWalletExpandMoreIcon()
navigation.clickOnDisconnectBtn()
wallet.connectSigner(signer)
navigation.verifyTxBtnStatus(constants.enabledStates.enabled)
createtx.deleteTx()
createtx.verifyNumberOfTransactions(0)
getEvents()
checkDataLayerEvents(tx_created)
checkDataLayerEvents(tx_confirmed)
},
)
})