Files
05cab32f0e tests(web): connect wallet via seeded storage in e2e (#8350)
* tests(web): connect wallet via seeded storage in e2e

Replace the UI-driven connectSigner flow with storage-seeded auto-reconnect
across the Cypress suite. Adds connectSignerViaStorage (seed on visit, or seed
+ reload) and migrates 139 entry connects; keeps UI connectSigner for the 27
connect/switch-flow sites that act on in-page state.

* tests(web): seed batch via single page load in batch e2e

Add optional extraStorage to connectSignerViaStorage so localStorage is
seeded in onBeforeLoad on the initial visit. Split batch_tx into
build-via-UI and pre-seeded describes, dropping addToLocalStorage +
cy.reload() double-loads.

* tests(web): seed state on a single page load across e2e specs

Replace visit-then-write-then-reload double-loads with a single seeded
load (extraStorage on connectSignerViaStorage, or onBeforeLoad on
cy.visit), and drop the arbitrary post-reload settle waits. Covers the
multichain, nested-safes, batch, address-book, safe-selector and
create-safe specs (regression, smoke, visual).

* tests(web): seed state on a single page load in more e2e specs

Fold pre-seeded localStorage into the initial visit (extraStorage /
onBeforeLoad) and drop the follow-up reloads across the address-book,
messages-popup, CF-safe, import/export and load-safe specs. Split specs
whose shared beforeEach served both seeding and non-seeding tests into
nested describes so no test double-loads.

* tests(web): remove redundant wallet reconnect reloads in e2e specs

Pass the URL to connectSignerViaStorage so the wallet is seeded on the
initial visit instead of visiting then reconnecting (which reloaded).
Where a shared beforeEach served both connected and disconnected (or
differently-seeded) tests, split into nested describes so no test
double-loads. Covers proposers, swaps, twaps, assets, swaps_tokens,
sidebar, spending_limits, bulk_execution, proposers_2, safe_selector.

* tests(web): single-load owner-management e2e specs

Split add/remove/replace-owner specs into connected / disconnected /
non-owner / pre-seeded describes so the wallet is seeded on the initial
visit (no reconnect reload) without forcing a connect onto tests that
assert disconnected or non-owner state.

* tests(web): wait for wallet connection after seeded connect

The last wallet reconnects asynchronously after the page loads, so
connectSignerViaStorage now waits for the connected-wallet header chip
(open-account-center) before resolving, instead of letting tests proceed
while still disconnected. Opt out via waitForConnection:false for pages
without that chip (welcome/accounts in safe_selector).

* tests(web): address review on seeded-connect PR

- Drop the explicit 30s timeout on the connected-wallet wait; the repo
  default (10s) is plenty for the post-load reconnect and fails faster.
- Make recovery.cy.js consistent: the remaining connectSigner calls now
  use connectSignerViaStorage like the rest of the file. All connects are
  at test start (none mid-flow), matching the already-converted tests.

* fix: wait for the wallet connection to establish to avoid failing tests due to disconnected wallet

---------

Co-authored-by: vmosharova <[email protected]>
2026-07-31 17:00:56 +02:00

97 lines
3.8 KiB
JavaScript

import * as constants from '../../support/constants'
import * as main from '../../e2e/pages/main.page'
import * as owner from '../pages/owners.pages'
import * as addressBook from '../pages/address_book.page'
import { getSafes, CATEGORIES } from '../../support/safes/safesHandler.js'
import * as wallet from '../../support/utils/wallet.js'
import { getMockAddress } from '../../support/utils/ethers.js'
let staticSafes = []
const walletCredentials = JSON.parse(Cypress.env('CYPRESS_WALLET_CREDENTIALS'))
const signer = walletCredentials.OWNER_4_PRIVATE_KEY
describe('Add Owners tests', () => {
before(async () => {
staticSafes = await getSafes(CATEGORIES.static)
})
describe('Disconnected', () => {
beforeEach(() => {
cy.visit(constants.setupUrl + staticSafes.SEP_STATIC_SAFE_4)
cy.contains(owner.safeAccountNonceStr, { timeout: 10000 })
})
// Added to prod
it('Verify add owner button is disabled for disconnected user', () => {
owner.verifyManageSignersBtnIsDisabled()
})
})
describe('Connected', () => {
beforeEach(() => {
wallet.connectSignerViaStorage(signer, constants.setupUrl + staticSafes.SEP_STATIC_SAFE_4)
cy.contains(owner.safeAccountNonceStr, { timeout: 10000 })
})
// Added to prod
it('Verify the Add New Owner Form can be opened', () => {
owner.openManageSignersWindow()
})
it('Verify error message displayed if character limit is exceeded in Name input', () => {
owner.openManageSignersWindow()
owner.clickOnAddSignerBtn()
owner.typeOwnerNameManage(1, main.generateRandomString(51))
owner.verifyErrorMsgInvalidAddress(constants.addressBookErrrMsg.exceedChars)
})
//The case should be updated with review "Add owner" field on next page and other options
it('Verify that Name field not mandatory', () => {
owner.openManageSignersWindow()
owner.clickOnAddSignerBtn()
owner.typeOwnerAddressManage(1, getMockAddress())
owner.clickOnNextBtnManage()
owner.verifyConfirmTransactionWindowDisplayed()
})
it('Verify default threshold value. Verify correct threshold calculation', () => {
owner.openManageSignersWindow()
owner.clickOnAddSignerBtn()
owner.typeOwnerAddressManage(1, constants.DEFAULT_OWNER_ADDRESS)
owner.verifyThreshold(1, 2)
})
//TBD the case should be updated with additional steps to verify a new owner address and name
it('Verify valid Address validation', () => {
owner.openManageSignersWindow()
owner.clickOnAddSignerBtn()
owner.typeOwnerAddressManage(1, constants.SEPOLIA_OWNER_2)
owner.clickOnNextBtnManage()
owner.verifyConfirmTransactionWindowDisplayed()
owner.clickOnBackBtn()
owner.typeOwnerAddressManage(1, staticSafes.SEP_STATIC_SAFE_3)
owner.clickOnNextBtnManage()
owner.verifyConfirmTransactionWindowDisplayed()
})
})
describe('Address book autofill', () => {
it('Verify that the "Name" field is auto-filled with the relevant name from Address Book', () => {
cy.visit(constants.addressBookUrl + staticSafes.SEP_STATIC_SAFE_4)
addressBook.clickOnCreateEntryBtn()
addressBook.typeInName(constants.addresBookContacts.user1.name)
addressBook.typeInAddress(constants.addresBookContacts.user1.address)
addressBook.clickOnSaveEntryBtn()
addressBook.verifyNewEntryAdded(
constants.addresBookContacts.user1.name,
constants.addresBookContacts.user1.address,
)
wallet.connectSignerViaStorage(signer, constants.setupUrl + staticSafes.SEP_STATIC_SAFE_4)
owner.openManageSignersWindow()
owner.clickOnAddSignerBtn()
owner.typeOwnerAddressManage(1, constants.addresBookContacts.user1.address)
owner.verifyNewOwnerName(1, constants.addresBookContacts.user1.name)
})
})
})