mirror of
https://github.com/luxfi/safe-wallet.git
synced 2026-10-30 15:19:21 +00:00
05cab32f0e
* tests(web): connect wallet via seeded storage in e2e Replace the UI-driven connectSigner flow with storage-seeded auto-reconnect across the Cypress suite. Adds connectSignerViaStorage (seed on visit, or seed + reload) and migrates 139 entry connects; keeps UI connectSigner for the 27 connect/switch-flow sites that act on in-page state. * tests(web): seed batch via single page load in batch e2e Add optional extraStorage to connectSignerViaStorage so localStorage is seeded in onBeforeLoad on the initial visit. Split batch_tx into build-via-UI and pre-seeded describes, dropping addToLocalStorage + cy.reload() double-loads. * tests(web): seed state on a single page load across e2e specs Replace visit-then-write-then-reload double-loads with a single seeded load (extraStorage on connectSignerViaStorage, or onBeforeLoad on cy.visit), and drop the arbitrary post-reload settle waits. Covers the multichain, nested-safes, batch, address-book, safe-selector and create-safe specs (regression, smoke, visual). * tests(web): seed state on a single page load in more e2e specs Fold pre-seeded localStorage into the initial visit (extraStorage / onBeforeLoad) and drop the follow-up reloads across the address-book, messages-popup, CF-safe, import/export and load-safe specs. Split specs whose shared beforeEach served both seeding and non-seeding tests into nested describes so no test double-loads. * tests(web): remove redundant wallet reconnect reloads in e2e specs Pass the URL to connectSignerViaStorage so the wallet is seeded on the initial visit instead of visiting then reconnecting (which reloaded). Where a shared beforeEach served both connected and disconnected (or differently-seeded) tests, split into nested describes so no test double-loads. Covers proposers, swaps, twaps, assets, swaps_tokens, sidebar, spending_limits, bulk_execution, proposers_2, safe_selector. * tests(web): single-load owner-management e2e specs Split add/remove/replace-owner specs into connected / disconnected / non-owner / pre-seeded describes so the wallet is seeded on the initial visit (no reconnect reload) without forcing a connect onto tests that assert disconnected or non-owner state. * tests(web): wait for wallet connection after seeded connect The last wallet reconnects asynchronously after the page loads, so connectSignerViaStorage now waits for the connected-wallet header chip (open-account-center) before resolving, instead of letting tests proceed while still disconnected. Opt out via waitForConnection:false for pages without that chip (welcome/accounts in safe_selector). * tests(web): address review on seeded-connect PR - Drop the explicit 30s timeout on the connected-wallet wait; the repo default (10s) is plenty for the post-load reconnect and fails faster. - Make recovery.cy.js consistent: the remaining connectSigner calls now use connectSignerViaStorage like the rest of the file. All connects are at test start (none mid-flow), matching the already-converted tests. * fix: wait for the wallet connection to establish to avoid failing tests due to disconnected wallet --------- Co-authored-by: vmosharova <[email protected]>
101 lines
4.2 KiB
JavaScript
101 lines
4.2 KiB
JavaScript
import * as constants from '../../support/constants.js'
|
|
import * as main from '../pages/main.page.js'
|
|
import * as owner from '../pages/owners.pages.js'
|
|
import { getSafes, CATEGORIES } from '../../support/safes/safesHandler.js'
|
|
import * as wallet from '../../support/utils/wallet.js'
|
|
import * as navigation from '../pages/navigation.page.js'
|
|
import * as ls from '../../support/localstorage_data.js'
|
|
import * as proposer from '../pages/proposers.pages.js'
|
|
import { getMockAddress } from '../../support/utils/ethers.js'
|
|
|
|
let staticSafes = []
|
|
const walletCredentials = JSON.parse(Cypress.env('CYPRESS_WALLET_CREDENTIALS'))
|
|
const signer = walletCredentials.OWNER_4_PRIVATE_KEY
|
|
const signer2 = walletCredentials.OWNER_1_PRIVATE_KEY
|
|
const proposerAddress = 'sep:0xC16D...6fED'
|
|
const proposerAddress2 = '0x8eeC...2a3b'
|
|
const creatorAddress = 'sep:0xC16D...6fED'
|
|
const proposerName = 'Proposer 1'
|
|
const proposerNameAD = 'AD Proposer1'
|
|
const proposedTx =
|
|
'&id=multisig_0x09725D3c2f9bE905F8f9f1b11a771122cf9C9f35_0xd70f2f8b31ae98a7e3064f6cdb437e71d3df083a0709fb82c915fa82767a19eb'
|
|
|
|
describe('Proposers tests', () => {
|
|
before(async () => {
|
|
staticSafes = await getSafes(CATEGORIES.static)
|
|
})
|
|
|
|
beforeEach(() => {
|
|
wallet.connectSignerViaStorage(signer, constants.setupUrl + staticSafes.SEP_STATIC_SAFE_31)
|
|
cy.contains(owner.safeAccountNonceStr, { timeout: 10000 })
|
|
})
|
|
|
|
it('Verify the proposers section on the Set up in the settings when there are no proposers', () => {
|
|
main.verifyElementsCount(proposer.proposersSection, 1)
|
|
})
|
|
|
|
it('Verify the "Add proposers" button is disabled for non-owner/disconnected users', () => {
|
|
navigation.clickOnWalletExpandMoreIcon()
|
|
navigation.clickOnDisconnectBtn()
|
|
proposer.verifyAddProposerBtnIsDisabled()
|
|
wallet.connectSigner(signer2)
|
|
proposer.verifyAddProposerBtnIsDisabled()
|
|
})
|
|
|
|
it('Verify that a proposer cannot be the safe itself', () => {
|
|
proposer.clickOnAddProposerBtn()
|
|
proposer.enterProposerData(staticSafes.SEP_STATIC_SAFE_31.substring(4), main.generateRandomString(5))
|
|
proposer.checkSafeAsProposerErrorMessage()
|
|
})
|
|
|
|
it('Verify that a proposer address must be checksummed', () => {
|
|
proposer.clickOnAddProposerBtn()
|
|
proposer.enterProposerData(getMockAddress().replace('A', 'a'), main.generateRandomString(5))
|
|
owner.verifyErrorMsgInvalidAddress(constants.addressBookErrrMsg.invalidChecksum)
|
|
})
|
|
|
|
it('Verify a proposer Creator is shown in the table', () => {
|
|
proposer.checkCreatorAddress([creatorAddress])
|
|
})
|
|
|
|
it('Verify non-creators of a proposers cannot edit or delete it', () => {
|
|
navigation.clickOnWalletExpandMoreIcon()
|
|
navigation.clickOnDisconnectBtn()
|
|
wallet.connectSigner(signer2)
|
|
proposer.verifyDeleteProposerBtnIsDisabled(proposerAddress)
|
|
proposer.verifyEditProposerBtnDisabled(proposerAddress)
|
|
})
|
|
|
|
it('Verify if the address book entry of propers name is removed, then the name given during its creation shows again', () => {
|
|
proposer.checkProposerData([proposerName])
|
|
})
|
|
|
|
it('Verify Proposers cannot see the "Batched tx" button in the header', () => {
|
|
navigation.clickOnWalletExpandMoreIcon()
|
|
navigation.clickOnDisconnectBtn()
|
|
wallet.connectSigner(signer2)
|
|
proposer.verifyBatchDoesNotExist()
|
|
})
|
|
|
|
it('Verify a tx with the "proposal" status shows a message about being created by a proposer', () => {
|
|
cy.visit(constants.transactionUrl + staticSafes.SEP_STATIC_SAFE_31 + proposedTx)
|
|
proposer.verifyPropsalStatusExists()
|
|
proposer.verifyProposedTxMsgVisible()
|
|
})
|
|
|
|
it('Verify a tx with the "proposal" status shows the details of a proposer', () => {
|
|
cy.visit(constants.transactionUrl + staticSafes.SEP_STATIC_SAFE_31 + proposedTx)
|
|
proposer.verifyProposerInTxActionList(proposerAddress2)
|
|
})
|
|
|
|
describe('With a pre-seeded address book', () => {
|
|
it('Verify that the address book name of the proposers overwrites the name given during its creation', () => {
|
|
wallet.connectSignerViaStorage(signer, constants.setupUrl + staticSafes.SEP_STATIC_SAFE_31, {
|
|
extraStorage: { [constants.localStorageKeys.SAFE_v2__addressBook]: ls.addressBookData.proposers },
|
|
})
|
|
cy.contains(owner.safeAccountNonceStr, { timeout: 10000 })
|
|
proposer.checkProposerData([proposerNameAD])
|
|
})
|
|
})
|
|
})
|