mirror of
https://github.com/luxfi/safe-wallet.git
synced 2026-10-30 15:19:21 +00:00
05cab32f0e
* tests(web): connect wallet via seeded storage in e2e Replace the UI-driven connectSigner flow with storage-seeded auto-reconnect across the Cypress suite. Adds connectSignerViaStorage (seed on visit, or seed + reload) and migrates 139 entry connects; keeps UI connectSigner for the 27 connect/switch-flow sites that act on in-page state. * tests(web): seed batch via single page load in batch e2e Add optional extraStorage to connectSignerViaStorage so localStorage is seeded in onBeforeLoad on the initial visit. Split batch_tx into build-via-UI and pre-seeded describes, dropping addToLocalStorage + cy.reload() double-loads. * tests(web): seed state on a single page load across e2e specs Replace visit-then-write-then-reload double-loads with a single seeded load (extraStorage on connectSignerViaStorage, or onBeforeLoad on cy.visit), and drop the arbitrary post-reload settle waits. Covers the multichain, nested-safes, batch, address-book, safe-selector and create-safe specs (regression, smoke, visual). * tests(web): seed state on a single page load in more e2e specs Fold pre-seeded localStorage into the initial visit (extraStorage / onBeforeLoad) and drop the follow-up reloads across the address-book, messages-popup, CF-safe, import/export and load-safe specs. Split specs whose shared beforeEach served both seeding and non-seeding tests into nested describes so no test double-loads. * tests(web): remove redundant wallet reconnect reloads in e2e specs Pass the URL to connectSignerViaStorage so the wallet is seeded on the initial visit instead of visiting then reconnecting (which reloaded). Where a shared beforeEach served both connected and disconnected (or differently-seeded) tests, split into nested describes so no test double-loads. Covers proposers, swaps, twaps, assets, swaps_tokens, sidebar, spending_limits, bulk_execution, proposers_2, safe_selector. * tests(web): single-load owner-management e2e specs Split add/remove/replace-owner specs into connected / disconnected / non-owner / pre-seeded describes so the wallet is seeded on the initial visit (no reconnect reload) without forcing a connect onto tests that assert disconnected or non-owner state. * tests(web): wait for wallet connection after seeded connect The last wallet reconnects asynchronously after the page loads, so connectSignerViaStorage now waits for the connected-wallet header chip (open-account-center) before resolving, instead of letting tests proceed while still disconnected. Opt out via waitForConnection:false for pages without that chip (welcome/accounts in safe_selector). * tests(web): address review on seeded-connect PR - Drop the explicit 30s timeout on the connected-wallet wait; the repo default (10s) is plenty for the post-load reconnect and fails faster. - Make recovery.cy.js consistent: the remaining connectSigner calls now use connectSignerViaStorage like the rest of the file. All connects are at test start (none mid-flow), matching the already-converted tests. * fix: wait for the wallet connection to establish to avoid failing tests due to disconnected wallet --------- Co-authored-by: vmosharova <[email protected]>
113 lines
4.4 KiB
JavaScript
113 lines
4.4 KiB
JavaScript
import * as constants from '../../support/constants'
|
|
import * as main from '../../e2e/pages/main.page'
|
|
import * as owner from '../pages/owners.pages'
|
|
import * as createTx from '../pages/create_tx.pages.js'
|
|
import { getSafes, CATEGORIES } from '../../support/safes/safesHandler.js'
|
|
import * as wallet from '../../support/utils/wallet.js'
|
|
import * as ls from '../../support/localstorage_data.js'
|
|
import { getEvents, events, checkDataLayerEvents } from '../../support/utils/gtag.js'
|
|
import { getMockAddress } from '../../support/utils/ethers.js'
|
|
|
|
let staticSafes = []
|
|
const walletCredentials = JSON.parse(Cypress.env('CYPRESS_WALLET_CREDENTIALS'))
|
|
const signer = walletCredentials.OWNER_4_PRIVATE_KEY
|
|
|
|
const ownerName = 'Replacement Signer Name'
|
|
|
|
describe('Replace Owners tests', () => {
|
|
before(async () => {
|
|
staticSafes = await getSafes(CATEGORIES.static)
|
|
})
|
|
|
|
describe('Disconnected', () => {
|
|
beforeEach(() => {
|
|
cy.visit(constants.setupUrl + staticSafes.SEP_STATIC_SAFE_4)
|
|
cy.contains(owner.safeAccountNonceStr, { timeout: 10000 })
|
|
})
|
|
|
|
it('Verify Tooltip displays correct message for disconnected user', () => {
|
|
owner.verifyReplaceBtnIsDisabled()
|
|
})
|
|
})
|
|
|
|
describe('Connected', () => {
|
|
beforeEach(() => {
|
|
wallet.connectSignerViaStorage(signer, constants.setupUrl + staticSafes.SEP_STATIC_SAFE_4)
|
|
cy.contains(owner.safeAccountNonceStr, { timeout: 10000 })
|
|
owner.waitForConnectionStatus()
|
|
})
|
|
|
|
// TODO: Check unit tests
|
|
it('Verify max characters in name field', () => {
|
|
owner.openReplaceOwnerWindow(0)
|
|
owner.typeOwnerName(main.generateRandomString(51))
|
|
owner.verifyErrorMsgInvalidAddress(constants.addressBookErrrMsg.exceedChars)
|
|
})
|
|
|
|
it('Verify that Name field not mandatory. Verify confirmation for owner replacement is displayed', () => {
|
|
owner.openReplaceOwnerWindow(0)
|
|
owner.typeOwnerAddress(getMockAddress())
|
|
owner.clickOnNextBtn()
|
|
owner.verifyConfirmTransactionWindowDisplayed()
|
|
})
|
|
|
|
it('Verify relevant error messages are displayed in Address input', () => {
|
|
owner.openReplaceOwnerWindow(0)
|
|
owner.typeOwnerAddress(main.generateRandomString(10))
|
|
owner.verifyErrorMsgInvalidAddress(constants.addressBookErrrMsg.invalidFormat)
|
|
|
|
owner.typeOwnerAddress(getMockAddress().toUpperCase())
|
|
owner.verifyErrorMsgInvalidAddress(constants.addressBookErrrMsg.invalidChecksum)
|
|
|
|
owner.typeOwnerAddress(staticSafes.SEP_STATIC_SAFE_4)
|
|
owner.verifyErrorMsgInvalidAddress(constants.addressBookErrrMsg.ownSafe)
|
|
|
|
owner.typeOwnerAddress(getMockAddress().replace('A', 'a'))
|
|
owner.verifyErrorMsgInvalidAddress(constants.addressBookErrrMsg.invalidChecksum)
|
|
|
|
owner.typeOwnerAddress(constants.DEFAULT_OWNER_ADDRESS)
|
|
owner.verifyErrorMsgInvalidAddress(constants.addressBookErrrMsg.alreadyAdded)
|
|
})
|
|
})
|
|
|
|
describe('With a pre-seeded address book', () => {
|
|
it('Verify that Address input auto-fills with related value', () => {
|
|
wallet.connectSignerViaStorage(signer, constants.setupUrl + staticSafes.SEP_STATIC_SAFE_4, {
|
|
extraStorage: { [constants.localStorageKeys.SAFE_v2__addressBook]: ls.addressBookData.autofillData },
|
|
})
|
|
owner.waitForConnectionStatus()
|
|
owner.openReplaceOwnerWindow(0)
|
|
owner.typeOwnerAddress(constants.addresBookContacts.user1.address)
|
|
owner.verifyNewOwnerName(constants.addresBookContacts.user1.name)
|
|
})
|
|
})
|
|
|
|
describe('On another safe', () => {
|
|
it("Verify 'Replace' tx is created. GA tx_created", () => {
|
|
const tx_created = [
|
|
{
|
|
eventLabel: events.txCreatedSwapOwner.eventLabel,
|
|
eventCategory: events.txCreatedSwapOwner.category,
|
|
eventAction: events.txCreatedSwapOwner.action,
|
|
event: events.txCreatedSwapOwner.eventName,
|
|
safeAddress: staticSafes.SEP_STATIC_SAFE_25.slice(6),
|
|
},
|
|
]
|
|
wallet.connectSignerViaStorage(signer, constants.setupUrl + staticSafes.SEP_STATIC_SAFE_25)
|
|
owner.waitForConnectionStatus()
|
|
owner.openReplaceOwnerWindow(1)
|
|
cy.wait(1000)
|
|
owner.typeOwnerName(ownerName)
|
|
owner.typeOwnerAddress(constants.SEPOLIA_OWNER_2)
|
|
createTx.changeNonce(0)
|
|
owner.clickOnNextBtn()
|
|
createTx.clickOnContinueSignTransactionBtn()
|
|
createTx.clickOnSignTransactionBtn()
|
|
createTx.clickViewTransaction()
|
|
createTx.verifyReplacedSigner(ownerName)
|
|
getEvents()
|
|
checkDataLayerEvents(tx_created)
|
|
})
|
|
})
|
|
})
|