mirror of
https://github.com/luxfi/safe-wallet.git
synced 2026-10-30 15:19:21 +00:00
05cab32f0e
* tests(web): connect wallet via seeded storage in e2e Replace the UI-driven connectSigner flow with storage-seeded auto-reconnect across the Cypress suite. Adds connectSignerViaStorage (seed on visit, or seed + reload) and migrates 139 entry connects; keeps UI connectSigner for the 27 connect/switch-flow sites that act on in-page state. * tests(web): seed batch via single page load in batch e2e Add optional extraStorage to connectSignerViaStorage so localStorage is seeded in onBeforeLoad on the initial visit. Split batch_tx into build-via-UI and pre-seeded describes, dropping addToLocalStorage + cy.reload() double-loads. * tests(web): seed state on a single page load across e2e specs Replace visit-then-write-then-reload double-loads with a single seeded load (extraStorage on connectSignerViaStorage, or onBeforeLoad on cy.visit), and drop the arbitrary post-reload settle waits. Covers the multichain, nested-safes, batch, address-book, safe-selector and create-safe specs (regression, smoke, visual). * tests(web): seed state on a single page load in more e2e specs Fold pre-seeded localStorage into the initial visit (extraStorage / onBeforeLoad) and drop the follow-up reloads across the address-book, messages-popup, CF-safe, import/export and load-safe specs. Split specs whose shared beforeEach served both seeding and non-seeding tests into nested describes so no test double-loads. * tests(web): remove redundant wallet reconnect reloads in e2e specs Pass the URL to connectSignerViaStorage so the wallet is seeded on the initial visit instead of visiting then reconnecting (which reloaded). Where a shared beforeEach served both connected and disconnected (or differently-seeded) tests, split into nested describes so no test double-loads. Covers proposers, swaps, twaps, assets, swaps_tokens, sidebar, spending_limits, bulk_execution, proposers_2, safe_selector. * tests(web): single-load owner-management e2e specs Split add/remove/replace-owner specs into connected / disconnected / non-owner / pre-seeded describes so the wallet is seeded on the initial visit (no reconnect reload) without forcing a connect onto tests that assert disconnected or non-owner state. * tests(web): wait for wallet connection after seeded connect The last wallet reconnects asynchronously after the page loads, so connectSignerViaStorage now waits for the connected-wallet header chip (open-account-center) before resolving, instead of letting tests proceed while still disconnected. Opt out via waitForConnection:false for pages without that chip (welcome/accounts in safe_selector). * tests(web): address review on seeded-connect PR - Drop the explicit 30s timeout on the connected-wallet wait; the repo default (10s) is plenty for the post-load reconnect and fails faster. - Make recovery.cy.js consistent: the remaining connectSigner calls now use connectSignerViaStorage like the rest of the file. All connects are at test start (none mid-flow), matching the already-converted tests. * fix: wait for the wallet connection to establish to avoid failing tests due to disconnected wallet --------- Co-authored-by: vmosharova <[email protected]>
321 lines
14 KiB
JavaScript
321 lines
14 KiB
JavaScript
import * as constants from '../../support/constants'
|
|
import * as main from '../pages/main.page'
|
|
import * as safeNav from '../pages/safe_navigation.pages'
|
|
import * as sideBar from '../pages/sidebar.pages'
|
|
import * as assets from '../pages/assets.pages.js'
|
|
import * as accountsModal from '../pages/accounts_modal.pages.js'
|
|
import * as ls from '../../support/localstorage_data.js'
|
|
import * as create_wallet from '../pages/create_wallet.pages.js'
|
|
import * as dashboard from '../pages/dashboard.pages.js'
|
|
import * as navigation from '../pages/navigation.page.js'
|
|
import { getSafes, CATEGORIES } from '../../support/safes/safesHandler.js'
|
|
import * as wallet from '../../support/utils/wallet.js'
|
|
import safes from '../../fixtures/safes/static.js'
|
|
|
|
let staticSafes = []
|
|
|
|
const newSafeName = 'Added safe 3'
|
|
const addedSafe900 = 'Added safe 900'
|
|
|
|
const walletCredentials = JSON.parse(Cypress.env('CYPRESS_WALLET_CREDENTIALS'))
|
|
const signer = walletCredentials.OWNER_4_PRIVATE_KEY
|
|
const signer1 = walletCredentials.OWNER_1_PRIVATE_KEY
|
|
const signer2 = walletCredentials.OWNER_3_PRIVATE_KEY
|
|
|
|
describe('Safe selector tests - connect wallet prompt', () => {
|
|
before(async () => {
|
|
staticSafes = await getSafes(CATEGORIES.static)
|
|
})
|
|
|
|
it('Verify connect wallet button is shown in the dropdown when wallet is not connected and no safes are added', () => {
|
|
cy.visit(constants.homeUrl + staticSafes.SEP_STATIC_SAFE_9, { skipAutoTrust: true })
|
|
safeNav.openSelector()
|
|
safeNav.verifyConnectWalletBtnVisible()
|
|
})
|
|
})
|
|
|
|
describe('Safe selector tests - details and currency', () => {
|
|
before(async () => {
|
|
staticSafes = await getSafes(CATEGORIES.static)
|
|
})
|
|
|
|
it('Verify current safe details are shown in the safe selector trigger', () => {
|
|
cy.visit(constants.homeUrl + staticSafes.SEP_STATIC_SAFE_9)
|
|
safeNav.verifySafeIconVisible()
|
|
safeNav.verifySafeSelectorTriggerName(safes.SEP_STATIC_SAFE_9_SHORT)
|
|
safeNav.verifySafeSelectorThreshold(2, 2)
|
|
})
|
|
|
|
it('Verify fiat currency changes when edited in the assets tab are reflected in the safe selector trigger', () => {
|
|
cy.visit(constants.BALANCE_URL + staticSafes.SEP_STATIC_SAFE_9)
|
|
assets.changeCurrency(assets.currencyCAD)
|
|
safeNav.verifyCurrencySection(assets.currency$)
|
|
})
|
|
})
|
|
|
|
describe('Safe selector tests - trusted safes in accounts modal', () => {
|
|
before(async () => {
|
|
staticSafes = await getSafes(CATEGORIES.static)
|
|
})
|
|
|
|
beforeEach(() => {
|
|
main.addToLocalStorage(constants.localStorageKeys.SAFE_v2__addedSafes, ls.addedSafes.sidebarTrustedSafe1Safe2)
|
|
cy.visit(constants.homeUrl + staticSafes.SEP_STATIC_SAFE_9)
|
|
})
|
|
|
|
it('Verify that trusted safes appear in the accounts modal under Trusted Safes', () => {
|
|
accountsModal.openAccountsModal()
|
|
accountsModal.verifyPinnedAccountsSectionVisible()
|
|
accountsModal.verifyPinnedSafeExists(sideBar.sideBarSafes.safe1short)
|
|
accountsModal.verifyPinnedSafeExists(sideBar.sideBarSafes.safe2short)
|
|
})
|
|
|
|
it('Verify there is an option to rename an unnamed safe in the accounts modal', () => {
|
|
accountsModal.openAccountsModal()
|
|
accountsModal.clickSafeOptionsBtn(0)
|
|
})
|
|
})
|
|
|
|
describe('Safe selector tests - pin/unpin and undeployed safes', () => {
|
|
before(async () => {
|
|
staticSafes = await getSafes(CATEGORIES.static)
|
|
})
|
|
|
|
it('Verify "Add accounts" button is displayed on the accounts page', () => {
|
|
wallet.connectSignerViaStorage(signer, constants.welcomeAccountsSepoliaUrl, { waitForConnection: false })
|
|
accountsModal.verifyAddAccountsButtonVisible()
|
|
})
|
|
|
|
it('Verify a safe can be removed from the trusted list', () => {
|
|
main.addToLocalStorage(constants.localStorageKeys.SAFE_v2__addedSafes, ls.addedSafes.sidebarTrustedSafe1Safe2)
|
|
wallet.connectSignerViaStorage(signer, constants.homeUrl + staticSafes.SEP_STATIC_SAFE_9)
|
|
accountsModal.openAccountsModal()
|
|
accountsModal.verifyPinnedAccountsSectionVisible()
|
|
accountsModal.unpinSafeByName(sideBar.sideBarSafes.safe1short)
|
|
accountsModal.openAccountsModal()
|
|
accountsModal.verifyPinnedSafeExists(sideBar.sideBarSafes.safe2short)
|
|
accountsModal.verifyPinnedSafeDoesNotExist(sideBar.sideBarSafes.safe1short)
|
|
})
|
|
|
|
it('Verify undeployed safe appears in the trusted list', () => {
|
|
main.addToLocalStorage(constants.localStorageKeys.SAFE_v2__addedSafes, ls.addedSafes.set6_undeployed_safe)
|
|
main.addToLocalStorage(constants.localStorageKeys.SAFE_v2__undeployedSafes, ls.undeployedSafe.safe1)
|
|
wallet.connectSignerViaStorage(signer, constants.homeUrl + staticSafes.SEP_STATIC_SAFE_9)
|
|
accountsModal.openAccountsModal()
|
|
accountsModal.verifyPinnedAccountsSectionVisible()
|
|
accountsModal.verifyPinnedSafeExists(sideBar.sideBarSafes.safe4short)
|
|
})
|
|
|
|
it('Verify untrusted safe can be added to trusted list from dashboard action required panel', () => {
|
|
wallet.connectSignerViaStorage(signer, constants.homeUrl + staticSafes.SEP_STATIC_SAFE_9, { skipAutoTrust: true })
|
|
dashboard.verifyActionRequiredCard({ messages: [dashboard.nonPinnedWarningTitle] })
|
|
dashboard.clickActionInPanel(dashboard.trustThisSafeButtonTestId)
|
|
dashboard.verifyTrustDialogVisible()
|
|
})
|
|
})
|
|
|
|
describe('Safe selector tests - accounts modal search', () => {
|
|
before(async () => {
|
|
staticSafes = await getSafes(CATEGORIES.static)
|
|
})
|
|
|
|
it('Verify the search input is shown above the pinned safes list', () => {
|
|
main.addToLocalStorage(constants.localStorageKeys.SAFE_v2__addedSafes, ls.addedSafes.sidebarTrustedSafe1)
|
|
cy.visit(constants.homeUrl + staticSafes.SEP_STATIC_SAFE_9)
|
|
accountsModal.openAccountsModal()
|
|
accountsModal.verifySearchInputAbovePinnedSection()
|
|
})
|
|
|
|
it('Verify search finds safes in the trusted list', () => {
|
|
main.addToLocalStorage(constants.localStorageKeys.SAFE_v2__addedSafes, ls.addedSafes.sidebarTrustedSafe1Safe2)
|
|
cy.visit(constants.homeUrl + staticSafes.SEP_STATIC_SAFE_9)
|
|
accountsModal.openAccountsModal()
|
|
accountsModal.searchSafe(sideBar.sideBarSafes.safe1short_)
|
|
accountsModal.verifyAccountsListContains(sideBar.sideBarSafes.safe1short)
|
|
accountsModal.verifyAccountsListItemCount(1)
|
|
})
|
|
|
|
it('Verify searching for a safe name filters out those who do not match', () => {
|
|
main.addToLocalStorage(constants.localStorageKeys.SAFE_v2__addedSafes, ls.addedSafes.sidebarTrustedSafe1Safe2)
|
|
cy.visit(constants.homeUrl + staticSafes.SEP_STATIC_SAFE_9)
|
|
accountsModal.openAccountsModal()
|
|
accountsModal.searchSafe(sideBar.sideBarSafes.safe1short_)
|
|
accountsModal.verifyAccountsListContains(sideBar.sideBarSafes.safe1short)
|
|
accountsModal.verifyAccountsListDoesNotContain(sideBar.sideBarSafes.safe2short)
|
|
})
|
|
|
|
it('Verify searching for a safe also finds safes in different networks', () => {
|
|
main.addToLocalStorage(constants.localStorageKeys.SAFE_v2__addedSafes, ls.addedSafes.sidebarTrustedSafe3TwoChains)
|
|
cy.visit(constants.homeUrl + staticSafes.SEP_STATIC_SAFE_9)
|
|
accountsModal.openAccountsModal()
|
|
accountsModal.searchSafe(sideBar.sideBarSafes.multichain_short_)
|
|
accountsModal.verifyAccountsListContains(sideBar.sideBarSafes.multichain_short_)
|
|
})
|
|
|
|
it('Verify clearing the search input returns back to the full list', () => {
|
|
main.addToLocalStorage(constants.localStorageKeys.SAFE_v2__addedSafes, ls.addedSafes.sidebarTrustedSafe1Safe2)
|
|
cy.visit(constants.homeUrl + staticSafes.SEP_STATIC_SAFE_9)
|
|
accountsModal.openAccountsModal()
|
|
accountsModal.searchSafe(sideBar.sideBarSafes.safe1short_)
|
|
accountsModal.verifyAccountsListDoesNotContain(sideBar.sideBarSafes.safe2short)
|
|
accountsModal.clearSearchInput()
|
|
accountsModal.verifyAccountsListContains(sideBar.sideBarSafes.safe1short)
|
|
accountsModal.verifyAccountsListContains(sideBar.sideBarSafes.safe2short)
|
|
})
|
|
})
|
|
|
|
describe('Safe selector tests - accounts modal actions', () => {
|
|
before(async () => {
|
|
staticSafes = await getSafes(CATEGORIES.static)
|
|
})
|
|
|
|
it('Verify Import button is present on the accounts page', () => {
|
|
wallet.connectSignerViaStorage(signer, constants.welcomeAccountsSepoliaUrl, { waitForConnection: false })
|
|
accountsModal.verifyImportBtnVisible()
|
|
})
|
|
|
|
it('Verify safes added to watchlist appear in the accounts modal', () => {
|
|
main.addToLocalStorage(constants.localStorageKeys.SAFE_v2__addedSafes, ls.addedSafes.set4)
|
|
wallet.connectSignerViaStorage(signer1, constants.BALANCE_URL + staticSafes.SEP_STATIC_SAFE_9)
|
|
accountsModal.openAccountsModal()
|
|
accountsModal.verifyAccountsListContains(sideBar.sideBarSafes.safe3short)
|
|
})
|
|
|
|
it('Verify missing signature info is shown for a safe in the accounts modal', () => {
|
|
main.addToLocalStorage(constants.localStorageKeys.SAFE_v2__addedSafes, ls.addedSafes.sidebarTrustedPendingSafe1)
|
|
wallet.connectSignerViaStorage(signer2, constants.BALANCE_URL + staticSafes.SEP_STATIC_SAFE_7)
|
|
accountsModal.openAccountsModal()
|
|
accountsModal.verifyMissingSignatureInfoExists()
|
|
})
|
|
|
|
it('Verify balance is displayed in the accounts modal safe item', () => {
|
|
main.addToLocalStorage(constants.localStorageKeys.SAFE_v2__addedSafes, ls.addedSafes.sidebarTrustedPendingSafe1)
|
|
wallet.connectSignerViaStorage(signer, constants.BALANCE_URL + staticSafes.SEP_STATIC_SAFE_7)
|
|
accountsModal.openAccountsModal()
|
|
accountsModal.verifyFiatBalanceExists()
|
|
})
|
|
})
|
|
|
|
describe('Safe selector tests - added safes', () => {
|
|
before(async () => {
|
|
staticSafes = await getSafes(CATEGORIES.static)
|
|
})
|
|
|
|
beforeEach(() => {
|
|
main.addToLocalStorage(constants.localStorageKeys.SAFE_v2__addedSafes, ls.addedSafes.set2)
|
|
main.addToLocalStorage(constants.localStorageKeys.SAFE_v2__addressBook, ls.addressBookData.addedSafes)
|
|
cy.visit(constants.homeUrl + staticSafes.SEP_STATIC_SAFE_9)
|
|
})
|
|
|
|
it('Verify added safes are listed in the safe selector dropdown', () => {
|
|
safeNav.openSelector()
|
|
safeNav.verifyAddedSafesInDropdown(sideBar.addedSafesSepolia)
|
|
})
|
|
|
|
it('Verify a safe can be renamed via the accounts modal', () => {
|
|
accountsModal.openAccountsModal()
|
|
accountsModal.renameSafe(addedSafe900, newSafeName)
|
|
accountsModal.verifyAccountsListContains(newSafeName)
|
|
})
|
|
})
|
|
|
|
describe('Safe selector tests - watchlist in dropdown', () => {
|
|
before(async () => {
|
|
staticSafes = await getSafes(CATEGORIES.static)
|
|
})
|
|
|
|
it('Verify that safes the user does not own appear in the safe selector dropdown after adding them', () => {
|
|
main.addToLocalStorage(constants.localStorageKeys.SAFE_v2__addedSafes, ls.addedSafes.set4)
|
|
wallet.connectSignerViaStorage(signer2, constants.BALANCE_URL + staticSafes.SEP_STATIC_SAFE_9)
|
|
|
|
safeNav.openSelector()
|
|
|
|
safeNav.verifyDropdownContainsSafe(sideBar.sideBarSafes.safe3short)
|
|
})
|
|
|
|
it('Verify that safes the user owns appear in the safe selector dropdown after adding them', () => {
|
|
main.addToLocalStorage(constants.localStorageKeys.SAFE_v2__addedSafes, ls.addedSafes.set4)
|
|
wallet.connectSignerViaStorage(signer1, constants.BALANCE_URL + staticSafes.SEP_STATIC_SAFE_9)
|
|
|
|
safeNav.openSelector()
|
|
|
|
safeNav.verifyDropdownContainsSafe(sideBar.sideBarSafes.safe3short)
|
|
})
|
|
|
|
it('Verify that a watched safe with a pending tx appears in the safe selector dropdown', () => {
|
|
main.addToLocalStorage(constants.localStorageKeys.SAFE_v2__addedSafes, ls.addedSafes.sidebarTrustedPendingSafe1)
|
|
wallet.connectSignerViaStorage(signer2, constants.BALANCE_URL + staticSafes.SEP_STATIC_SAFE_9)
|
|
|
|
safeNav.openSelector()
|
|
|
|
safeNav.verifyDropdownContainsSafe(sideBar.sideBarSafesPendingActions.safe1short)
|
|
})
|
|
|
|
it('Verify the first row in the safe selector dropdown shows a balance', () => {
|
|
main.addToLocalStorage(constants.localStorageKeys.SAFE_v2__addedSafes, ls.addedSafes.set4)
|
|
cy.visit(constants.BALANCE_URL + staticSafes.SEP_STATIC_SAFE_9)
|
|
|
|
safeNav.openSelector()
|
|
|
|
safeNav.verifyFirstDropdownRowHasBalance()
|
|
})
|
|
})
|
|
|
|
describe('Safe selector tests - new transaction button states', () => {
|
|
before(async () => {
|
|
staticSafes = await getSafes(CATEGORIES.static)
|
|
})
|
|
|
|
it('Verify the new transaction button is enabled for proposers', () => {
|
|
wallet.connectSignerViaStorage(signer1, constants.BALANCE_URL + staticSafes.SEP_STATIC_SAFE_31)
|
|
|
|
navigation.verifyTxBtnStatus(constants.enabledStates.enabled)
|
|
})
|
|
|
|
it('Verify the new transaction button is disabled for disconnected users', () => {
|
|
cy.visit(constants.BALANCE_URL + staticSafes.SEP_STATIC_SAFE_7)
|
|
|
|
navigation.verifyTxBtnStatus(constants.enabledStates.disabled)
|
|
})
|
|
|
|
it('Verify the new transaction button is disabled for connected non-owners', () => {
|
|
wallet.connectSignerViaStorage(signer1, constants.BALANCE_URL + staticSafes.SEP_STATIC_SAFE_7)
|
|
|
|
navigation.verifyTxBtnStatus(constants.enabledStates.disabled)
|
|
})
|
|
|
|
it('Verify the new transaction button is enabled for non-owners with spending limits', () => {
|
|
wallet.connectSignerViaStorage(signer, constants.BALANCE_URL + staticSafes.SEP_STATIC_SAFE_11)
|
|
|
|
navigation.verifyTxBtnStatus(constants.enabledStates.enabled)
|
|
})
|
|
})
|
|
|
|
describe('Safe selector tests - add safe button', () => {
|
|
before(async () => {
|
|
staticSafes = await getSafes(CATEGORIES.static)
|
|
})
|
|
|
|
it('Verify selecting an existing safe from Add accounts opens the load flow', () => {
|
|
wallet.connectSignerViaStorage(signer, constants.welcomeAccountsSepoliaUrl, { waitForConnection: false })
|
|
|
|
accountsModal.clickAddAccountsSelectExistingAndVerifyLoadFlow()
|
|
})
|
|
})
|
|
|
|
describe('Safe selector tests - threshold tag visible for owners and non-owners', () => {
|
|
before(async () => {
|
|
staticSafes = await getSafes(CATEGORIES.static)
|
|
})
|
|
|
|
it('Verify the threshold badge is shown on safe cards for both owner and non-owner safes', () => {
|
|
main.addToLocalStorage(constants.localStorageKeys.SAFE_v2__addedSafes, ls.addedSafes.set3)
|
|
main.addToLocalStorage(constants.localStorageKeys.SAFE_v2__addressBook, ls.addressBookData.addedSafes)
|
|
wallet.connectSignerViaStorage(signer, constants.homeUrl + staticSafes.SEP_STATIC_SAFE_11)
|
|
accountsModal.openAccountsModal()
|
|
|
|
accountsModal.verifyThresholdBadgeOnSafeCard('Added owner')
|
|
accountsModal.verifyThresholdBadgeOnSafeCard('Added non-owner')
|
|
})
|
|
})
|