mirror of
https://github.com/luxfi/safe-wallet.git
synced 2026-10-30 15:19:21 +00:00
05cab32f0e
* tests(web): connect wallet via seeded storage in e2e Replace the UI-driven connectSigner flow with storage-seeded auto-reconnect across the Cypress suite. Adds connectSignerViaStorage (seed on visit, or seed + reload) and migrates 139 entry connects; keeps UI connectSigner for the 27 connect/switch-flow sites that act on in-page state. * tests(web): seed batch via single page load in batch e2e Add optional extraStorage to connectSignerViaStorage so localStorage is seeded in onBeforeLoad on the initial visit. Split batch_tx into build-via-UI and pre-seeded describes, dropping addToLocalStorage + cy.reload() double-loads. * tests(web): seed state on a single page load across e2e specs Replace visit-then-write-then-reload double-loads with a single seeded load (extraStorage on connectSignerViaStorage, or onBeforeLoad on cy.visit), and drop the arbitrary post-reload settle waits. Covers the multichain, nested-safes, batch, address-book, safe-selector and create-safe specs (regression, smoke, visual). * tests(web): seed state on a single page load in more e2e specs Fold pre-seeded localStorage into the initial visit (extraStorage / onBeforeLoad) and drop the follow-up reloads across the address-book, messages-popup, CF-safe, import/export and load-safe specs. Split specs whose shared beforeEach served both seeding and non-seeding tests into nested describes so no test double-loads. * tests(web): remove redundant wallet reconnect reloads in e2e specs Pass the URL to connectSignerViaStorage so the wallet is seeded on the initial visit instead of visiting then reconnecting (which reloaded). Where a shared beforeEach served both connected and disconnected (or differently-seeded) tests, split into nested describes so no test double-loads. Covers proposers, swaps, twaps, assets, swaps_tokens, sidebar, spending_limits, bulk_execution, proposers_2, safe_selector. * tests(web): single-load owner-management e2e specs Split add/remove/replace-owner specs into connected / disconnected / non-owner / pre-seeded describes so the wallet is seeded on the initial visit (no reconnect reload) without forcing a connect onto tests that assert disconnected or non-owner state. * tests(web): wait for wallet connection after seeded connect The last wallet reconnects asynchronously after the page loads, so connectSignerViaStorage now waits for the connected-wallet header chip (open-account-center) before resolving, instead of letting tests proceed while still disconnected. Opt out via waitForConnection:false for pages without that chip (welcome/accounts in safe_selector). * tests(web): address review on seeded-connect PR - Drop the explicit 30s timeout on the connected-wallet wait; the repo default (10s) is plenty for the post-load reconnect and fails faster. - Make recovery.cy.js consistent: the remaining connectSigner calls now use connectSignerViaStorage like the rest of the file. All connects are at test start (none mid-flow), matching the already-converted tests. * fix: wait for the wallet connection to establish to avoid failing tests due to disconnected wallet --------- Co-authored-by: vmosharova <[email protected]>
199 lines
8.5 KiB
JavaScript
199 lines
8.5 KiB
JavaScript
import * as constants from '../../support/constants'
|
|
import * as main from '../pages/main.page'
|
|
import * as spendinglimit from '../pages/spending_limits.pages'
|
|
import * as navigation from '../pages/navigation.page'
|
|
import * as tx from '../pages/create_tx.pages'
|
|
import * as ls from '../../support/localstorage_data.js'
|
|
import { getSafes, CATEGORIES } from '../../support/safes/safesHandler.js'
|
|
import * as wallet from '../../support/utils/wallet.js'
|
|
import { getMockAddress } from '../../support/utils/ethers.js'
|
|
|
|
let staticSafes = []
|
|
const walletCredentials = JSON.parse(Cypress.env('CYPRESS_WALLET_CREDENTIALS'))
|
|
const signer = walletCredentials.OWNER_4_PRIVATE_KEY
|
|
const signerAddress = walletCredentials.OWNER_4_WALLET_ADDRESS
|
|
|
|
const tokenAmount = 0.1
|
|
const newTokenAmount = 0.001
|
|
const spendingLimitBalance = '(0.15 ETH)'
|
|
|
|
describe('Spending limits tests', () => {
|
|
before(async () => {
|
|
staticSafes = await getSafes(CATEGORIES.static)
|
|
})
|
|
|
|
describe('Connected on the default safe', () => {
|
|
beforeEach(() => {
|
|
wallet.connectSignerViaStorage(signer, constants.setupUrl + staticSafes.SEP_STATIC_SAFE_8)
|
|
cy.get(spendinglimit.spendingLimitsSection).should('be.visible')
|
|
})
|
|
|
|
it('Verify resetAllowance and setAllowance actions are shown if a part of allowance was used', () => {
|
|
spendinglimit.clickOnNewSpendingLimitBtn()
|
|
spendinglimit.enterBeneficiaryAddress(signerAddress)
|
|
spendinglimit.enterSpendingLimitAmount(0.1)
|
|
spendinglimit.clickOnNextBtn()
|
|
spendinglimit.verifyActionCount(2)
|
|
spendinglimit.verifyActionNames([
|
|
spendinglimit.actionNames.resetAllowance,
|
|
spendinglimit.actionNames.setAllowance,
|
|
])
|
|
})
|
|
|
|
// Added to prod
|
|
it('Verify that the Review step shows beneficiary, amount allowed, reset time', () => {
|
|
//Assume that default reset time is set to One time
|
|
spendinglimit.clickOnNewSpendingLimitBtn()
|
|
spendinglimit.enterBeneficiaryAddress(getMockAddress())
|
|
spendinglimit.enterSpendingLimitAmount(0.1)
|
|
spendinglimit.clickOnNextBtn()
|
|
spendinglimit.checkReviewData(
|
|
tokenAmount,
|
|
getMockAddress(),
|
|
spendinglimit.timePeriodOptions.oneTime.split(' ').join('-'),
|
|
)
|
|
})
|
|
|
|
// Added to prod
|
|
it('Verify Spending limit option is available when selecting the corresponding token', () => {
|
|
navigation.clickOnNewTxBtn()
|
|
tx.clickOnSendTokensBtn()
|
|
spendinglimit.verifyTxOptionExist([spendinglimit.spendingLimitTxOption])
|
|
})
|
|
|
|
it('Verify spending limit option shows available amount', () => {
|
|
navigation.clickOnNewTxBtn()
|
|
tx.clickOnSendTokensBtn()
|
|
spendinglimit.verifySpendingOptionShowsBalance([spendingLimitBalance])
|
|
})
|
|
|
|
it('Verify when owner is a delegate, standard tx and spending limit tx are present', () => {
|
|
navigation.clickOnNewTxBtn()
|
|
tx.clickOnSendTokensBtn()
|
|
spendinglimit.verifyTxOptionExist([spendinglimit.spendingLimitTxOption, spendinglimit.standardTx])
|
|
})
|
|
|
|
it('Verify when spending limit is selected the nonce field is removed', () => {
|
|
navigation.clickOnNewTxBtn()
|
|
tx.clickOnSendTokensBtn()
|
|
spendinglimit.selectSpendingLimitOption()
|
|
spendinglimit.verifyNonceState(constants.elementExistanceStates.not_exist)
|
|
})
|
|
|
|
it('Verify "Max" button value set to be no more than the allowed amount', () => {
|
|
navigation.clickOnNewTxBtn()
|
|
tx.clickOnSendTokensBtn()
|
|
spendinglimit.clickOnMaxBtn()
|
|
spendinglimit.checkMaxValue()
|
|
})
|
|
|
|
it('Verify selecting a native token from the dropdown in new tx', () => {
|
|
navigation.clickOnNewTxBtn()
|
|
tx.clickOnSendTokensBtn()
|
|
spendinglimit.selectToken(constants.tokenNames.sepoliaEther)
|
|
})
|
|
|
|
it('Verify that when replacing spending limit for the same owner, previous values are displayed in red', () => {
|
|
spendinglimit.clickOnNewSpendingLimitBtn()
|
|
spendinglimit.enterBeneficiaryAddress(constants.DEFAULT_OWNER_ADDRESS)
|
|
spendinglimit.enterSpendingLimitAmount(newTokenAmount)
|
|
spendinglimit.clickOnTimePeriodDropdown()
|
|
spendinglimit.selectTimePeriod(spendinglimit.timePeriodOptions.fiveMin)
|
|
tx.clickOnNextBtn()
|
|
spendinglimit.verifyOldValuesAreDisplayed()
|
|
})
|
|
|
|
it('Verify that when editing spending limit for owner who used some of it, relevant actions are displayed', () => {
|
|
spendinglimit.clickOnNewSpendingLimitBtn()
|
|
spendinglimit.enterBeneficiaryAddress(constants.SPENDING_LIMIT_ADDRESS_2)
|
|
spendinglimit.enterSpendingLimitAmount(newTokenAmount)
|
|
spendinglimit.clickOnTimePeriodDropdown()
|
|
spendinglimit.selectTimePeriod(spendinglimit.timePeriodOptions.oneTime)
|
|
tx.clickOnNextBtn()
|
|
spendinglimit.verifyActionNamesAreDisplayed([
|
|
constants.TXActionNames.resetAllowance,
|
|
constants.TXActionNames.setAllowance,
|
|
])
|
|
})
|
|
})
|
|
|
|
describe('Disconnected on the default safe', () => {
|
|
beforeEach(() => {
|
|
cy.visit(constants.setupUrl + staticSafes.SEP_STATIC_SAFE_8)
|
|
cy.get(spendinglimit.spendingLimitsSection).should('be.visible')
|
|
})
|
|
|
|
// Added to prod
|
|
it('Verify values and trash icons are displayed in Beneficiary table', () => {
|
|
spendinglimit.verifyBeneficiaryTable()
|
|
})
|
|
|
|
it('Verify explorer links contain Sepolia link', () => {
|
|
tx.verifyNumberOfExternalLinks(3)
|
|
})
|
|
})
|
|
|
|
describe('Other safes and pre-seeded data', () => {
|
|
it('Verify only setAllowance action is shown if allowance was not used', () => {
|
|
wallet.connectSignerViaStorage(signer, constants.setupUrl + staticSafes.SEP_STATIC_SAFE_23)
|
|
cy.get(spendinglimit.spendingLimitsSection).should('be.visible')
|
|
spendinglimit.clickOnNewSpendingLimitBtn()
|
|
spendinglimit.enterBeneficiaryAddress(signerAddress)
|
|
spendinglimit.enterSpendingLimitAmount(0.1)
|
|
spendinglimit.clickOnNextBtn()
|
|
spendinglimit.verifyActionCount(0)
|
|
spendinglimit.verifyDecodedTxSummary([spendinglimit.actionNames.setAllowance])
|
|
})
|
|
|
|
it('Verify that when multiple assets are available, they are displayed in token dropdown', () => {
|
|
wallet.connectSignerViaStorage(signer, constants.setupUrl + staticSafes.SEP_STATIC_SAFE_8, {
|
|
extraStorage: { [constants.localStorageKeys.SAFE_v2__settings]: ls.safeSettings.slimitSettings },
|
|
})
|
|
cy.get(spendinglimit.spendingLimitsSection).should('be.visible')
|
|
navigation.clickOnNewTxBtn()
|
|
tx.clickOnSendTokensBtn()
|
|
spendinglimit.clickOnTokenDropdown()
|
|
spendinglimit.verifyMandatoryTokensExist()
|
|
})
|
|
|
|
it('Verify that beneficiary can be retried from address book', () => {
|
|
wallet.connectSignerViaStorage(signer, constants.setupUrl + staticSafes.SEP_STATIC_SAFE_8, {
|
|
extraStorage: { [constants.localStorageKeys.SAFE_v2__addressBook]: ls.addressBookData.sepoliaAddress2 },
|
|
})
|
|
cy.get(spendinglimit.spendingLimitsSection).should('be.visible')
|
|
spendinglimit.clickOnNewSpendingLimitBtn()
|
|
spendinglimit.enterBeneficiaryAddress(constants.DEFAULT_OWNER_ADDRESS.substring(30))
|
|
spendinglimit.selectRecipient(constants.DEFAULT_OWNER_ADDRESS)
|
|
})
|
|
|
|
it('Verify that the enableModule action shows the correct AllowanceModule address for Sepolia', () => {
|
|
spendinglimit.visitSpendingLimitsPage(staticSafes.SEP_STATIC_SAFE_47)
|
|
wallet.connectSignerViaStorage(signer)
|
|
spendinglimit.clickOnNewSpendingLimitBtn()
|
|
spendinglimit.enterBeneficiaryAddress(signerAddress)
|
|
spendinglimit.enterSpendingLimitAmount(1)
|
|
spendinglimit.clickOnNextBtn()
|
|
|
|
spendinglimit.verifyActionNames([spendinglimit.actionNames.enableModule])
|
|
spendinglimit.verifyEnableModuleAddress(constants.ALLOWANCE_MODULE_V0_1_0)
|
|
})
|
|
|
|
it('Verify that the enableModule action shows the correct AllowanceModule address for Polygon', () => {
|
|
// setupSafeSettingsWithAllTokens is required: the Polygon safe has near-zero MATIC balance
|
|
// which triggers the "hide small tokens" filter, leaving the token selector empty
|
|
spendinglimit.visitSpendingLimitsPage(staticSafes.MATIC_STATIC_SAFE_34)
|
|
main.setupSafeSettingsWithAllTokens().then(() => {
|
|
spendinglimit.visitSpendingLimitsPage(staticSafes.MATIC_STATIC_SAFE_34)
|
|
wallet.connectSignerViaStorage(signer)
|
|
spendinglimit.clickOnNewSpendingLimitBtn()
|
|
spendinglimit.enterBeneficiaryAddress(signerAddress)
|
|
spendinglimit.enterSpendingLimitAmount(1)
|
|
spendinglimit.clickOnNextBtn()
|
|
|
|
spendinglimit.verifyActionNames([spendinglimit.actionNames.enableModule])
|
|
spendinglimit.verifyEnableModuleAddress(constants.ALLOWANCE_MODULE_V0_1_1)
|
|
})
|
|
})
|
|
})
|
|
})
|