mirror of
https://github.com/luxfi/safe-wallet.git
synced 2026-10-30 15:19:21 +00:00
05cab32f0e
* tests(web): connect wallet via seeded storage in e2e Replace the UI-driven connectSigner flow with storage-seeded auto-reconnect across the Cypress suite. Adds connectSignerViaStorage (seed on visit, or seed + reload) and migrates 139 entry connects; keeps UI connectSigner for the 27 connect/switch-flow sites that act on in-page state. * tests(web): seed batch via single page load in batch e2e Add optional extraStorage to connectSignerViaStorage so localStorage is seeded in onBeforeLoad on the initial visit. Split batch_tx into build-via-UI and pre-seeded describes, dropping addToLocalStorage + cy.reload() double-loads. * tests(web): seed state on a single page load across e2e specs Replace visit-then-write-then-reload double-loads with a single seeded load (extraStorage on connectSignerViaStorage, or onBeforeLoad on cy.visit), and drop the arbitrary post-reload settle waits. Covers the multichain, nested-safes, batch, address-book, safe-selector and create-safe specs (regression, smoke, visual). * tests(web): seed state on a single page load in more e2e specs Fold pre-seeded localStorage into the initial visit (extraStorage / onBeforeLoad) and drop the follow-up reloads across the address-book, messages-popup, CF-safe, import/export and load-safe specs. Split specs whose shared beforeEach served both seeding and non-seeding tests into nested describes so no test double-loads. * tests(web): remove redundant wallet reconnect reloads in e2e specs Pass the URL to connectSignerViaStorage so the wallet is seeded on the initial visit instead of visiting then reconnecting (which reloaded). Where a shared beforeEach served both connected and disconnected (or differently-seeded) tests, split into nested describes so no test double-loads. Covers proposers, swaps, twaps, assets, swaps_tokens, sidebar, spending_limits, bulk_execution, proposers_2, safe_selector. * tests(web): single-load owner-management e2e specs Split add/remove/replace-owner specs into connected / disconnected / non-owner / pre-seeded describes so the wallet is seeded on the initial visit (no reconnect reload) without forcing a connect onto tests that assert disconnected or non-owner state. * tests(web): wait for wallet connection after seeded connect The last wallet reconnects asynchronously after the page loads, so connectSignerViaStorage now waits for the connected-wallet header chip (open-account-center) before resolving, instead of letting tests proceed while still disconnected. Opt out via waitForConnection:false for pages without that chip (welcome/accounts in safe_selector). * tests(web): address review on seeded-connect PR - Drop the explicit 30s timeout on the connected-wallet wait; the repo default (10s) is plenty for the post-load reconnect and fails faster. - Make recovery.cy.js consistent: the remaining connectSigner calls now use connectSignerViaStorage like the rest of the file. All connects are at test start (none mid-flow), matching the already-converted tests. * fix: wait for the wallet connection to establish to avoid failing tests due to disconnected wallet --------- Co-authored-by: vmosharova <[email protected]>
103 lines
4.4 KiB
JavaScript
103 lines
4.4 KiB
JavaScript
import * as constants from '../../support/constants.js'
|
|
import * as main from '../pages/main.page.js'
|
|
import * as swaps from '../pages/swaps.pages.js'
|
|
import * as create_tx from '../pages/create_tx.pages.js'
|
|
import { getSafes, CATEGORIES } from '../../support/safes/safesHandler.js'
|
|
import * as data from '../../fixtures/txhistory_data_data.json'
|
|
import * as wallet from '../../support/utils/wallet.js'
|
|
import * as navigation from '../pages/navigation.page'
|
|
import { disconnectedUserErrorMsg } from '../pages/owners.pages'
|
|
import { comboButtonOptions } from '../pages/create_tx.pages'
|
|
|
|
let staticSafes = []
|
|
|
|
const walletCredentials = JSON.parse(Cypress.env('CYPRESS_WALLET_CREDENTIALS'))
|
|
const signer = walletCredentials.OWNER_3_PRIVATE_KEY
|
|
const signer2 = walletCredentials.OWNER_4_PRIVATE_KEY
|
|
|
|
const typeOnchainRejection = data.type.onchainRejection
|
|
|
|
const onchainRejectionTx =
|
|
'&id=multisig_0x5912f6616c84024cD1aff0D5b55bb36F5180fFdb_0x13037f442aa430867c6f50799382fe42ae788896e2d032a6849bf07bc87d0fe2'
|
|
|
|
const onchainRejectionTx2 =
|
|
'&id=multisig_0x4B8A8Ca9F0002a850CB2c81b205a6D7429a22DEe_0x66460c1f56c55fc2101565cb968a0cf393be0fe84528d7507a81be7125160034'
|
|
|
|
describe('Transaction queue Reject button tests', { defaultCommandTimeout: 30000 }, () => {
|
|
before(async () => {
|
|
staticSafes = await getSafes(CATEGORIES.static)
|
|
})
|
|
|
|
it('Verify a tx in queue shows the Reject button', () => {
|
|
cy.visit(constants.transactionUrl + staticSafes.SEP_STATIC_SAFE_34 + swaps.swapTxs.sellQLimitOrder)
|
|
create_tx.getRejectButton().should('be.visible')
|
|
})
|
|
|
|
it('Verify that Reject button is disabled out for non-owners and disconnected users', () => {
|
|
cy.visit(constants.transactionUrl + staticSafes.SEP_STATIC_SAFE_34 + swaps.swapTxs.sellQLimitOrder)
|
|
create_tx.verifyRejectBtnDisabled()
|
|
wallet.connectSignerViaStorage(signer)
|
|
create_tx.verifyRejectBtnDisabled()
|
|
navigation.clickOnWalletExpandMoreIcon()
|
|
navigation.clickOnDisconnectBtn()
|
|
})
|
|
|
|
it('Verify that clicking a disabled Reject button when not connected opens the Onboard modal', () => {
|
|
cy.visit(constants.transactionUrl + staticSafes.SEP_STATIC_SAFE_34 + swaps.swapTxs.sellQLimitOrder)
|
|
create_tx.hoverOverRejectBtnBtn()
|
|
main.verifyTextVisibility([disconnectedUserErrorMsg])
|
|
})
|
|
|
|
it('Verify that clicking rejection with an owner opens a modal with the Reject option', () => {
|
|
wallet.connectSignerViaStorage(
|
|
signer2,
|
|
constants.transactionUrl + staticSafes.SEP_STATIC_SAFE_34 + swaps.swapTxs.sellQLimitOrder,
|
|
)
|
|
create_tx.clickOnRejectBtn()
|
|
create_tx.verifyTxRejectModalVisible()
|
|
navigation.clickOnWalletExpandMoreIcon()
|
|
navigation.clickOnDisconnectBtn()
|
|
})
|
|
|
|
it('Verify that using the Reject option opens a tx modal showing the nonce that will be rejected', () => {
|
|
cy.visit(constants.transactionUrl + staticSafes.SEP_STATIC_SAFE_34 + swaps.swapTxs.sellQLimitOrder)
|
|
wallet.connectSigner(signer2)
|
|
create_tx.clickOnRejectBtn()
|
|
create_tx.verifyTxRejectModalVisible()
|
|
create_tx.clickOnRejectionChoiceBtn(1)
|
|
create_tx.verifyTxNonceDisplayed(0)
|
|
create_tx.checkNonceIsReadOnly()
|
|
navigation.clickOnWalletExpandMoreIcon()
|
|
navigation.clickOnDisconnectBtn()
|
|
})
|
|
|
|
it('Verify a Reject tx name is "On-Chain rejection" in history', () => {
|
|
cy.visit(constants.transactionUrl + staticSafes.SEP_STATIC_SAFE_7 + onchainRejectionTx)
|
|
create_tx.verifyTxHeaderDetails([typeOnchainRejection.title])
|
|
})
|
|
|
|
it('Verify a Reject tx cannot be "Added as batch"', () => {
|
|
wallet.connectSignerViaStorage(
|
|
signer2,
|
|
constants.transactionUrl + staticSafes.SEP_STATIC_SAFE_34 + swaps.swapTxs.sellQLimitOrder,
|
|
)
|
|
create_tx.clickOnRejectBtn()
|
|
create_tx.verifyTxRejectModalVisible()
|
|
create_tx.clickOnRejectionChoiceBtn(1)
|
|
create_tx.clickOnContinueSignTransactionBtn()
|
|
create_tx.checkThatComboButtonOptionIsNotPresent(create_tx.comboButtonOptions.addToBatch)
|
|
navigation.clickOnWalletExpandMoreIcon()
|
|
navigation.clickOnDisconnectBtn()
|
|
})
|
|
|
|
it('Verify 2 Reject tx cannot be created with the same nonce', () => {
|
|
cy.visit(constants.transactionUrl + staticSafes.SEP_STATIC_SAFE_37 + onchainRejectionTx2)
|
|
wallet.connectSigner(signer2)
|
|
create_tx.clickOnRejectBtn()
|
|
create_tx.verifyTxRejectModalVisible()
|
|
create_tx.verifyRejecChoiceBtnStatus(constants.enabledStates.disabled)
|
|
navigation.clickOnWalletExpandMoreIcon()
|
|
navigation.clickOnDisconnectBtn()
|
|
})
|
|
})
|