Files
threshold/protocols/frost/sign/round1.go
zeekay b41c78f5b3 round: rename Helper to Base — name the value, not the laziness
round.Helper was the canonical anti-pattern: a bare-noun
qualifier-name that told you nothing about what the type does. The
type is the embeddable Session implementation that protocol round
structs anchor on — its VALUE is "the base every round builds on".
Rename it to that.

  type Helper struct { ... }   → type Base struct { ... }
  func (h *Helper) ...         → func (h *Base) ...
  func NewSession(...) (*Helper, error) → (*Base, error)
  Output { *Helper }           → Output { *Base }
  Abort  { *Helper }           → Abort  { *Base }
  round.Helper                 → round.Base   (18 files)
  Helper: helper               → Base: helper (struct literal init)
  r.Helper.X / r.Helper        → r.Base.X / r.Base (field access)

internal/round/helper.go    → base.go
internal/round/helper_test.go → base_test.go

Forward-only — no type alias, no deprecation. The Go FAQ pointer-
receiver consistency landed in the prior commit (bf88f5a) so the
method set is already aligned; this commit only renames the type.

Build + vet clean; round / CMP keygen smoke / FROST keygen all
PASS unchanged.
2026-06-01 00:26:33 -07:00

135 lines
4.4 KiB
Go

package sign
import (
"crypto/rand"
"sync"
"github.com/luxfi/threshold/internal/round"
"github.com/luxfi/threshold/pkg/math/curve"
"github.com/luxfi/threshold/pkg/math/sample"
"github.com/luxfi/threshold/pkg/party"
"github.com/zeebo/blake3"
)
// This round sort of corresponds with Figure 2 of the Frost paper:
//
// https://eprint.iacr.org/2020/852.pdf
//
// The main difference is that instead of having a separate pre-processing step,
// we instead have an additional round at the start of the signing step.
// The goal of this round is to generate two nonces, and corresponding commitments.
//
// There are also differences corresponding to the lack of a signing authority,
// namely that these commitments are broadcast, instead of stored with the authority.
type round1 struct {
*round.Base
// taproot indicates whether or not we need to generate Taproot / BIP-340 signatures.
//
// If so, we have a few slight tweaks to make around the evenness of points,
// and we need to make sure to generate our challenge in the correct way. Naturally,
// we also return a taproot.Signature instead a generic signature.
taproot bool
// sr25519 indicates whether we produce sr25519 (Schnorrkel) compatible signatures.
//
// If so, the challenge is computed via Merlin transcripts matching the Substrate/Polkadot
// sr25519 scheme. The result is an sr25519 Signature (R || s, 64 bytes).
sr25519 bool
// signingContext is the application-level context for sr25519 signing.
// For Substrate, this is always "substrate".
signingContext []byte
// M is the hash of the message we're signing.
//
// This plays the same role as m in the Frost paper. One slight difference
// is that instead of including the message directly in various hashes,
// we include the *hash* of that message instead. This provides the same
// security.
M messageHash
// Y is the public key we're signing for.
Y curve.Point
// YShares are verification shares for each participant's fraction of the secret key
//
// YShares[i] corresponds with Yᵢ in the Frost paper.
YShares map[party.ID]curve.Point
// sI = sᵢ is our private secret share
sI curve.Scalar
}
// VerifyMessage implements round.Round.
func (r *round1) VerifyMessage(round.Message) error { return nil }
func (r *round1) StoreMessage(round.Message) error { return nil }
const deriveHashKeyContext = "github.com/luxfi/threshold/frost 2021-07-30T09:48+00:00 Derive hash Key"
// Finalize implements round.Round.
func (r *round1) Finalize(out chan<- *round.Message) (round.Session, error) {
// We can think of this as roughly implementing Figure 2. The idea is
// to generate two nonces (dᵢ, eᵢ) in Z/(q)ˣ, then two commitments
// Dᵢ = dᵢ * G, Eᵢ = eᵢ * G, and then broadcast them.
// We use a hedged deterministic process, instead of simply sampling (dI, eI):
//
// a = random()
// hk = KDF(sI)
// (dI, eI) = H_hk(ctx, m, a)
//
// This protects against bad randomness, since a constant value for a is still unpredictable,
// and fault attacks against the hash function, because of the randomness.
sIBytes, err := r.sI.MarshalBinary()
if err != nil {
return r, err
}
hashKey := make([]byte, 32)
blake3.DeriveKey(deriveHashKeyContext, sIBytes, hashKey)
nonceHasher, _ := blake3.NewKeyed(hashKey)
_, _ = nonceHasher.Write(r.Hash().Sum())
_, _ = nonceHasher.Write(r.M)
a := make([]byte, 32)
_, _ = rand.Read(a)
_, _ = nonceHasher.Write(a)
nonceDigest := nonceHasher.Digest()
dI := sample.ScalarUnit(nonceDigest, r.Group())
eI := sample.ScalarUnit(nonceDigest, r.Group())
DI := dI.ActOnBase()
EI := eI.ActOnBase()
// Broadcast the commitments
err = r.BroadcastMessage(out, &broadcast2{D_i: DI, E_i: EI})
if err != nil {
return r, err
}
// Initialize maps with expected capacity
D := make(map[party.ID]curve.Point, len(r.PartyIDs()))
E := make(map[party.ID]curve.Point, len(r.PartyIDs()))
// Store our own values using marshal/unmarshal to ensure clean copy
dBytes, _ := DI.MarshalBinary()
eBytes, _ := EI.MarshalBinary()
DCopy := r.Group().NewPoint()
_ = DCopy.UnmarshalBinary(dBytes)
ECopy := r.Group().NewPoint()
_ = ECopy.UnmarshalBinary(eBytes)
D[r.SelfID()] = DCopy
E[r.SelfID()] = ECopy
return &round2{
round1: r,
d_i: dI,
e_i: eI,
D: D,
E: E,
deMu: &sync.Mutex{},
}, nil
}
// MessageContent implements round.Round.
func (*round1) MessageContent() round.Content { return nil }
// Number implements round.Round.
func (*round1) Number() round.Number { return 1 }