mirror of
https://github.com/luxfi/threshold.git
synced 2026-10-30 15:15:53 +00:00
zeekay
f7b136528d
VerifyMessage/StoreMessage/MessageContent/Number/BroadcastContent on round structs were value receivers. Go FAQ: "if any method on T takes *T, all methods should take *T." Finalize already takes *T (it mutates round state) so the others should too. Aligns the method set, removes silent struct-copies on every dispatch, and prevents future drift where a value-receiver method accidentally observes pre-Finalize state. No behavior change — all current methods are no-ops or return constants. Touched: round.Abort, round.Output, all CMP keygen/presign/sign rounds, all Doerner keygen/sign rounds, all FROST keygen/sign rounds, xor example. Build + vet clean; CMP/FROST/Doerner -race tests PASS.
130 lines
3.2 KiB
Go
130 lines
3.2 KiB
Go
package presign
|
|
|
|
import (
|
|
"github.com/cronokirby/saferith"
|
|
"github.com/luxfi/threshold/internal/elgamal"
|
|
"github.com/luxfi/threshold/internal/round"
|
|
"github.com/luxfi/threshold/pkg/math/curve"
|
|
"github.com/luxfi/threshold/pkg/party"
|
|
zklogstar "github.com/luxfi/threshold/pkg/zk/logstar"
|
|
)
|
|
|
|
var _ round.Round = (*presign4)(nil)
|
|
|
|
type presign4 struct {
|
|
*presign3
|
|
|
|
// DeltaShareAlpha[j] = αᵢⱼ
|
|
DeltaShareAlpha map[party.ID]*saferith.Int
|
|
// ChiShareAlpha[j] = α̂ᵢⱼ
|
|
ChiShareAlpha map[party.ID]*saferith.Int
|
|
|
|
// ElGamalChiNonce = b̂ᵢ
|
|
ElGamalChiNonce elgamal.Nonce
|
|
// ElGamalChi[j] = Ẑⱼ = (b̂ⱼ, χⱼ⋅G+b̂ⱼ⋅Yⱼ)
|
|
ElGamalChi map[party.ID]*elgamal.Ciphertext
|
|
|
|
// DeltaShares[j] = δⱼ
|
|
DeltaShares map[party.ID]curve.Scalar
|
|
|
|
// ChiShare = χᵢ
|
|
ChiShare curve.Scalar
|
|
}
|
|
|
|
type broadcast4 struct {
|
|
round.NormalBroadcastContent
|
|
// DeltaShare = δⱼ
|
|
DeltaShare curve.Scalar
|
|
// ElGamalChi = Ẑᵢ = (b̂ᵢ, χᵢ⋅G+b̂ᵢ⋅Yᵢ)
|
|
ElGamalChi *elgamal.Ciphertext
|
|
}
|
|
|
|
// StoreBroadcastMessage implements round.BroadcastRound.
|
|
//
|
|
// - store Ẑⱼ, δⱼ.
|
|
func (r *presign4) StoreBroadcastMessage(msg round.Message) error {
|
|
body, ok := msg.Content.(*broadcast4)
|
|
if !ok || body == nil {
|
|
return round.ErrInvalidContent
|
|
}
|
|
|
|
if body.DeltaShare.IsZero() || !body.ElGamalChi.Valid() {
|
|
return round.ErrNilFields
|
|
}
|
|
r.ElGamalChi[msg.From] = body.ElGamalChi
|
|
r.DeltaShares[msg.From] = body.DeltaShare
|
|
return nil
|
|
}
|
|
|
|
// VerifyMessage implements round.Round.
|
|
func (*presign4) VerifyMessage(round.Message) error { return nil }
|
|
|
|
// StoreMessage implements round.Round.
|
|
func (*presign4) StoreMessage(round.Message) error { return nil }
|
|
|
|
// Finalize implements round.Round
|
|
//
|
|
// - set Γᵢ = γᵢ⋅G.
|
|
// - prove zklogstar.
|
|
func (r *presign4) Finalize(out chan<- *round.Message) (round.Session, error) {
|
|
// Γᵢ = γᵢ⋅G
|
|
BigGammaShare := r.Group().NewScalar().SetNat(r.GammaShare.Mod(r.Group().Order())).ActOnBase()
|
|
|
|
zkPrivate := zklogstar.Private{
|
|
X: r.GammaShare,
|
|
Rho: r.GNonce,
|
|
}
|
|
|
|
if err := r.BroadcastMessage(out, &broadcast5{BigGammaShare: BigGammaShare}); err != nil {
|
|
return r, err
|
|
}
|
|
|
|
otherIDs := r.OtherPartyIDs()
|
|
errors := r.Pool.Parallelize(len(otherIDs), func(i int) interface{} {
|
|
j := otherIDs[i]
|
|
|
|
proofLog := zklogstar.NewProof(r.Group(), r.HashForID(r.SelfID()), zklogstar.Public{
|
|
C: r.G[r.SelfID()],
|
|
X: BigGammaShare,
|
|
Prover: r.Paillier[r.SelfID()],
|
|
Aux: r.Pedersen[j],
|
|
}, zkPrivate)
|
|
|
|
err := r.SendMessage(out, &message5{
|
|
ProofLog: proofLog,
|
|
}, j)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
return nil
|
|
})
|
|
for _, err := range errors {
|
|
if err != nil {
|
|
return r, err.(error)
|
|
}
|
|
}
|
|
|
|
return &presign5{
|
|
presign4: r,
|
|
BigGammaShare: map[party.ID]curve.Point{r.SelfID(): BigGammaShare},
|
|
}, nil
|
|
}
|
|
|
|
// MessageContent implements round.Round.
|
|
func (r *presign4) MessageContent() round.Content { return nil }
|
|
|
|
// RoundNumber implements round.Content.
|
|
func (broadcast4) RoundNumber() round.Number { return 4 }
|
|
|
|
// BroadcastContent implements round.BroadcastRound.
|
|
func (r *presign4) BroadcastContent() round.BroadcastContent {
|
|
return &broadcast4{
|
|
DeltaShare: r.Group().NewScalar(),
|
|
ElGamalChi: elgamal.Empty(r.Group()),
|
|
}
|
|
}
|
|
|
|
// Number implements round.Round.
|
|
func (*presign4) Number() round.Number { return 4 }
|