mirror of
https://github.com/luxfi/threshold.git
synced 2026-10-30 15:15:53 +00:00
zeekay
f7b136528d
VerifyMessage/StoreMessage/MessageContent/Number/BroadcastContent on round structs were value receivers. Go FAQ: "if any method on T takes *T, all methods should take *T." Finalize already takes *T (it mutates round state) so the others should too. Aligns the method set, removes silent struct-copies on every dispatch, and prevents future drift where a value-receiver method accidentally observes pre-Finalize state. No behavior change — all current methods are no-ops or return constants. Touched: round.Abort, round.Output, all CMP keygen/presign/sign rounds, all Doerner keygen/sign rounds, all FROST keygen/sign rounds, xor example. Build + vet clean; CMP/FROST/Doerner -race tests PASS.
78 lines
1.8 KiB
Go
78 lines
1.8 KiB
Go
package presign
|
|
|
|
import (
|
|
"errors"
|
|
|
|
"github.com/luxfi/threshold/internal/round"
|
|
"github.com/luxfi/threshold/pkg/math/curve"
|
|
"github.com/luxfi/threshold/pkg/party"
|
|
)
|
|
|
|
var _ round.Round = (*sign2)(nil)
|
|
|
|
type sign2 struct {
|
|
*sign1
|
|
// SigmaShares[j] = σⱼ
|
|
SigmaShares map[party.ID]curve.Scalar
|
|
}
|
|
|
|
type broadcastSign2 struct {
|
|
round.NormalBroadcastContent
|
|
// Sigma = σᵢ
|
|
Sigma curve.Scalar
|
|
}
|
|
|
|
// StoreBroadcastMessage implements round.BroadcastRound.
|
|
//
|
|
// - save σⱼ.
|
|
func (r *sign2) StoreBroadcastMessage(msg round.Message) error {
|
|
body, ok := msg.Content.(*broadcastSign2)
|
|
if !ok || body == nil {
|
|
return round.ErrInvalidContent
|
|
}
|
|
|
|
if body.Sigma.IsZero() {
|
|
return round.ErrNilFields
|
|
}
|
|
|
|
r.SigmaShares[msg.From] = body.Sigma
|
|
return nil
|
|
}
|
|
|
|
// VerifyMessage implements round.Round.
|
|
func (*sign2) VerifyMessage(round.Message) error { return nil }
|
|
|
|
// StoreMessage implements round.Round.
|
|
func (*sign2) StoreMessage(round.Message) error { return nil }
|
|
|
|
// Finalize implements round.Round
|
|
//
|
|
// - verify (r,s)
|
|
// - if not, find culprit.
|
|
func (r *sign2) Finalize(chan<- *round.Message) (round.Session, error) {
|
|
s := r.PreSignature.Signature(r.SigmaShares)
|
|
|
|
if s.Verify(r.PublicKey, r.Message) {
|
|
return r.ResultRound(s), nil
|
|
}
|
|
|
|
culprits := r.PreSignature.VerifySignatureShares(r.SigmaShares, r.Message)
|
|
return r.AbortRound(errors.New("signature failed to verify"), culprits...), nil
|
|
}
|
|
|
|
// MessageContent implements round.Round.
|
|
func (*sign2) MessageContent() round.Content { return nil }
|
|
|
|
// RoundNumber implements round.Content.
|
|
func (broadcastSign2) RoundNumber() round.Number { return 8 }
|
|
|
|
// BroadcastContent implements round.BroadcastRound.
|
|
func (r *sign2) BroadcastContent() round.BroadcastContent {
|
|
return &broadcastSign2{
|
|
Sigma: r.Group().NewScalar(),
|
|
}
|
|
}
|
|
|
|
// Number implements round.Round.
|
|
func (*sign2) Number() round.Number { return 8 }
|