mirror of
https://github.com/luxfi/threshold.git
synced 2026-10-30 15:15:53 +00:00
zeekay
bf88f5a56d
VerifyMessage/StoreMessage/MessageContent/Number/BroadcastContent on round structs were value receivers. Go FAQ: "if any method on T takes *T, all methods should take *T." Finalize already takes *T (it mutates round state) so the others should too. Aligns the method set, removes silent struct-copies on every dispatch, and prevents future drift where a value-receiver method accidentally observes pre-Finalize state. No behavior change — all current methods are no-ops or return constants. Touched: round.Abort, round.Output, all CMP keygen/presign/sign rounds, all Doerner keygen/sign rounds, all FROST keygen/sign rounds, xor example. Build + vet clean; CMP/FROST/Doerner -race tests PASS.
132 lines
3.1 KiB
Go
132 lines
3.1 KiB
Go
package presign
|
|
|
|
import (
|
|
"errors"
|
|
|
|
"github.com/luxfi/threshold/internal/round"
|
|
"github.com/luxfi/threshold/pkg/math/curve"
|
|
"github.com/luxfi/threshold/pkg/party"
|
|
zkelog "github.com/luxfi/threshold/pkg/zk/elog"
|
|
zklogstar "github.com/luxfi/threshold/pkg/zk/logstar"
|
|
)
|
|
|
|
var _ round.Round = (*presign5)(nil)
|
|
|
|
type presign5 struct {
|
|
*presign4
|
|
|
|
// BigGammaShare[j] = Γⱼ = [γⱼ]•G
|
|
BigGammaShare map[party.ID]curve.Point
|
|
}
|
|
|
|
type message5 struct {
|
|
ProofLog *zklogstar.Proof
|
|
}
|
|
|
|
type broadcast5 struct {
|
|
round.NormalBroadcastContent
|
|
// BigGammaShare = Γᵢ
|
|
BigGammaShare curve.Point
|
|
}
|
|
|
|
// StoreBroadcastMessage implements round.BroadcastRound.
|
|
//
|
|
// - save Γⱼ
|
|
func (r *presign5) StoreBroadcastMessage(msg round.Message) error {
|
|
body, ok := msg.Content.(*broadcast5)
|
|
if !ok || body == nil {
|
|
return round.ErrInvalidContent
|
|
}
|
|
|
|
if body.BigGammaShare.IsIdentity() {
|
|
return round.ErrNilFields
|
|
}
|
|
r.BigGammaShare[msg.From] = body.BigGammaShare
|
|
return nil
|
|
}
|
|
|
|
// VerifyMessage implements round.Round.
|
|
func (r *presign5) VerifyMessage(msg round.Message) error {
|
|
from, to := msg.From, msg.To
|
|
body, ok := msg.Content.(*message5)
|
|
if !ok || body == nil {
|
|
return round.ErrInvalidContent
|
|
}
|
|
if !body.ProofLog.Verify(r.HashForID(msg.From), zklogstar.Public{
|
|
C: r.G[from],
|
|
X: r.BigGammaShare[from],
|
|
Prover: r.Paillier[from],
|
|
Aux: r.Pedersen[to],
|
|
}) {
|
|
return errors.New("failed to validate log* proof for BigGammaShare")
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// StoreMessage implements round.Round.
|
|
func (*presign5) StoreMessage(round.Message) error { return nil }
|
|
|
|
// Finalize implements round.Round
|
|
//
|
|
// - compute Γ = ∑ⱼ Γⱼ
|
|
// - compute Δᵢ = kᵢ⋅Γ.
|
|
func (r *presign5) Finalize(out chan<- *round.Message) (round.Session, error) {
|
|
// Γ = ∑ⱼ Γⱼ
|
|
Gamma := r.Group().NewPoint()
|
|
for _, GammaJ := range r.BigGammaShare {
|
|
Gamma = Gamma.Add(GammaJ)
|
|
}
|
|
|
|
// Δᵢ = kᵢ⋅Γ
|
|
BigDeltaShare := r.KShare.Act(Gamma)
|
|
|
|
proofLog := zkelog.NewProof(r.Group(), r.HashForID(r.SelfID()),
|
|
zkelog.Public{
|
|
E: r.ElGamalK[r.SelfID()],
|
|
ElGamalPublic: r.ElGamal[r.SelfID()],
|
|
Base: Gamma,
|
|
Y: BigDeltaShare,
|
|
}, zkelog.Private{
|
|
Y: r.KShare,
|
|
Lambda: r.ElGamalKNonce,
|
|
})
|
|
|
|
err := r.BroadcastMessage(out, &broadcast6{
|
|
BigDeltaShare: BigDeltaShare,
|
|
Proof: proofLog,
|
|
})
|
|
if err != nil {
|
|
return r, err
|
|
}
|
|
|
|
return &presign6{
|
|
presign5: r,
|
|
Gamma: Gamma,
|
|
BigDeltaShares: map[party.ID]curve.Point{r.SelfID(): BigDeltaShare},
|
|
}, nil
|
|
}
|
|
|
|
// RoundNumber implements round.Content.
|
|
func (message5) RoundNumber() round.Number { return 5 }
|
|
|
|
// MessageContent implements round.Round.
|
|
func (r *presign5) MessageContent() round.Content {
|
|
return &message5{
|
|
ProofLog: zklogstar.Empty(r.Group()),
|
|
}
|
|
}
|
|
|
|
// RoundNumber implements round.Content.
|
|
func (broadcast5) RoundNumber() round.Number { return 5 }
|
|
|
|
// BroadcastContent implements round.BroadcastRound.
|
|
func (r *presign5) BroadcastContent() round.BroadcastContent {
|
|
return &broadcast5{
|
|
BigGammaShare: r.Group().NewPoint(),
|
|
}
|
|
}
|
|
|
|
// Number implements round.Round.
|
|
func (*presign5) Number() round.Number { return 5 }
|