http/client.go

// Client — a fasthttp-style client speaking ZAP-HTTP.
//
// Usage mirrors fasthttp's Do(req, resp):
//
//	t := zaphttp.Dial("tcp", "server:9999")
//	req := fasthttp.AcquireRequest()
//	resp := fasthttp.AcquireResponse()
//	req.SetRequestURI("/healthz")
//	req.Header.SetMethod(fasthttp.MethodGet)
//	err := t.Do(req, resp)
//
// Connection management uses a free-list pool of idle TCP connections. Do
// pulls an idle conn (or dials a new one), runs one exchange, and returns
// it to the pool. Because UnmarshalResponse fully buffers the response
// body into resp, the connection is reusable the instant the frame is
// decoded — no body-close handshake is needed. The pool caps at
// MaxIdleConns; surplus conns close on return.

package zaphttp

import (
	"bufio"
	"fmt"
	"io"
	"net"
	"sync"
	"time"

	"github.com/valyala/fasthttp"
)

// pooledConn is one idle connection. The bufio.Reader and the request/response
// scratch buffers are held with the conn so a warm connection marshals, writes,
// reads, and decodes with zero heap allocation across requests.
type pooledConn struct {
	c    net.Conn
	br   *bufio.Reader
	wbuf []byte // request frame, incl. 4-byte length prefix
	rbuf []byte // inbound response frame
}

// Transport speaks ZAP over a pooled connection. Field-zero is invalid; use
// Dial.
type Transport struct {
	network      string
	addr         string
	dialTimeout  time.Duration
	readTimeout  time.Duration
	maxIdleConns int

	mu   sync.Mutex
	idle []*pooledConn // LIFO; most-recently-returned is hottest
}

// Dial returns a Transport that speaks ZAP to addr over network, mirroring
// net.Dial: the network is a value ("tcp", "unix", …), not a family of
// functions. A unix address is a socket path and carries the same ZAP frames
// as tcp — the wire does not change with the network.
//
//	zaphttp.Dial("tcp", "billing.hanzo.svc:9653")
//	zaphttp.Dial("unix", "/run/hanzo/billing.sock")
//
// Dialing is lazy; the first request opens the connection.
func Dial(network, addr string) *Transport {
	if network == "" {
		network = "tcp"
	}
	return &Transport{
		network:      network,
		addr:         addr,
		dialTimeout:  10 * time.Second,
		readTimeout:  30 * time.Second,
		maxIdleConns: 32,
	}
}

// SetDialTimeout overrides the default 10s dial timeout.
func (t *Transport) SetDialTimeout(d time.Duration) { t.dialTimeout = d }

// SetReadTimeout overrides the default 30s response-read timeout.
func (t *Transport) SetReadTimeout(d time.Duration) { t.readTimeout = d }

// SetMaxIdleConns caps the number of idle conns held in the pool. Surplus
// conns close on return.
func (t *Transport) SetMaxIdleConns(n int) {
	if n < 0 {
		n = 0
	}
	t.maxIdleConns = n
}

// Do executes a single request/response exchange, filling resp. It is safe
// for concurrent use: each call takes its own connection from the pool.
func (t *Transport) Do(req *fasthttp.Request, resp *fasthttp.Response) error {
	if t.addr == "" {
		return fmt.Errorf("zaphttp: Transport.addr is empty (use Dial)")
	}

	pc, err := t.acquireConn()
	if err != nil {
		return fmt.Errorf("zaphttp: dial %s: %w", t.addr, err)
	}
	conn, br := pc.c, pc.br

	// Build [4-byte length prefix][request frame] in the conn's reused buffer and
	// write it with a single syscall.
	pc.wbuf = append(pc.wbuf[:0], 0, 0, 0, 0)
	pc.wbuf, err = AppendRequest(pc.wbuf, req)
	if err != nil {
		conn.Close()
		return err
	}
	if err := writeFramePrefixed(conn, pc.wbuf); err != nil {
		conn.Close()
		return fmt.Errorf("zaphttp: write request: %w", err)
	}

	if t.readTimeout > 0 {
		_ = conn.SetReadDeadline(time.Now().Add(t.readTimeout))
	}
	pc.rbuf, err = readFrameInto(br, pc.rbuf)
	if err != nil {
		conn.Close()
		return fmt.Errorf("zaphttp: read response: %w", err)
	}
	respFrame := pc.rbuf
	ft, ok := frameType(respFrame)
	if !ok {
		conn.Close()
		return fmt.Errorf("zaphttp: short response frame")
	}

	// Streamed response: apply the head, then attach a body stream that reads
	// FrameData chunks until FrameEnd. The conn is NOT pooled until the stream
	// is fully consumed (or the body is closed) — the reader owns it. The head
	// frame must be copied out of the conn's reused rbuf, since the streamReader
	// keeps reading into it.
	if ft == FrameResponseHead {
		if err := UnmarshalResponseHead(respFrame, resp); err != nil {
			conn.Close()
			return fmt.Errorf("zaphttp: unmarshal response head: %w", err)
		}
		resp.SetBodyStream(&streamReader{t: t, pc: pc, br: br}, -1)
		return nil
	}

	if err := UnmarshalResponse(respFrame, resp); err != nil {
		conn.Close()
		return fmt.Errorf("zaphttp: unmarshal response: %w", err)
	}

	// Reset the read deadline and return the conn to the pool. The response
	// is fully buffered in resp, so the conn is immediately reusable.
	_ = conn.SetReadDeadline(time.Time{})
	t.releaseConn(pc)
	return nil
}

// streamReader turns the FrameData/FrameEnd sequence following a streamed
// response head into an io.ReadCloser body: each Read drains the current chunk,
// pulling the next FrameData frame when empty and returning io.EOF at FrameEnd.
// fasthttp closes it when the response is released, which returns the conn to
// the pool (fully drained) or closes it (abandoned mid-stream).
type streamReader struct {
	t    *Transport
	pc   *pooledConn
	br   *bufio.Reader
	rest []byte // undrained tail of the current chunk
	done bool
	err  error
}

func (s *streamReader) Read(p []byte) (int, error) {
	if len(s.rest) > 0 {
		n := copy(p, s.rest)
		s.rest = s.rest[n:]
		return n, nil
	}
	if s.done {
		return 0, io.EOF
	}
	if s.err != nil {
		return 0, s.err
	}
	frame, err := readFrame(s.br)
	if err != nil {
		s.err = err
		return 0, err
	}
	ft, err := FrameTypeOf(frame)
	if err != nil {
		s.err = err
		return 0, err
	}
	switch ft {
	case FrameData:
		chunk, err := DataChunkOf(frame)
		if err != nil {
			s.err = err
			return 0, err
		}
		n := copy(p, chunk)
		if n < len(chunk) {
			s.rest = append(s.rest, chunk[n:]...) // buffer the tail (chunk aliases frame; copy)
		}
		return n, nil
	case FrameEnd:
		s.done = true
		s.release()
		return 0, io.EOF
	default:
		s.err = fmt.Errorf("zaphttp: unexpected frame %#x mid-stream", ft)
		return 0, s.err
	}
}

// Close returns the conn to the pool if the stream drained cleanly, else closes
// it (abandoned mid-stream leaves unread frames on the wire — not reusable).
func (s *streamReader) Close() error {
	if s.done {
		s.release()
	} else {
		s.pc.c.Close()
	}
	return nil
}

func (s *streamReader) release() {
	if s.pc == nil {
		return
	}
	_ = s.pc.c.SetReadDeadline(time.Time{})
	s.t.releaseConn(s.pc)
	s.pc = nil
}

// acquireConn pops an idle conn or dials a new one.
func (t *Transport) acquireConn() (*pooledConn, error) {
	t.mu.Lock()
	if n := len(t.idle); n > 0 {
		pc := t.idle[n-1]
		t.idle = t.idle[:n-1]
		t.mu.Unlock()
		return pc, nil
	}
	t.mu.Unlock()

	c, err := net.DialTimeout(t.network, t.addr, t.dialTimeout)
	if err != nil {
		return nil, err
	}
	if tc, ok := c.(*net.TCPConn); ok {
		_ = tc.SetKeepAlive(true)
		_ = tc.SetKeepAlivePeriod(30 * time.Second)
		_ = tc.SetNoDelay(true)
	}
	return &pooledConn{c: c, br: bufio.NewReaderSize(c, connReadBufSize)}, nil
}

// releaseConn returns a conn to the pool, or closes it if the pool is full.
func (t *Transport) releaseConn(pc *pooledConn) {
	t.mu.Lock()
	if len(t.idle) >= t.maxIdleConns {
		t.mu.Unlock()
		_ = pc.c.Close()
		return
	}
	t.idle = append(t.idle, pc)
	t.mu.Unlock()
}

// CloseIdleConnections closes every idle conn in the pool. Active requests
// are unaffected. Useful in tests and on shutdown.
func (t *Transport) CloseIdleConnections() {
	t.mu.Lock()
	idle := t.idle
	t.idle = nil
	t.mu.Unlock()
	for _, pc := range idle {
		_ = pc.c.Close()
	}
}

// Get is a convenience for one-shot service-to-service calls. The caller
// owns resp and must fasthttp.ReleaseResponse it when done.
func Get(addr, path string) (*fasthttp.Response, error) {
	t := Dial("tcp", addr)
	defer t.CloseIdleConnections()

	req := fasthttp.AcquireRequest()
	defer fasthttp.ReleaseRequest(req)
	req.Header.SetMethod(fasthttp.MethodGet)
	req.SetRequestURI(path)
	req.Header.SetHost(addr)

	resp := fasthttp.AcquireResponse()
	if err := t.Do(req, resp); err != nil {
		fasthttp.ReleaseResponse(resp)
		return nil, err
	}
	return resp, nil
}