mirror of
https://github.com/zap-proto/zip.git
synced 2026-10-19 15:38:57 +00:00
zeekayandHanzo Dev
222d7f196d
App.Test says it "builds the program if nothing is live, exactly as serving would, so a test exercises the same generation a request would". It did not. Serving calls prepare, which installs the DEFERRED PROJECTIONS — /mcp, the OpenAPI document, the op-call plane, the plugin route. Building alone installs none of them, so those four addresses answered 404 under Test and 200 in production. That is the worst shape a test can have: it cannot see the surface it was written to check, and the closer it gets to the real program the more confidently it reports the wrong thing. hanzoai/cloud's MCP tests only passed because callers reached for an exported Prepare and remembered to call it — which is why unexporting Prepare broke them rather than fixing them. The projections belong to "run the program", not to the caller's discipline. prepare is sync.Once, so a table test that calls Test in a loop still installs them once; TestTestPreparesIdempotently holds that. Co-authored-by: Hanzo Dev <[email protected]>
73 lines
2.5 KiB
Go
73 lines
2.5 KiB
Go
package zip
|
|
|
|
import (
|
|
"context"
|
|
"net/http"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
type doorIn struct{}
|
|
type doorOut struct{ OK bool }
|
|
|
|
func doorHandler(context.Context, *doorIn) (*doorOut, error) { return &doorOut{true}, nil }
|
|
|
|
// TestTestSeesTheSameSurfaceServingWould is the invariant [App.Test] claims and
|
|
// did not hold: "it builds the program if nothing is live, exactly as serving
|
|
// would".
|
|
//
|
|
// Serving calls prepare, which installs the deferred projections — /mcp, the
|
|
// OpenAPI document, the op-call plane, the plugin route. Building does not. So
|
|
// Test used to answer 404 on all four while production answered 200: a test could
|
|
// not see the surface it was written to check, and the closer it got to the real
|
|
// program the more confidently it reported the wrong thing.
|
|
//
|
|
// Callers papered over that with an exported Prepare they had to remember to
|
|
// call, which is why unexporting it broke hanzoai/cloud's MCP tests rather than
|
|
// fixing them. The projections belong to "run the program", not to the caller's
|
|
// discipline.
|
|
func TestTestSeesTheSameSurfaceServingWould(t *testing.T) {
|
|
app := New(Config{AppName: "door", DisableStartupMessage: true})
|
|
Post(app, "/thing", doorHandler)
|
|
|
|
req, _ := http.NewRequest(http.MethodPost, "/mcp",
|
|
strings.NewReader(`{"jsonrpc":"2.0","id":1,"method":"tools/list"}`))
|
|
req.Header.Set("Content-Type", "application/json")
|
|
|
|
resp, err := app.Test(req)
|
|
if err != nil {
|
|
t.Fatalf("Test: %v", err)
|
|
}
|
|
defer resp.Body.Close()
|
|
|
|
if resp.StatusCode == http.StatusNotFound {
|
|
t.Fatal("/mcp answered 404 under Test — the door serving installs is missing, " +
|
|
"so a test cannot see the surface production exposes")
|
|
}
|
|
if resp.StatusCode != http.StatusOK {
|
|
t.Errorf("/mcp = %d, want 200", resp.StatusCode)
|
|
}
|
|
}
|
|
|
|
// TestTestPreparesIdempotently: prepare runs at most once, so repeated Test calls
|
|
// (the normal shape of a table test) must not reinstall the projections and
|
|
// collide on their own routes.
|
|
func TestTestPreparesIdempotently(t *testing.T) {
|
|
app := New(Config{AppName: "door2", DisableStartupMessage: true})
|
|
Post(app, "/thing", doorHandler)
|
|
|
|
for i := 0; i < 3; i++ {
|
|
req, _ := http.NewRequest(http.MethodPost, "/mcp",
|
|
strings.NewReader(`{"jsonrpc":"2.0","id":1,"method":"tools/list"}`))
|
|
req.Header.Set("Content-Type", "application/json")
|
|
resp, err := app.Test(req)
|
|
if err != nil {
|
|
t.Fatalf("Test %d: %v", i, err)
|
|
}
|
|
resp.Body.Close()
|
|
if resp.StatusCode != http.StatusOK {
|
|
t.Fatalf("Test %d: /mcp = %d, want 200", i, resp.StatusCode)
|
|
}
|
|
}
|
|
}
|