mirror of
https://github.com/hanzoai/cd.git
synced 2026-10-30 14:56:45 +00:00
zeekayandHanzo Dev
cbf668a980
go fix applied the modernizers: promoted-field keys in struct literals,
strings.Cut, SplitSeq, new(expr), slices and maps helpers, wg.Go, reflect.TypeFor
and errors.AsType. omitzero is left out, since omitting a zero struct such as
time.Time{} is a per-field wire decision and not a mechanical one.
Two changes the modernizers could not make for themselves. AsType needs its type
argument to be an error, so the git exit-status reader embeds error in the
interface it asks for. And an error built by concatenating a tag list into its
own format string now says so with a verb, which is what vet was pointing at.
Co-authored-by: Hanzo Dev <[email protected]>
257 lines
8.0 KiB
Go
257 lines
8.0 KiB
Go
package controller
|
|
|
|
import (
|
|
"encoding/json"
|
|
"errors"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/hanzoai/cd/common"
|
|
"github.com/hanzoai/cd/pkg/apis/application/v1alpha1"
|
|
"github.com/hanzoai/cd/reposerver/apiclient"
|
|
"github.com/hanzoai/cd/test"
|
|
"github.com/hanzoai/cd/util/settings"
|
|
)
|
|
|
|
func TestGetRepoObjs(t *testing.T) {
|
|
cm := test.NewConfigMap()
|
|
cm.SetAnnotations(map[string]string{
|
|
"custom-annotation": "custom-value",
|
|
common.AnnotationInstallationID: "id", // tracking annotation should be removed
|
|
common.AnnotationKeyAppInstance: "my-app", // tracking annotation should be removed
|
|
})
|
|
cmBytes, _ := json.Marshal(cm)
|
|
|
|
app := newFakeApp()
|
|
// Enable the manifest-generate-paths annotation and set a synced revision
|
|
app.SetAnnotations(map[string]string{v1alpha1.AnnotationKeyManifestGeneratePaths: "."})
|
|
app.Status.Sync = v1alpha1.SyncStatus{
|
|
Revision: "abc123",
|
|
Status: v1alpha1.SyncStatusCodeSynced,
|
|
}
|
|
|
|
data := fakeData{
|
|
manifestResponse: &apiclient.ManifestResponse{
|
|
Manifests: []string{string(cmBytes)},
|
|
Namespace: test.FakeDestNamespace,
|
|
Server: test.FakeClusterURL,
|
|
Revision: "abc123",
|
|
},
|
|
}
|
|
|
|
ctrl := newFakeControllerWithResync(t.Context(), &data, time.Minute, nil, errors.New("this should not be called"))
|
|
source := app.Spec.GetSource()
|
|
source.RepoURL = "oci://example.com/hanzoai/cd"
|
|
|
|
objs, resp, err := ctrl.GetRepoObjs(t.Context(), app, source, "abc123", &v1alpha1.AppProject{
|
|
Name: "default",
|
|
Namespace: test.FakeArgoCDNamespace,
|
|
Spec: v1alpha1.AppProjectSpec{
|
|
SourceRepos: []string{"*"},
|
|
Destinations: []v1alpha1.ApplicationDestination{
|
|
{
|
|
Server: "*",
|
|
Namespace: "*",
|
|
},
|
|
},
|
|
},
|
|
})
|
|
require.NoError(t, err)
|
|
assert.NotNil(t, resp)
|
|
assert.Equal(t, "abc123", resp.Revision)
|
|
assert.Len(t, objs, 1)
|
|
|
|
annotations := objs[0].GetAnnotations()
|
|
|
|
// only the tracking annotations set by Hanzo CD should be removed
|
|
// and not the custom annotations set by user
|
|
require.NotNil(t, annotations)
|
|
assert.Equal(t, "custom-value", annotations["custom-annotation"])
|
|
assert.NotContains(t, annotations, common.AnnotationInstallationID)
|
|
assert.NotContains(t, annotations, common.AnnotationKeyAppInstance)
|
|
|
|
assert.Equal(t, "ConfigMap", objs[0].GetKind())
|
|
}
|
|
|
|
// TestGetRepoObjs_SourceIntegrity_Wiring asserts the controller-level wiring of
|
|
// source integrity verification: the project's effective SourceIntegrity is
|
|
// passed through to repo-server in the ManifestRequest during hydration.
|
|
func TestGetRepoObjs_SourceIntegrity_Wiring(t *testing.T) {
|
|
proj := &v1alpha1.AppProject{
|
|
Name: "default", Namespace: test.FakeArgoCDNamespace,
|
|
Spec: v1alpha1.AppProjectSpec{
|
|
SourceRepos: []string{"*"},
|
|
Destinations: []v1alpha1.ApplicationDestination{{Server: "*", Namespace: "*"}},
|
|
SourceIntegrity: &v1alpha1.SourceIntegrity{
|
|
Git: &v1alpha1.SourceIntegrityGit{
|
|
Policies: []*v1alpha1.SourceIntegrityGitPolicy{{
|
|
Repos: []v1alpha1.SourceIntegrityGitPolicyRepo{{URL: "*"}},
|
|
GPG: &v1alpha1.SourceIntegrityGitPolicyGPG{
|
|
Mode: v1alpha1.SourceIntegrityGitPolicyGPGModeStrict,
|
|
Keys: []string{"4AEE18F83AFDEB23"},
|
|
},
|
|
}},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
|
|
cm := test.NewConfigMap()
|
|
cmBytes, _ := json.Marshal(cm)
|
|
|
|
var captured *apiclient.ManifestRequest
|
|
data := fakeData{
|
|
manifestResponse: &apiclient.ManifestResponse{
|
|
Manifests: []string{string(cmBytes)},
|
|
Namespace: test.FakeDestNamespace,
|
|
Server: test.FakeClusterURL,
|
|
Revision: "abc123",
|
|
},
|
|
onGenerateManifest: func(req *apiclient.ManifestRequest) { captured = req },
|
|
}
|
|
ctrl := newFakeControllerWithResync(t.Context(), &data, time.Minute, nil, errors.New("this should not be called"))
|
|
|
|
app := newFakeApp()
|
|
_, _, err := ctrl.GetRepoObjs(t.Context(), app, app.Spec.GetSource(), "abc123", proj)
|
|
require.NoError(t, err)
|
|
require.NotNil(t, captured, "repo-server was not called")
|
|
require.NotNil(t, captured.SourceIntegrity, "expected SourceIntegrity to be forwarded to repo-server")
|
|
assert.NotNil(t, captured.SourceIntegrity.Git)
|
|
}
|
|
|
|
func TestGetHydratorCommitMessageTemplate_WhenTemplateisNotDefined_FallbackToDefault(t *testing.T) {
|
|
cm := test.NewConfigMap()
|
|
cmBytes, _ := json.Marshal(cm)
|
|
|
|
data := fakeData{
|
|
manifestResponse: &apiclient.ManifestResponse{
|
|
Manifests: []string{string(cmBytes)},
|
|
Namespace: test.FakeDestNamespace,
|
|
Server: test.FakeClusterURL,
|
|
Revision: "abc123",
|
|
},
|
|
}
|
|
|
|
ctrl := newFakeControllerWithResync(t.Context(), &data, time.Minute, nil, errors.New("this should not be called"))
|
|
|
|
tmpl, err := ctrl.GetHydratorCommitMessageTemplate()
|
|
require.NoError(t, err)
|
|
assert.NotEmpty(t, tmpl) // should fallback to default
|
|
assert.Equal(t, settings.CommitMessageTemplate, tmpl)
|
|
}
|
|
|
|
func TestGetHydratorCommitMessageTemplate(t *testing.T) {
|
|
cm := test.NewFakeConfigMap()
|
|
cm.Data["sourceHydrator.commitMessageTemplate"] = settings.CommitMessageTemplate
|
|
cmBytes, _ := json.Marshal(cm)
|
|
|
|
data := fakeData{
|
|
manifestResponse: &apiclient.ManifestResponse{
|
|
Manifests: []string{string(cmBytes)},
|
|
Namespace: test.FakeDestNamespace,
|
|
Server: test.FakeClusterURL,
|
|
Revision: "abc123",
|
|
},
|
|
configMapData: cm.Data,
|
|
}
|
|
|
|
ctrl := newFakeControllerWithResync(t.Context(), &data, time.Minute, nil, errors.New("this should not be called"))
|
|
|
|
tmpl, err := ctrl.GetHydratorCommitMessageTemplate()
|
|
require.NoError(t, err)
|
|
assert.NotEmpty(t, tmpl)
|
|
}
|
|
|
|
func TestGetHydratorReadmeMessageTemplate_WhenTemplateIsNotDefined_FallbackToDefault(t *testing.T) {
|
|
cm := test.NewConfigMap()
|
|
cmBytes, _ := json.Marshal(cm)
|
|
|
|
data := fakeData{
|
|
manifestResponse: &apiclient.ManifestResponse{
|
|
Manifests: []string{string(cmBytes)},
|
|
Namespace: test.FakeDestNamespace,
|
|
Server: test.FakeClusterURL,
|
|
Revision: "abc123",
|
|
},
|
|
}
|
|
|
|
ctrl := newFakeControllerWithResync(t.Context(), &data, time.Minute, nil, errors.New("this should not be called"))
|
|
|
|
tmpl, err := ctrl.GetHydratorReadmeMessageTemplate()
|
|
require.NoError(t, err)
|
|
assert.NotEmpty(t, tmpl)
|
|
assert.Equal(t, settings.DefaultManifestHydrationReadmeTemplate, tmpl)
|
|
}
|
|
|
|
func TestGetHydratorReadmeMessageTemplate(t *testing.T) {
|
|
readmeTemplate := `hello world`
|
|
cm := test.NewFakeConfigMap()
|
|
cm.Data["sourceHydrator.readmeMessageTemplate"] = readmeTemplate
|
|
cmBytes, _ := json.Marshal(cm)
|
|
|
|
data := fakeData{
|
|
manifestResponse: &apiclient.ManifestResponse{
|
|
Manifests: []string{string(cmBytes)},
|
|
Namespace: test.FakeDestNamespace,
|
|
Server: test.FakeClusterURL,
|
|
Revision: "abc123",
|
|
},
|
|
configMapData: cm.Data,
|
|
}
|
|
|
|
ctrl := newFakeControllerWithResync(t.Context(), &data, time.Minute, nil, errors.New("this should not be called"))
|
|
|
|
tmpl, err := ctrl.GetHydratorReadmeMessageTemplate()
|
|
require.NoError(t, err)
|
|
assert.NotEmpty(t, tmpl)
|
|
assert.Equal(t, readmeTemplate, tmpl)
|
|
}
|
|
|
|
func TestEvaluateAppRevisionsChanges(t *testing.T) {
|
|
app := newFakeApp()
|
|
app.Spec.SourceHydrator = &v1alpha1.SourceHydrator{
|
|
DrySource: v1alpha1.DrySource{
|
|
RepoURL: app.Spec.Source.RepoURL,
|
|
TargetRevision: app.Spec.Source.TargetRevision,
|
|
Path: app.Spec.Source.Path,
|
|
},
|
|
SyncSource: v1alpha1.SyncSource{
|
|
TargetBranch: "hydrated",
|
|
Path: "hydrated/path",
|
|
},
|
|
}
|
|
app.Status.SourceHydrator.LastComparedDryRevision = "old-sha"
|
|
|
|
data := fakeData{
|
|
resolveRevisionResponses: []*apiclient.ResolveRevisionResponse{
|
|
{
|
|
Revision: "new-sha",
|
|
AmbiguousRevision: app.Spec.SourceHydrator.GetDrySource().TargetRevision,
|
|
},
|
|
},
|
|
}
|
|
|
|
ctrl := newFakeController(t.Context(), &data, nil)
|
|
drySource := app.Spec.SourceHydrator.GetDrySource()
|
|
|
|
hasChanges, resolvedRev, err := ctrl.EvaluateAppRevisionsChanges(t.Context(), app, drySource, "HEAD", &v1alpha1.AppProject{
|
|
Name: "default",
|
|
Namespace: test.FakeArgoCDNamespace,
|
|
Spec: v1alpha1.AppProjectSpec{
|
|
SourceRepos: []string{"*"},
|
|
Destinations: []v1alpha1.ApplicationDestination{
|
|
{
|
|
Server: "*",
|
|
Namespace: "*",
|
|
},
|
|
},
|
|
},
|
|
}, false)
|
|
require.NoError(t, err)
|
|
assert.True(t, hasChanges)
|
|
assert.Equal(t, "new-sha", resolvedRev)
|
|
}
|