hanzoai/datastore
2
0
Fork 0
mirror of https://github.com/hanzoai/datastore.git synced 2026-09-26 13:55:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Disable cppcoreguidelines-* aliases for checks in other modules

Browse Source 
The previous `Make cppcoreguidelines-* exclusion explicit in .clang-tidy`
commit replaced the wildcard `-cppcoreguidelines-*` with an explicit list
of disables, but the explicit list missed clang-tidy aliases whose
canonical names live in other modules (`modernize-*`, `readability-*`,
`bugprone-*`, `misc-*`, `performance-*`).

Without the wildcard, those aliases became enabled (because their
underlying canonical checks are enabled), and CI started rejecting code
under names like `cppcoreguidelines-avoid-magic-numbers`,
`cppcoreguidelines-avoid-c-arrays`, and
`cppcoreguidelines-narrowing-conversions`.

Add explicit disables for all 11 known `cppcoreguidelines-*` aliases so
the original suppression behaviour is preserved while the explicit list
remains a complete, audit-friendly mapping of every check in this group.

CI report:
https://s3.amazonaws.com/clickhouse-test-reports/PRs/100399/07f475b6a1bff91d197fac08e8178911fb38ce93/build_arm_tidy/build_clickhouse/build_clickhouse.log.zst

PR: https://github.com/ClickHouse/ClickHouse/pull/100399

Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
This commit is contained in:
Alexey Milovidov
2026-05-06 10:32:39 +00:00
co-authored by Claude Opus 4.7
parent b550df5498
commit 21fdf4d2ed
1 changed files with 14 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.clang-tidy
+14
View File
@@ -81,6 +81,20 @@ Checks: [
'-cppcoreguidelines-special-member-functions',
'-cppcoreguidelines-use-enum-class',
'-cppcoreguidelines-virtual-class-destructor',
# Aliases for checks owned by other modules. Disabled here so they are not silently re-enabled
# now that the wildcard `-cppcoreguidelines-*` is gone; their canonical names are handled
# elsewhere in this file.
'-cppcoreguidelines-avoid-c-arrays', # alias of `modernize-avoid-c-arrays`
'-cppcoreguidelines-avoid-magic-numbers', # alias of `readability-magic-numbers`
'-cppcoreguidelines-c-copy-assignment-signature', # alias of `misc-unconventional-assign-operator`
'-cppcoreguidelines-explicit-virtual-functions', # alias of `modernize-use-override`
'-cppcoreguidelines-macro-to-enum', # alias of `modernize-macro-to-enum`
'-cppcoreguidelines-narrowing-conversions', # alias of `bugprone-narrowing-conversions`
'-cppcoreguidelines-noexcept-destructor', # alias of `performance-noexcept-destructor`
'-cppcoreguidelines-noexcept-move-operations', # alias of `performance-noexcept-move-constructor`
'-cppcoreguidelines-noexcept-swap', # alias of `performance-noexcept-swap`
'-cppcoreguidelines-non-private-member-variables-in-classes', # alias of `misc-non-private-member-variables-in-classes`
'-cppcoreguidelines-use-default-member-init', # alias of `modernize-use-default-member-init`
'-darwin-*',