chore(deps): update module github.com/golangci/golangci-lint/v2 to v2.12.2 (#28424)

Signed-off-by: renovate[bot] <renovate[bot]@users.noreply.github.com>
Signed-off-by: Patroklos Papapetrou <[email protected]>
Co-authored-by: argoproj-renovate[bot] <161757507+argoproj-renovate[bot]@users.noreply.github.com>
Co-authored-by: Patroklos Papapetrou <[email protected]>

.github/workflows/ci-build.yaml

@@ -137,7 +137,7 @@ jobs:
         uses: golangci/golangci-lint-action@82606bf257cbaff209d206a39f5134f0cfbfd2ee # v9.2.1
         with:
           # renovate: datasource=go packageName=github.com/golangci/golangci-lint/v2 versioning=regex:^v(?<major>\d+)\.(?<minor>\d+)\.(?<patch>\d+)?$
-          version: v2.11.4
+          version: v2.12.2
           args: --verbose
 
   test-go:

.golangci.yaml

@@ -18,7 +18,7 @@ linters:
     - errorlint
     - exptostd
     - gocritic
-    - gomodguard
+    - gomodguard_v2
     - govet
     - importas
     - misspell
@@ -68,21 +68,18 @@ linters:
         - unnamedResult
         - whyNoLint
 
-    gomodguard:
+    gomodguard_v2:
       blocked:
-        modules:
-          - github.com/golang-jwt/jwt/v4:
-              recommendations:
-                - github.com/golang-jwt/jwt/v5
-
-          - github.com/imdario/mergo:
-              recommendations:
-                - dario.cat/mergo
-              reason: '`github.com/imdario/mergo` has been renamed.'
-
-          - github.com/pkg/errors:
-              recommendations:
-                - errors
+        - module: github.com/golang-jwt/jwt/v4
+          recommendations:
+            - github.com/golang-jwt/jwt/v5
+        - module: github.com/imdario/mergo
+          recommendations:
+            - dario.cat/mergo
+          reason: '`github.com/imdario/mergo` has been renamed.'
+        - module: github.com/pkg/errors
+          recommendations:
+            - errors
 
     govet:
       disable:

applicationset/utils/utils.go

@@ -94,7 +94,7 @@ func (r *Render) deeplyReplaceWithFilter(destination, original reflect.Value, re
 	switch original.Kind() {
 	// The first cases handle nested structures and translate them recursively
 	// If it is a pointer we need to unwrap and call once again
-	case reflect.Ptr:
+	case reflect.Pointer:
 		// To get the actual value of the original we have to call Elem()
 		// At the same time this unwraps the pointer so we don't end up in
 		// an infinite recursion
@@ -313,7 +313,7 @@ func getFilteredGeneratorTypes() map[string]bool {
 	t := reflect.TypeFor[argoappsv1.ApplicationSetGenerator]()
 	for field := range t.Fields() {
 		genPtrType := field.Type
-		if genPtrType.Kind() == reflect.Ptr && strings.HasSuffix(genPtrType.String(), "Generator") {
+		if genPtrType.Kind() == reflect.Pointer && strings.HasSuffix(genPtrType.String(), "Generator") {
 			genType := genPtrType.Elem()
 			for field := range genType.Fields() {
 				if field.Name == "Values" && field.Type.String() == "map[string]string" {

cmd/argocd/commands/app.go

@@ -2195,8 +2195,8 @@ func getResourceStates(app *argoappv1.Application, selectedResources []*argoappv
 	}
 	// filter out not selected resources
 	if len(selectedResources) > 0 {
-		for i := len(states) - 1; i >= 0; i-- {
-			res := states[i]
+		for i, v := range slices.Backward(states) {
+			res := v
 			if !argo.IncludeResource(res.Name, res.Namespace, schema.GroupVersionKind{Group: res.Group, Kind: res.Kind}, selectedResources) {
 				states = append(states[:i], states[i+1:]...)
 			}

controller/cache/info.go

@@ -3,6 +3,7 @@ package cache
 import (
 	"errors"
 	"fmt"
+	"slices"
 	"strconv"
 	"strings"
 
@@ -695,8 +696,8 @@ func populatePodInfo(un *unstructured.Unstructured, res *ResourceInfo) {
 	}
 	if !initializing || isPodInitializedConditionTrue(&pod.Status) {
 		hasRunning := false
-		for i := len(pod.Status.ContainerStatuses) - 1; i >= 0; i-- {
-			container := pod.Status.ContainerStatuses[i]
+		for _, v := range slices.Backward(pod.Status.ContainerStatuses) {
+			container := v
 
 			restarts += int(container.RestartCount)
 			switch {

controller/state.go

@@ -749,8 +749,8 @@ func (m *appStateManager) CompareAppState(ctx context.Context, app *v1alpha1.App
 	}
 	conditions = append(conditions, dedupConditions...)
 
-	for i := len(targetObjs) - 1; i >= 0; i-- {
-		targetObj := targetObjs[i]
+	for i, v := range slices.Backward(targetObjs) {
+		targetObj := v
 		gvk := targetObj.GroupVersionKind()
 		if resFilter.IsExcludedResource(gvk.Group, gvk.Kind, destCluster.Server) {
 			targetObjs = append(targetObjs[:i], targetObjs[i+1:]...)

hack/installers/install-lint-tools.sh

@@ -2,6 +2,6 @@
 set -eux -o pipefail
 
 # renovate: datasource=go packageName=github.com/golangci/golangci-lint/v2
-GOLANGCI_LINT_VERSION=2.11.4
+GOLANGCI_LINT_VERSION=2.12.2
 
 GO111MODULE=on go install "github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v${GOLANGCI_LINT_VERSION}"