hanzoai/deploy
2
0
Fork 0
mirror of https://github.com/hanzoai/deploy.git synced 2026-10-07 08:44:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: extensions is not loading for ConfigMap/Pods (#10010)

Browse Source 
Signed-off-by: Alexander Matyushentsev <[email protected]>
This commit is contained in:
Alexander Matyushentsev
2022-07-15 21:40:33 -04:00
committed by GitHub
parent b98fb0a49a
commit a2db2cb30a
3 changed files with 15 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/developer-guide/ui-extensions.md
+4 -1
View File
@@ -35,14 +35,17 @@ registerResourceExtension(component: ExtensionComponent, group: string, kind: st
* `component: ExtensionComponent` is a React component that receives the following properties:
* application: Application - Argo CD Application resource;
* resource: State - the kubernetes resource object;
* tree: ApplicationTree - includes list of all resources that comprise the application;
See properties interfaces in [models.ts](https://github.com/argoproj/argo-cd/blob/master/ui/src/app/shared/models.ts)
* `group: string` - the glob expression that matches the group of the resource;
* `group: string` - the glob expression that matches the group of the resource; note: use globstar (`**`) to match all groups including empty string;
* `kind: string` - the glob expression that matches the kind of the resource;
* `tabTitle: string` - the extension tab title.
* `opts: Object` - additional options:
* `icon: string` - the class name the represents the icon from the [https://fontawesome.com/](https://fontawesome.com/) library (e.g. 'fa-calendar-alt');
Below is an example of a resource tab extension:
ui/src/app/applications/components/resource-details/resource-details.tsx
+6 -4
View File
@@ -133,9 +133,10 @@ export const ResourceDetails = (props: ResourceDetailsProps) => {
key: `extension-${i}`,
content: (
<ErrorBoundary message={`Something went wrong with Extension for ${state.kind}`}>
<tabExtensions.component tree={tree} resource={state} />
<tabExtensions.component tree={tree} resource={state} application={application} />
</ErrorBoundary>
)
),
icon: tabExtensions.icon
});
});
}
@@ -216,13 +217,14 @@ export const ResourceDetails = (props: ResourceDetailsProps) => {
const extensionTabs = services.extensions.getResourceTabs('argoproj.io', 'Application').map((ext, i) => ({
title: ext.title,
key: `extension-${i}`,
content: <ext.component resource={application} tree={tree} />
content: <ext.component resource={application} tree={tree} application={application} />,
icon: ext.icon
}));
return tabs.concat(extensionTabs);
};
const extensions = selectedNode?.kind && selectedNode?.group ? services.extensions.getResourceTabs(selectedNode?.group, selectedNode?.kind) : [];
const extensions = selectedNode?.kind ? services.extensions.getResourceTabs(selectedNode?.group || '', selectedNode?.kind) : [];
return (
<div style={{width: '100%', height: '100%'}}>
ui/src/app/shared/services/extensions-service.ts
+5 -3
View File
@@ -1,14 +1,14 @@
import * as React from 'react';
import * as minimatch from 'minimatch';
import {ApplicationTree, State} from '../models';
import {Application, ApplicationTree, State} from '../models';
const extensions = {
resourceExtentions: new Array<ResourceTabExtension>()
};
function registerResourceExtension(component: ExtensionComponent, group: string, kind: string, tabTitle: string) {
extensions.resourceExtentions.push({component, group, kind, title: tabTitle});
function registerResourceExtension(component: ExtensionComponent, group: string, kind: string, tabTitle: string, opts?: {icon: string}) {
extensions.resourceExtentions.push({component, group, kind, title: tabTitle, icon: opts?.icon});
}
let legacyInitialized = false;
@@ -30,6 +30,7 @@ export interface ResourceTabExtension {
group: string;
kind: string;
component: ExtensionComponent;
icon?: string;
}
export type ExtensionComponent = React.ComponentType<ExtensionComponentProps>;
@@ -41,6 +42,7 @@ export interface Extension {
export interface ExtensionComponentProps {
resource: State;
tree: ApplicationTree;
application: Application;
}
export class ExtensionsService {