hanzoai/dev
2
0
Fork 0
mirror of https://github.com/hanzoai/dev.git synced 2026-10-25 03:32:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(tui/chatwidget): clarify background auto-review notes

Browse Source
This commit is contained in:
James Peter
2025-12-13 09:11:41 +10:00
parent 91d4a8352f
commit 4eaeaddaf5
1 changed files with 31 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code-rs/tui/src/chatwidget.rs
+31 -16
View File
@@ -32372,25 +32372,43 @@ impl ChatWidget<'_> {
release_background_lock(&agent_id);
let mut developer_note: Option<String> = None;
let snapshot_note = inflight_snapshot
.as_ref()
.map(|s| format!(" Snapshot {s}."))
.unwrap_or_default();
.as_deref()
.map(str::trim)
.filter(|s| !s.is_empty())
.map(|s| format!("Snapshot: {s} (review target)"))
.unwrap_or_else(|| "Snapshot: (unknown)".to_string());
let agent_note = agent_id
.as_ref()
.map(|id| format!(" Agent #{:.8}.", id))
.unwrap_or_default();
.as_deref()
.map(str::trim)
.filter(|s| !s.is_empty())
.map(|id| {
let short = id.chars().take(8).collect::<String>();
format!("Agent: #{short} (auto-review)")
})
.unwrap_or_else(|| "Agent: (unknown)".to_string());
let summary_note = summary
.as_deref()
.map(str::trim)
.filter(|s| !s.is_empty())
.map(|s| s.replace('\n', " "))
.map(|s| format!("Summary: {s}"));
let errored = error.is_some();
let indicator_status = if let Some(err) = error {
developer_note = Some(format!(
"[developer] Background auto-review failed in worktree '{branch}'. Error: {err}. Worktree path: {}.{snapshot_note}{agent_note}",
worktree_path.display()
"[developer] Background auto-review failed.\n\nThis auto-review ran in an isolated git worktree and did not modify your current workspace.\n\nWorktree: '{branch}'\nWorktree path: {}\n{snapshot_note}\n{agent_note}\nError: {err}",
worktree_path.display(),
));
AutoReviewIndicatorStatus::Failed
} else if has_findings {
developer_note = Some(format!(
"[developer] Merge the worktree '{branch}' to apply the auto-review fixes. Worktree path: {}.{snapshot_note}{agent_note}",
worktree_path.display()
));
let mut note = format!(
"[developer] Background auto-review completed and reported {findings} issue(s).\n\nA separate LLM ran /review (and may have run auto-resolve) in an isolated git worktree. Any proposed fixes live only in that worktree until you merge them.\n\nNext: Decide if the findings are genuine. If yes, Merge the worktree '{branch}' to apply the changes (or cherry-pick selectively). If not, do not merge.\n\nWorktree path: {}\n{snapshot_note}\n{agent_note}",
worktree_path.display(),
);
if let Some(summary_note) = summary_note {
note.push('\n');
note.push_str(&summary_note);
}
developer_note = Some(note);
AutoReviewIndicatorStatus::Fixed
} else {
AutoReviewIndicatorStatus::Clean
@@ -32416,10 +32434,7 @@ impl ChatWidget<'_> {
// Immediately inject as a developer message so the user sees it in the
// transcript, even if tasks/streams are still running. Do not defer to
// pending_agent_notes; that path can be lost if the session ends.
self.submit_hidden_text_message_with_preface(
"Auto review follow-up".to_string(),
note,
);
self.submit_hidden_text_message_with_preface(String::new(), note);
}
// Auto review completion should never leave the composer spinner active.