100 Commits
Author SHA1 Message Date
Sagar VoraandGitHub 205443a9e0 Merge pull request #47016 from barredterra/employee-user-perms 2025-04-14 10:27:19 +05:30
Sagar VoraandGitHub 4ef5f6a392 Merge pull request #46870 from sagarvora/perf-validate
perf: reduce query when validating any doc
2025-04-05 23:38:30 +05:30
Sagar Vora b863296e53 perf: reduce query when validating any doc 2025-04-05 23:06:52 +05:30
Sagar VoraandGitHub db0c5ae48d Merge pull request #46829 from vishakhdesai/gt-diff
fix: use `grand_total_diff` instead of `rounding_adjustment` in `taxes_and_totals`
2025-04-01 13:30:48 +05:30
Sagar VoraandGitHub d35a533d8b Merge pull request #46669 from vishakhdesai/bank-clearance-fix
fix: don't filter payment entries on Bank Account in Payment Clearance
2025-03-24 17:49:02 +05:30
Sagar VoraandGitHub e5fdbeefc3 Merge pull request #46536 from sagarvora/remove-init
chore: remove unnecessary init method
2025-03-15 11:55:36 +05:30
Sagar Vora 52ef4f38fe chore: remove unnecessary init method 2025-03-15 11:41:40 +05:30
Sagar VoraandGitHub dd8956a3cf Merge pull request #46531 from sagarvora/perf/mariadb-2
ci: use `mysqlclient` in tests
2025-03-15 10:01:22 +05:30
Sagar Vora 25623325ce ci: use mysqlclient in tests 2025-03-15 09:48:40 +05:30
Sagar VoraandGitHub 70aa9e5f50 Merge pull request #46533 from sagarvora/fix-dupl-se
fix: exclude current doc when checking for duplicate
2025-03-15 00:06:33 +05:30
Sagar Vora d8ef5e4d58 fix: exclude current doc when checking for duplicate 2025-03-14 23:51:30 +05:30
Sagar VoraandGitHub 453bcd7513 Merge pull request #46177 from vishakhdesai/payment-entry-fix 2025-02-28 10:42:26 +05:30
Sagar Voraandruthra kumar 84e0b41c4f fix: ensure multiple PCVs in same fiscal year are considered in patch 2025-01-17 16:44:06 +05:30
7cc111f790 fix: set correct unallocated amount in Payment Entry (#43958)
* fix: set correct unallocated amount in Payment Entry

* fix: add checkbox and other logic fix

* fix: patch to set is_exchange_gain_loss in Payment Entry deductions

* fix: consider deductions except exch. gain/loss

* fix: set exchange gain loss in payment entry

* fix: separate function to set exchange gain loss

* fix: failing test cases

* fix: add cash disc. row first

* fix: review changes

* fix: changes as per review

* fix: failing test cases

* fix: review

* fix: wait for request to complete before updating exchange gain loss

* fix: review

---------

Co-authored-by: vishakhdesai <[email protected]>
Co-authored-by: ruthra kumar <[email protected]>
2024-12-02 14:54:29 +05:30
Sagar VoraandGitHub 279dcabf38 Merge pull request #44443 from sagarvora/minor-perfs
perf: reduce queries during transaction save
2024-11-30 00:45:46 +05:30
Sagar VoraandGitHub 9ee4f58e1b Merge pull request #44439 from Abdeali099/translation-bug
fix: added fieldname to avoid fieldname to translate
2024-11-30 00:24:53 +05:30
Sagar Vora b6b8a06fda perf: reduce queries during transaction save 2024-11-30 00:20:18 +05:30
Sagar VoraandGitHub 6de7320ef4 perf: cache product bundle items at document level (#44440) 2024-11-29 17:21:32 +00:00
Sagar VoraandGitHub 77aabce95e Merge pull request #43993 from sagarvora/fix-m00 2024-11-06 14:06:28 +05:30
Sagar Vora e13e688987 fix: ensure list has items 2024-11-06 14:04:30 +05:30
Sagar VoraandGitHub c62596b323 fix: error when saving POS merge log (#43989) 2024-11-06 07:51:19 +00:00
Sagar VoraandGitHub 7d4b73eacc Merge pull request #43475 from sagarvora/set-margin-values
fix: set margin fields for purchase documents when updating items
2024-10-02 15:20:58 +05:30
Sagar VoraandGitHub 7bc51d7d30 Merge pull request #43481 from sagarvora/ces-patch 2024-10-02 15:12:03 +05:30
Sagar Vora c5889c5d2e fix: patch to update Currency Exchange Settings for frankfurter.app 2024-10-02 15:10:19 +05:30
Sagar VoraandGitHub 70a7d1b75d Merge pull request #43476 from cogk/fix-api-endpoint-for-frankfurter 2024-10-02 14:40:55 +05:30
Sagar Vora c444de017a test: update test for API change 2024-10-02 14:28:54 +05:30
Sagar Vora 7be4d56be2 fix: set margin fields for purchase documents when updating items 2024-10-02 13:14:30 +05:30
Sagar VoraandGitHub 941177ed62 Merge pull request #43171 from vishakhdesai/payment-entry-bug-fix 2024-09-12 12:01:31 +05:30
Sagar Vora 8431e3c275 fix: ensure SellingController.onload gets called for SO & DN 2024-08-19 08:16:11 +05:30
Sagar Vora 97f02015c2 fix: Multiple fixes for General Ledger Report 2024-07-02 17:38:40 +05:30
Sagar VoraandGitHub ac6d85aed6 perf: dont run queries unnecessarily, improved filters (#41993)
* perf: dont run queries unnecessarily, improved filters

* perf: dont run query if `in` filter is empty
2024-06-22 21:27:00 +05:30
Sagar VoraandGitHub b6a7549407 fix: use predefined onload property load_after_mapping (#38209) 2023-12-02 20:06:19 +05:30
Sagar VoraandGitHub 5a53a4b044 fix: make parameters of create_subscription_process optional (and other minor fixes) (#38360) 2023-11-27 20:21:19 +05:30
Sagar VoraandGitHub 56e92b702c Merge pull request #38167 from vishakhdesai/perm-check-fix 2023-11-18 17:37:34 +05:30
Sagar Vora 1b853857aa chore: remove unused variable job 2023-09-06 14:14:22 +05:30
Sagar Vora 4205f564a0 fix(regional): set frappe.flags.company temporarily, where required 2023-07-24 18:37:58 +05:30
Sagar VoraandGitHub 3b246fd7e6 Merge pull request #36163 from resilient-tech/consistent-quotes 2023-07-17 15:46:40 +05:30
Sagar Vora bccb718cc2 chore: use consistent quotes 2023-07-17 15:45:36 +05:30
Sagar VoraandGitHub 30e4052a76 feat(accounts): standardize additional columns implementation for sales/purchase reports (#36000) 2023-07-04 17:41:30 +05:30
Sagar VoraandGitHub 1287ee65b5 Merge pull request #35500 from resilient-tech/remove-wl 2023-05-31 14:44:59 +05:30
Sagar Vora 517d8a03ec chore: remove whitelisting for method not accessed from UI 2023-05-31 14:39:03 +05:30
Sagar VoraandGitHub 83a4c6dda8 Merge pull request #34738 from resilient-tech/regional++ 2023-04-20 05:17:57 -07:00
Sagar Vora 776b56ccd1 fix: use functools.wraps to preserve doc signature 2023-04-20 05:17:30 -07:00
Sagar Vora 2fa641f86d fix: simplify erpnext.get_region 2023-04-20 05:17:30 -07:00
Sagar Vora 17ef3c964f fix: set frappe.flags.company to call regional code accurately 2023-04-20 05:17:30 -07:00
Sagar Vora 9c66ebb108 chore!: remove override to set item tax based on HSN code 2023-04-04 18:02:55 +05:30
Sagar VoraandGitHub 5c06620f97 fix: set tax category from address before executing get_regional_address_details (#34372) 2023-03-13 19:32:50 +05:30
Sagar VoraandGitHub 7e592fdf91 Merge pull request #33831 from dj12djdjs/perf-update-items
perf: show update items dialog
2023-01-27 04:17:39 +00:00
Sagar VoraandGitHub 41222659a6 Merge pull request #33813 from frappe/revert-33810-fix-quality-inspection-item-query
Revert "fix: use correct filter name in reports"
2023-01-25 10:50:03 +00:00
Sagar VoraandGitHub 1f4fa90072 Revert "fix: use correct filter name in reports" 2023-01-25 16:19:44 +05:30
Sagar VoraandGitHub 9989ccbb02 Merge branch 'develop' into fix-appointment-booking 2022-12-16 10:36:48 +00:00
Sagar Vora 48413b0778 fix: reduce function call 2022-11-18 02:22:43 +05:30
Sagar Vora 66ac65482d fix: add missing comma 2022-11-18 02:16:56 +05:30
Sagar Vora 8ae58ed427 fix: use doc_before_save and other changes 2022-11-18 02:13:16 +05:30
Sagar Vora b06345af46 fix: check type for reference name 2022-11-13 19:58:49 +05:30
Sagar Vora 57038c3969 fix: set stock UOM in args to ensure item price is fetched 2022-11-09 18:56:09 +05:30
Sagar Vora 875ff15109 test: dont create lead manually, add coverage for notes 2022-09-02 18:30:39 +05:30
Sagar Vora 58e553151e fix(Appointment): create lead notes as child table 2022-09-02 12:42:37 +00:00
Sagar VoraandAnkush Menat 2e9f531e2c chore(deps): specify PyPNG as a dependency 2022-09-01 11:54:08 +05:30
Sagar VoraandGitHub aafb735283 perf: use create_custom_fields (#31853)
* perf: use `create_custom_fields`

* fix: default must be a string
2022-08-18 21:01:20 +05:30
Sagar VoraandGitHub a2252c9236 ci: ensure unique group ID to prevent workflows from getting cancelled (#31806)
ci: ensure unique group ID to prevent workflows from cancelling
2022-08-09 17:19:48 +05:30
Sagar Vora d05082987f fix: set company_address for purchases in party.js 2022-08-08 06:04:10 +00:00
Sagar Vora a3625b3817 fix: set billing_address for purchases in get_party_details 2022-08-08 06:04:10 +00:00
Sagar VoraandGitHub 9baa222976 fix: specify allowed doctype in queries (#31761) 2022-08-03 11:12:30 +05:30
Sagar Vora c6fbb7b27d Revert "docs: improve README"
This reverts commit 38e71b0639.
2022-07-26 13:09:46 +05:30
Sagar VoraandGitHub 38e71b0639 docs: improve README 2022-07-26 13:08:39 +05:30
Sagar VoraandGitHub bf2833b8ee fix: ensure defaults removed in bad frappe patch get set again (#31659) 2022-07-21 13:32:03 +05:30
Sagar Vora 70c4117c22 fix: unlink custom fields in patch 2022-07-14 15:02:37 +05:30
Sagar Vora be4a44fccd Merge remote-tracking branch 'upstream/develop' into ic-lingering-code 2022-07-14 14:36:14 +05:30
Sagar Vora 93f87cb6e2 chore: remove missed code for India localisation 2022-07-07 16:41:41 +05:30
Sagar Vora 05351bee8b Merge remote-tracking branch 'upstream/develop' into remove-india 2022-07-03 18:07:44 +05:30
Sagar Vora 0aafc75c90 fix: add missing print format 2022-06-26 18:36:00 +05:30
Sagar Vora 85c4c342d8 fix: improve patches 2022-06-26 18:30:54 +05:30
Sagar Vora 7f390fb755 Merge branch 'develop' into remove-india 2022-06-26 18:10:44 +05:30
Sagar Vora b6133c300e test: create TDS payable account 2022-06-24 16:46:52 +05:30
Sagar Vora 4a2a02286a test: create tax withholding category instead of updating 2022-06-24 15:49:19 +05:30
Sagar Vora 69ff61c838 fix: add Lower Deduction Certificate to the Accounting workspace for now 2022-06-24 15:12:43 +05:30
Sagar Vora 9b057d15b2 fix: move hooks to reduce diff 2022-06-24 15:04:28 +05:30
Sagar Vora 593147d337 test: move code to ensure fixtures get created 2022-06-24 14:37:11 +05:30
Sagar Vora 2e6919b7be fix: remove more India patches 2022-06-24 14:14:12 +05:30
Sagar Vora ff10f557c0 test: use Sales Expenses instead of VAT to test disabled account 2022-06-24 13:49:20 +05:30
Sagar Vora 12b7e14fde chore: keep back code to be a part of other apps / to be ported later 2022-06-24 13:38:13 +05:30
Sagar Vora 0810674c8a Merge remote-tracking branch 'upstream/develop' into remove-india 2022-06-24 13:08:40 +05:30
Sagar Vora e48a8cd1e8 fix: remove india hook 2022-06-19 23:20:28 +05:30
Sagar Vora 33b54c50ea chore: remove ITC patch 2022-06-19 23:18:04 +05:30
Sagar Vora ec9861266e Merge remote-tracking branch 'upstream/develop' into remove-india 2022-06-19 22:57:22 +05:30
Sagar VoraandGitHub 1a3997a566 fix: transaction date gets unset in material request (#31327)
* fix: set date correctly in material request

* fix: use only `transaction_date` in `get_item_details`
2022-06-16 22:33:47 +05:30
Sagar VoraandGitHub d87dcb756b Merge pull request #31323 from alyf-de/remove-datev-from-accounting-workspace
fix: remove DATEV from accounting workspace
2022-06-11 10:55:31 +00:00
Sagar VoraandGitHub 26abfd4d7c Merge pull request #30634 from resilient-tech/fix-mutable-reassignment
fix: dont reassign mutable (list) to a different field
2022-04-07 17:24:52 +05:30
Sagar Vora 3b4754f3f6 fix: define tax_columns below consistency 2022-04-07 17:01:10 +05:30
Sagar Vora fa4f57f470 fix: dont reassign mutable (list) to a different field 2022-04-07 16:51:27 +05:30
Sagar Vora 7bece37918 fix: update get_cached_value usage based on changes in definition 2022-03-30 15:35:56 +05:30
Sagar VoraandGitHub 77c36f6d22 fix: set options for Currency field Incoming Rate (#30384) 2022-03-28 17:55:23 +05:30
Sagar Vora ceccacac1f fix: restore inadvertently deleted patches 2022-03-17 13:43:13 +05:30
Sagar Vora 3d45f3a6a8 Merge remote-tracking branch 'upstream/develop' into remove-india 2022-03-03 10:20:50 +05:30
Sagar Vora 89368ece41 style: use f-string 2022-03-02 12:40:25 +05:30
Sagar Vora 98f26e9cbb fix: handle ImportError when installing country fixtures 2022-03-02 12:39:00 +05:30
Sagar Vora b90a134d91 fix: remove patches 2022-02-25 11:36:18 +05:30
Sagar Vora 5159e2e6c5 refactor: remove India specific code 2022-02-25 11:36:18 +05:30
Sagar Vora 3936d8b70e refactor: remove India specific code 2022-02-20 11:48:04 +05:30