hanzoai/esbuild
2
0
Fork 0
mirror of https://github.com/hanzoai/esbuild.git synced 2026-09-24 16:58:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

also add test case from #4075

Browse Source
This commit is contained in:
Evan Wallace
2025-03-09 17:58:09 -04:00
parent 2f244c085a
commit 9ca03f6ea8
2 changed files with 44 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
CHANGELOG.md
+1 -1
View File
@@ -2,7 +2,7 @@
## Unreleased
* Fix incorrect paths in inline source maps ([#4070](https://github.com/evanw/esbuild/issues/4070), [#4105](https://github.com/evanw/esbuild/issues/4105))
* Fix incorrect paths in inline source maps ([#4070](https://github.com/evanw/esbuild/issues/4070), [#4075](https://github.com/evanw/esbuild/issues/4075), [#4105](https://github.com/evanw/esbuild/issues/4105))
This fixes a regression from version 0.25.0 where esbuild didn't correctly resolve relative paths contained within source maps in inline `sourceMappingURL` data URLs. The paths were incorrectly being passed through as-is instead of being resolved relative to the source file containing the `sourceMappingURL` comment, which was due to the data URL not being a file URL. This regression has been fixed, and this case now has test coverage.
scripts/verify-source-map.js
+43
View File
@@ -573,6 +573,43 @@ const toSearchNestedFoldersIssue4070 = {
'bar': 'src/app/app.config.js',
}
const testCaseAbsolutePathIssue4075 = {
'entry.css': `
@import "./styles.css";
@import "./styles2.css";
`,
'styles.css': `/* You can add global styles to this file, and also import other style files */
* {
content: "foo";
}
/*# sourceMappingURL=data:application/json;charset=utf-8,%7B%22version%22:3,` +
`%22sourceRoot%22:%22%22,%22sources%22:%5B%22file:///out/src/styles.scss` +
`%22%5D,%22names%22:%5B%5D,%22mappings%22:%22AAAA;AACA;EACE,SAAS%22,%22f` +
`ile%22:%22out%22,%22sourcesContent%22:%5B%22/*%20You%20can%20add%20glob` +
`al%20styles%20to%20this%20file,%20and%20also%20import%20other%20style%2` +
`0files%20%2A/%5Cn*%20%7B%5Cn%20%20content:%20%5C%22foo%5C%22%5Cn%7D%5Cn` +
`%22%5D%7D */`,
'styles2.css': `/* You can add global styles to this file, and also import other style files */
* {
content: "bar";
}
/*# sourceMappingURL=data:application/json;charset=utf-8,%7B%22version%22:3,` +
`%22sourceRoot%22:%22%22,%22sources%22:%5B%22/out/src/styles2.scss%22%5D` +
`,%22names%22:%5B%5D,%22mappings%22:%22AAAA;AACA;EACE,SAAS%22,%22file%22` +
`:%22out%22,%22sourcesContent%22:%5B%22/*%20You%20can%20add%20global%20s` +
`tyles%20to%20this%20file,%20and%20also%20import%20other%20style%20files` +
`%20%2A/%5Cn*%20%7B%5Cn%20%20content:%20%5C%22bar%5C%22%5Cn%7D%5Cn%22%5D` +
`%7D */
`,
}
const toSearchAbsolutePathIssue4075 = {
foo: path.relative(path.join(testDir, '(this test)'), '/out/src/styles.scss'),
bar: path.relative(path.join(testDir, '(this test)'), '/out/src/styles2.scss'),
}
const testCaseMissingSourcesIssue4104 = {
'entry.js': `import { bootstrapApplication } from '@angular/platform-browser';
import { AppComponent } from './app.js';
@@ -1091,6 +1128,12 @@ async function main() {
entryPoints: ['src/main.js'],
crlf,
}),
check('issue-4075' + suffix, testCaseAbsolutePathIssue4075, toSearchAbsolutePathIssue4075, {
outfile: 'out.css',
flags: flags.concat('--bundle'),
entryPoints: ['entry.css'],
crlf,
}),
check('issue-4080' + suffix, testCaseNullMappingIssue4080, toSearchNullMappingIssue4080, {
outfile: 'out.js',
flags: flags.concat('--bundle', '--format=esm'),