hanzoai/esbuild
2
0
Fork 0
mirror of https://github.com/hanzoai/esbuild.git synced 2026-09-24 16:58:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

release notes for #4506

Browse Source
This commit is contained in:
Evan Wallace
2026-08-07 21:19:48 -04:00
parent 5e52b56fc7
commit a7cce5f3c8
3 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
CHANGELOG.md
+8
View File
@@ -25,6 +25,14 @@
}
```
* Fix a potential deadlock when the JavaScript API is used incorrectly ([#4503](https://github.com/evanw/esbuild/issues/4503), [#4506](https://github.com/evanw/esbuild/pull/4506))
The JavaScript API runs the native esbuild executable as a long-lived child process and communicates with it over stdin/stdout/stderr. Each API request is asynchronous and the executable stays open as long as it has work to do, which is as long as either stdin is still open (meaning there may be more API requests) or there are currently requests being processed.
Previously esbuild's tracking of outstanding API requests missed decrementing a reference count in an edge case where esbuild's JavaScript API was used incorrectly and the API request returned an error. This could in some cases cause esbuild's native executable to exit with an error message about a deadlock. This release fixes the reference counting bug.
This fix was submitted by [@ZuBB](https://github.com/ZuBB).
* Handle target collisions ([#4509](https://github.com/evanw/esbuild/issues/4509))
It's possible to specify the same target engine multiple times, such as with `--target=chrome1,chrome99`. This edge case wasn't anticipated and previously took the last version for the duplicated target engine instead of the minimum version (so `chrome99` in this case instead of `chrome1`). With this release, esbuild will now pick the minimum version between all duplicated target engines.
Makefile
+1 -1
View File
@@ -47,7 +47,7 @@ check-go-version:
# variable like this: "ESBUILD_RACE=-race make test". Or you can permanently
# enable it by adding "export ESBUILD_RACE=-race" to your shell profile.
test-go:
go test $(ESBUILD_RACE) ./internal/... ./pkg/...
go test $(ESBUILD_RACE) ./cmd/... ./internal/... ./pkg/...
vet-go:
go vet ./cmd/... ./internal/... ./pkg/...
cmd/esbuild/service.go
+2 -2
View File
@@ -64,7 +64,7 @@ func (service *serviceType) createActiveBuild(key int) *activeBuild {
activeBuild := &activeBuild{}
service.activeBuilds[key] = activeBuild
// This pairs with "Done()" in "decRefCount"
// This pairs with "Done()" in "destroyActiveBuild"
service.keepAliveWaitGroup.Add(1)
return activeBuild
}
@@ -77,7 +77,7 @@ func (service *serviceType) destroyActiveBuild(key int) {
delete(service.activeBuilds, key)
service.mutex.Unlock()
// This pairs with "Add()" in "trackActiveBuild"
// This pairs with "Add()" in "createActiveBuild"
service.keepAliveWaitGroup.Done()
}