hanzoai/esbuild
2
0
Fork 0
mirror of https://github.com/hanzoai/esbuild.git synced 2026-09-24 16:58:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix #4497: preserve nested ampersands during minification (#4500)

Browse Source
This commit is contained in:
Geonho
2026-08-08 12:35:05 -04:00
committed by GitHub
parent 34474e2785
commit c625d31bf0
2 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/css_parser/css_parser_selector.go
+4 -1
View File
@@ -252,8 +252,11 @@ const (
func analyzeLeadingAmpersand(sel css_ast.ComplexSelector, isDeclarationContext bool) leadingAmpersand {
if len(sel.Selectors) > 1 {
if first := sel.Selectors[0]; first.IsSingleAmpersand() {
if second := sel.Selectors[1]; second.Combinator.Byte == 0 && len(second.NestingSelectorLocs) > 0 {
second := sel.Selectors[1]
rest := css_ast.ComplexSelector{Selectors: sel.Selectors[1:]}
if second.Combinator.Byte == 0 && rest.ContainsNestingCombinator() {
// ".foo { & &.bar {} }" => ".foo { & &.bar {} }"
// ".foo { & .bar:not(& .baz) {} }" => ".foo { & .bar:not(& .baz) {} }"
} else if second.Combinator.Byte != 0 || second.TypeSelector == nil || !isDeclarationContext {
// "& + div {}" => "+ div {}"
// "& div {}" => "div {}"
internal/css_parser/css_parser_test.go
+3
View File
@@ -1137,6 +1137,9 @@ func TestNestedSelector(t *testing.T) {
expectPrintedMangle(t, "a { @media screen { & div { color: red } } }", "a {\n @media screen {\n & div {\n color: red;\n }\n }\n}\n", "")
expectPrintedMangle(t, "a { :has(& b) { color: red } }", "a {\n :has(& b) {\n color: red;\n }\n}\n", "")
expectPrintedMangle(t, "a { :has(& + b) { color: red } }", "a {\n :has(& + b) {\n color: red;\n }\n}\n", "")
expectPrintedMangle(t, "a { & .b:not(& .c) { color: red } }", "a {\n & .b:not(& .c) {\n color: red;\n }\n}\n", "")
expectPrintedMangle(t, "a { & .b:is(.c &) { color: red } }", "a {\n & .b:is(.c &) {\n color: red;\n }\n}\n", "")
expectPrintedMangle(t, "a { & + .b:not(& .c) { color: red } }", "a {\n + .b:not(& .c) {\n color: red;\n }\n}\n", "")
// Reorder selectors to enable removing "&"
expectPrintedMangle(t, "reorder { & first, .second { color: red } }", "reorder {\n .second,\n first {\n color: red;\n }\n}\n", "")