hanzoai/expr
2
0
Fork 0
mirror of https://github.com/hanzoai/expr.git synced 2026-09-24 16:58:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove redundant check

Browse Source
This commit is contained in:
Anton Medvedev
2022-11-05 19:43:00 +01:00
parent 75f3a61dad
commit bfeb63ba2b
1 changed files with 9 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
vm/runtime/runtime.go
+9 -11
View File
@@ -77,17 +77,15 @@ func FetchField(from interface{}, field *Field) interface{} {
v = reflect.Indirect(v)
kind = v.Kind()
}
if kind == reflect.Struct {
// We can use v.FieldByIndex here, but it will panic if the field
// is not exists. And we need to recover() to generate a more
// user-friendly error message.
// Also, our fieldByIndex() function is slightly faster than the
// v.FieldByIndex() function as we don't need to verify what a field
// is a struct as we already did it on compilation step.
value := fieldByIndex(v, field.Index)
if value.IsValid() {
return value.Interface()
}
// We can use v.FieldByIndex here, but it will panic if the field
// is not exists. And we need to recover() to generate a more
// user-friendly error message.
// Also, our fieldByIndex() function is slightly faster than the
// v.FieldByIndex() function as we don't need to verify what a field
// is a struct as we already did it on compilation step.
value := fieldByIndex(v, field.Index)
if value.IsValid() {
return value.Interface()
}
}
panic(fmt.Sprintf("cannot get %v from %T", field.Path, from))