mirror of
https://github.com/hanzoai/firebase-js-sdk.git
synced 2026-09-24 16:59:10 +00:00
Enable previously failing (Firestore) Node.js and Browser (Chrome) Tests (#8067)
A Firestore CI test configuration was previously disabled in our GitHub action Workflows due to a 100% failure rate. While revisiting this issue months later, it seems that the test now passes. This might be related to our Node v20 CI upgrade. As a bonus, fixed a comment typo in the check changeset script.
This commit is contained in:
@@ -161,9 +161,6 @@ jobs:
|
||||
name: (Firestore) Node.js and Browser (Chrome) Tests
|
||||
needs: build
|
||||
runs-on: ubuntu-latest
|
||||
if: false
|
||||
# Disable test for now since it's failing 100% of the time since
|
||||
# https://github.com/firebase/firebase-js-sdk/pull/7453 and it needs to be investigated.
|
||||
steps:
|
||||
# install Chrome so the correct version of webdriver can be installed by chromedriver when setting up the repo
|
||||
- name: install Chrome stable
|
||||
|
||||
@@ -46,7 +46,7 @@ const bumpRank: Record<string, number> = {
|
||||
|
||||
/**
|
||||
* Get highest bump that isn't the main firebase package, return
|
||||
// numerical rank, bump text, package name.
|
||||
* numerical rank, bump text, package name.
|
||||
*/
|
||||
function getHighestBump(changesetPackages: Record<string, string>) {
|
||||
const firebasePkgJson = require(resolve(
|
||||
|
||||
Reference in New Issue
Block a user