Replace "any" types (#661)

This commit is contained in:
Mertcan Mermerkaya
2018-04-10 22:51:30 +01:00
committed by GitHub
parent 14896fb83b
commit a4359a508d
+19 -15
View File
@@ -34,6 +34,10 @@ export interface IIDDetails {
}
// tslint:enable interface-name
interface ApiResponse extends Partial<IIDDetails> {
error?: { message: string };
}
export class IIDModel {
private readonly errorFactory_: ErrorFactory<string>;
@@ -69,7 +73,7 @@ export class IIDModel {
body: fcmSubscribeBody
};
let responseData: any = null;
let responseData: ApiResponse;
try {
const response = await fetch(
ENDPOINT + '/fcm/connect/subscribe',
@@ -81,24 +85,24 @@ export class IIDModel {
throw this.errorFactory_.create(ERROR_CODES.TOKEN_SUBSCRIBE_FAILED);
}
if (responseData['error']) {
const message = responseData['error']['message'];
if (responseData.error) {
const message = responseData.error.message;
throw this.errorFactory_.create(ERROR_CODES.TOKEN_SUBSCRIBE_FAILED, {
message: message
});
}
if (!responseData['token']) {
if (!responseData.token) {
throw this.errorFactory_.create(ERROR_CODES.TOKEN_SUBSCRIBE_NO_TOKEN);
}
if (!responseData['pushSet']) {
if (!responseData.pushSet) {
throw this.errorFactory_.create(ERROR_CODES.TOKEN_SUBSCRIBE_NO_PUSH_SET);
}
return {
token: responseData['token'],
pushSet: responseData['pushSet']
token: responseData.token,
pushSet: responseData.pushSet
};
}
@@ -137,7 +141,7 @@ export class IIDModel {
body: fcmUpdateBody
};
let responseData: any = null;
let responseData: ApiResponse;
try {
const response = await fetch(
ENDPOINT + '/fcm/connect/subscribe',
@@ -148,18 +152,18 @@ export class IIDModel {
throw this.errorFactory_.create(ERROR_CODES.TOKEN_UPDATE_FAILED);
}
if (responseData['error']) {
const message = responseData['error']['message'];
if (responseData.error) {
const message = responseData.error.message;
throw this.errorFactory_.create(ERROR_CODES.TOKEN_UPDATE_FAILED, {
message: message
});
}
if (!responseData['token']) {
if (!responseData.token) {
throw this.errorFactory_.create(ERROR_CODES.TOKEN_UPDATE_NO_TOKEN);
}
return responseData['token'];
return responseData.token;
}
/**
@@ -189,9 +193,9 @@ export class IIDModel {
ENDPOINT + '/fcm/connect/unsubscribe',
unsubscribeOptions
);
const responseData = await response.json();
if (responseData['error']) {
const message = responseData['error']['message'];
const responseData: ApiResponse = await response.json();
if (responseData.error) {
const message = responseData.error.message;
throw this.errorFactory_.create(ERROR_CODES.TOKEN_UNSUBSCRIBE_FAILED, {
message: message
});