Kris and GitHub
9ed2f4a7d9
UX: remove main-outlet-wrapper margin reset for mobile ( #31286 )
...
Reported here
https://meta.discourse.org/t/do-auto-margins-still-need-to-be-unset-on-mobile/351503
This helps better handle some situations where we want to center content
on large screens while using mobile view
2025-02-11 16:16:26 -05:00
Kris and GitHub
3340b57b4f
DEV: use custom trigger for sidebar more section ( #31285 )
...
This uses the new `triggerComponent` functionality to implement a button
without the default `DButton` component classes, which helps themes
avoid applying unintentional styling.
2025-02-11 15:46:37 -05:00
Kris and GitHub
d388fa4a69
DEV: add transformer for default category view setting ( #31264 )
...
This allows us to set custom values here, like "Voting" from the topic
voting plugin:
https://github.com/discourse/discourse-topic-voting/pull/232
2025-02-10 16:48:11 -05:00
Kris and GitHub
03c0513cb1
UX: fix horizontal group nav on mobile ( #31259 )
...
This fixes the "all groups" link on mobile, follow-up to b1fbfdchttps://github.com/user-attachments/assets/c6044ee6-3740-47a7-a006-239980bd7605 )
After
2025-02-10 11:43:00 -05:00
Kris and GitHub
b1fbfdcd7f
UX: switch group pages to horizontal nav ( #31243 )
...
This gets group pages on the same horizontal nav patterns as the user
profile pages. These pages need some more adjustments in general, but
this is a good start!
Before:
After:
Before:
<img
src="https://github.com/user-attachments/assets/b58f1994-8ef8-4a67-9b37-bfee428c343b "
width="350" />
After:
<img
src="https://github.com/user-attachments/assets/013b1af6-ddb9-4a93-bcfe-37b2a9760d8b "
width="350" />
2025-02-10 10:38:31 -05:00
Kris and GitHub
2ac6846e7f
FIX: Correct typo in property name for save button component ( #31221 )
...
`disabled` -> `disable` to match:
https://github.com/discourse/discourse/blob/e9522fdd037a54b0146eb3481c076f180dcdd09c/app/assets/javascripts/discourse/app/components/composer-container.hbs#L238
2025-02-06 14:24:09 -05:00
Kris and GitHub
9c422fc0bc
DEV: add topic-footer-button class to all topic footer buttons ( #31209 )
...
While working with some themes, I noticed that all of these buttons
don't have the `topic-footer-button` class, so it can't really be used
effectively. The admin menu, bookmark button, and reply button were all
missing it. This adds the class.
2025-02-06 12:23:47 -05:00
Kris and GitHub
385abf622e
DEV: Fix syntax for outletArgs in header component ( #31220 )
...
The parenthesis were causing minimized to return undefined
2025-02-06 11:32:33 -05:00
Kris and GitHub
a946c49592
UX: fix layout of invite modal errors ( #31199 )
...
Flex is causing odd wrapping for errors with multiple elements within.
Before:
After:
2025-02-05 13:33:52 -05:00
Kris and GitHub
64fe464145
UX: left-align dropdown menu button text ( #31198 )
...
When dropdown button text wraps onto multiple lines, it's centered. It
should be left-aligned instead.
Before:
<img
src="https://github.com/user-attachments/assets/64db1e0c-8dc0-4e26-8b07-fea938498f80 "
width="250"/>
After:
<img
src="https://github.com/user-attachments/assets/7f4c1795-291a-4772-bdb0-f848f3904aa4 "
width="250"/>
2025-02-05 12:43:13 -05:00
Kris and GitHub
50f41c7255
UX: fix wrapping of topic map links with counter ( #31184 )
...
Due to a change with how the link counter renders (as a pseudo element)
the grid layout in the topic map link modal regressed slightly with long
links
before:
after:
<img
src="https://github.com/user-attachments/assets/1c955593-beae-4795-9d90-9a50fd7646dd "
width="500">
2025-02-05 08:28:22 -05:00
Kris and GitHub
8375262ea8
A11Y: fix post control button contrast issue for WCAG colors ( #31177 )
...
We had a little regression here:
Before:
After:
Upon closer inspection, a lot of the post control styles here are no
longer necessary, as the contrast is fine without them:
2025-02-04 15:17:29 -05:00
Kris and GitHub
c2a0af8a7d
UX: ensure all children of .with-topic-progress are clickable ( #31176 )
...
This is a follow-up to 34036162c5
2025-02-04 14:51:54 -05:00
Kris and GitHub
853f6fb1d3
UX: prevent topic map link menu from overflowing when there are many links ( #31147 )
...
Before (overflows, can't reach bottom):
<img
src="https://github.com/user-attachments/assets/fd3cf28a-9735-452e-82ca-8415da9fd66f "
height="500">
After (max-height clipped, can scroll contents):
<img
src="https://github.com/user-attachments/assets/3b26bf84-a535-4931-9406-6a3354b76534 "
height="500">
2025-02-03 18:02:41 -05:00
Kris and GitHub
34036162c5
UX: unblock clicking through progress bar wrapper ( #31135 )
...
Reported here:
https://meta.discourse.org/t/topic-navigation-toggle-prevents-interactions-on-the-page-in-a-certain-area/350073
The purple wrapper shown here prevents elements underneath it from being
clicked/tapped, this can sometimes interfere with post controls
The fix is to disable pointer events on the wrapping element, so clicks
pass through. Then clicks are re-enabled on the child element.
2025-02-03 13:18:28 -05:00
Kris and GitHub
6f74443a34
UX: fix topic progress position when composer is open ( #31134 )
...
I'm not sure what the original intention was @ZogStriP, but it seems
this causes a lot of overflow...
Before:
After:
2025-02-03 12:40:18 -05:00
Kris and GitHub
4cece0a5eb
UX: update system font stack to system-ui ( #31125 )
...
support for the `system-ui` value is widely available now, so we can
drop the device specific values:
https://highperformancewebfonts.com/read/ditch-BlinkMacSystemFont-and-apple-system
https://caniuse.com/?search=system-ui
2025-02-03 11:28:17 -05:00
Kris and GitHub
fa8a46fc35
UX: clean up post action menu styles, fix issues, add variables ( #31100 )
...
Related to
https://meta.discourse.org/t/double-button-inconsistencies-post-menu/349845
This does some general clean up...
* **Moves shared mobile/desktop styles into /common**
We had some mobile hover states for some reason, and desktop hover/focus
states can be moved to common and gated with `.discourse-no-touch`...
this means we're applying them on capabilities rather than device type
* **Adds some `-d-post-control-` variables to make theming easier**
Theme authors can replace the variables without worrying about selector
specificity
* **Removes an overridden fade-out class from likes**
We were overriding the effect here anyway
* **Fixes a janky hover transition effect on the like button**
This was being incorrectly inherited from another button
...and fixes some issues
* **Corrects border radius on double buttons (likes, flags)**
* **Corrects double button height issues for flags**
* **Adjusts the flag count to avoid the lumpy circle CSS problem**
* **Removes lingering post-tap focus/hover states on mobile by applying
`.discourse-no-touch` and `focus-visible`**
Tested both glimmer and legacy.
2025-02-03 09:31:17 -05:00
Kris and GitHub
d9467899bc
DEV: add btn-default classes to buttons using default styling ( #31039 )
...
All of these buttons use our default grey background styling, but aren't
carrying the `btn-default` class, which makes them easier to target in
themes. This PR adds the class.
2025-01-28 15:40:34 -05:00
Kris and GitHub
5ab816b434
UX: add missing class to group bulk select button ( #31038 )
...
This bulk-select button on group pages is styled like a default button,
but lacks the `btn-default` class, making it inconsistent to style in
themes
2025-01-28 14:39:07 -05:00
Kris and GitHub
610d75e649
DEV: add missing class to top replies button ( #31024 )
...
This button in the topic map has our default button styling, but misses
the btn-default class, making it inconsistent in themes
2025-01-28 08:50:39 -05:00
Kris and GitHub
af4a284086
A11Y: fix color issue with delete topic button in WCAG palette ( #31023 )
...
Reported here:
https://meta.discourse.org/t/wcag-high-contrast-color-palettes-for-low-vision/168795/30
Before:
After:
2025-01-27 17:33:14 -05:00
Kris and GitHub
e6a1c0ae5c
UX: sidebar "more" icon color fix ( #31017 )
...
Currently the vertical ellipsis is slightly darker than other sidebar
icons
Before:
After:
2025-01-27 13:47:45 -05:00
728c296d63
UX: hide user card focus until keyboard navigation begins ( #31014 )
...
When the usercard is opened, we manually assign focus to the first link
to capture focus, but this creates an undesirable focus ring for
visitors not relying on focus indicators for navigation.
With this update, the focus is assigned to the container rather than the
first link. This fulfills the goal of capturing focus within the user
card, but hides the focus ring until navigation within the card begins.
`tabindex="-1"` is necessary because this allows us to manually focus
the container (normally unfocusable) while removing it from the tab
order for subsequent navigation.
Before:
After:
then on tab:
---------
Co-authored-by: Penar Musaraj <[email protected]
2025-01-27 12:34:04 -05:00
Kris and GitHub
13c1084e1d
DEV: add missing button classes ( #30997 )
...
While updating a couple of themes I noticed some buttons were missing
`.btn-default`, which resulted in some inconsistent button styling
2025-01-24 16:33:06 -05:00
Kris and GitHub
27c73258f2
UX: fix admin dashboard link and style regressions ( #30969 )
...
Heading link regression reported here:
https://meta.discourse.org/t/admin-panel-reports-in-the-community-health-section-are-no-longer-clickable/347631
Also noticed some style regressions
2025-01-24 10:23:34 +10:00
Kris and GitHub
9531a8e2a8
UX: add HTML class for composer preview to manage sidebar height ( #30956 )
...
This adds the class `composer-has-preview` to the HTML element when the
composer is opened and the preview is visible.
This allows us to adjust the sidebar height, so that the previewless
composer can overlap the sidebar and better utilize the available space.
Before:
After:
2025-01-23 12:41:36 -05:00
Kris and GitHub
33cade53a9
UX: rename "hamburger menu" to "navigation menu" in keyboard help ( #30927 )
...
Reported here:
https://meta.discourse.org/t/open-hamburger-menu-wording/348216
After adding the sidebar, we started calling related settings the
"navigation menu" because it can either be the sidebar or the hamburger
menu (dropdown) — this reflects that change in the keyboard shortcuts
modal as well
Before:
After:
2025-01-22 12:30:36 -05:00
Kris and GitHub
375606f11c
FIX: lint issue follow-up to f8f4d21 ( #30911 )
...
Expected empty line before rule `rule-empty-line-before`
2025-01-21 17:58:27 -05:00
Kris and GitHub
f8f4d215d5
UX: set mobile read state indicator to static size to avoid overflow ( #30910 )
...
This fixes an issue where topics could scroll horizontally on mobile:
https://meta.discourse.org/t/topic-page-layout-issue/348262?u=pmusaraj
It seems some recent core change impacted the read state size/position
This sets the size and position to more static values (not based on
global font changes) to avoid the issue, and removes the horizontal
scroll.
2025-01-21 17:24:58 -05:00
Kris and GitHub
7390cd1821
UX: improve the alignment of long status messages ( #30830 )
...
Before:
After:
Short message layout stays mostly unchanged:
2025-01-16 17:22:37 -05:00
Kris and GitHub
7a74ab365f
A11Y: move heading role to parent tag to fix voice control ( #30796 )
...
The heading role on topic lists is desirable for screenreader users
because they can easily navigate from heading to heading.
Having this role on the link tag directly becomes problematic for Voice
Control users on Apple devices because unfortunately Voice Control
assumes that when given the role of a heading, it is not a link. This
makes it difficult to click.
This PR moves the heading role to the link's wrapper. This change allows
for heading-to-heading navigation for screenreaders, and also makes it
easier to click using Voice Control. The end result is that topic lists
are both navigable for screenreaders and Voice Control users.
2025-01-15 12:53:05 -05:00
Kris and GitHub
a838c72802
UX: remove redundant text-decoration: none, follow up to e51414c ( #30775 )
...
This redundant `text-decoration: none` was getting in the way of showing
a strikethrough on the deleted part of the diff
before ("new strike" at the bottom missing the strikethrough):
after (strikethrough appears correctly):
2025-01-14 16:33:09 -05:00
Kris and GitHub
e51414c7d8
UX: show strikethrough, underline in post edit diff ( #30773 )
...
Reported here:
https://meta.discourse.org/t/strike-through-text-is-not-rendered-in-diff/347101
`text-decoration: none` needs a few exceptions here to avoid stripping
out styling that's present in posts
before (strikethrough and underline stripped):
after:
2025-01-14 15:00:12 -05:00
Kris and GitHub
0c02212235
UX: check category permission before new topic quote ( #30753 )
...
Reported here:
https://meta.discourse.org/t/quoting-a-closed-topic-prefills-category-in-composer-that-should-be-off-limits/260009
Currently, if someone tries to quote a topic they don't have permission
to reply to, we'll open a new topic composer with the quote so they can
"continue the discussion". When doing this, we populate the current
category, even if the user doesn't have permission to post in it.
This is misleading, as when the user attempts to submit their topic they
get an error because they lack the category permissions.
This change checks the category permissions before populating it.
2025-01-14 08:28:16 -05:00
Kris and GitHub
ceb1c9e22a
UX: Switch button focus state to focus-visible ( #30744 )
...
From https://developer.mozilla.org/en-US/docs/Web/CSS/:focus-visible :
> The :focus-visible pseudo-class applies while an element matches the
[:focus](https://developer.mozilla.org/en-US/docs/Web/CSS/:focus )
pseudo-class and the UA ([User
Agent](https://developer.mozilla.org/en-US/docs/Glossary/User_agent ))
determines via heuristics that the focus should be made evident on the
element. (Many browsers show a "focus ring" by default in this case.)
This change switches buttons over to `:focus-visible` which shouldn't
change much, except for situations where focus state may linger in cases
when it's not desired, like the tracking button here for example:
When using `focus-visible` the `focus` state is no longer visible after
a tap, but the focus state will still appear when using keyboard
navigation or assistive technology like VoiceOver, as seen here:
<img
src="https://github.com/user-attachments/assets/62398532-3e05-4979-91a4-d3ddeb4758cb "
width="300" />
2025-01-13 14:05:51 -05:00
Kris and GitHub
38d8bd84ec
UX: improve discobot certificate font language support ( #30722 )
2025-01-10 17:13:24 -05:00
Kris and GitHub
5bb0af5425
Revert "UX: use font with more glyphs for discobot certificates" ( #30681 )
...
This reverts commit 14ee5b9fb6
2025-01-09 18:56:47 -05:00
Kris and GitHub
f42d6ad1bf
UX: follow-up sidebar variable fixes for af61962 ( #30676 )
2025-01-09 15:53:29 -05:00
Kris and GitHub
af619627ff
DEV: fix and improve sidebar CSS variables ( #30673 )
2025-01-09 14:18:05 -05:00
Kris and GitHub
14ee5b9fb6
UX: use font with more glyphs for discobot certificates ( #30646 )
2025-01-08 13:44:09 -05:00
Kris and GitHub
ff3366a65a
UX: adjust mobile to avoid progress bar jitter ( #30591 )
2025-01-06 17:57:24 -05:00
Kris and GitHub
09fdcf06c6
UX: improve table hover states, fix table button margin issue ( #30585 )
2025-01-06 13:59:48 -05:00
Kris and GitHub
01f52d56c5
UX: add missing icon for open_topic small action ( #30586 )
2025-01-06 13:50:58 -05:00
Kris and GitHub
eaf688e23e
UX: only show red count in IP lookup when greater than 0 ( #30584 )
2025-01-06 11:58:12 -05:00
Kris and GitHub
0cf503b024
UX: improve link copy status transition ( #30401 )
2024-12-20 14:12:13 -05:00
Kris and GitHub
4557bcbc7b
UX: refactor IP lookup using DMenu to improve layout and positioning ( #30374 )
2024-12-19 14:49:36 -05:00
Kris and GitHub
c515f33ffe
A11Y: show state change when post anchors are focused ( #30334 )
2024-12-18 09:41:33 -05:00
Kris and GitHub
41533f9dc7
UX: show correct message when creating topics is disabled by a tag ( #30328 )
2024-12-17 15:17:24 -05:00
Kris and GitHub
56e1ba18af
DEV: prioritize new email styles over existing, to make customization easier ( #30244 )
2024-12-12 11:42:50 -05:00
Kris and GitHub
5e3dcdfb1e
UX: fix PM title editing layout ( #30233 )
2024-12-12 09:18:52 +11:00
Kris and GitHub
2cc247b3e6
UX: add header-categories-wrapper outlet ( #30214 )
2024-12-11 11:17:43 -05:00
Kris and GitHub
8b53808ef6
UX: fix admin sidebar header width ( #30226 )
2024-12-11 11:09:27 -05:00
Kris and GitHub
1d2dd5e321
DEV: add transformers to navigation bar for theme dev ( #30190 )
2024-12-09 17:20:45 -05:00
Kris and GitHub
09d1418d4f
DEV: admin-login submit should be a button, not an input ( #30156 )
2024-12-06 11:48:15 -05:00
Kris and GitHub
65a8fa63ae
UX: fix PM topic map layout ( #30135 )
2024-12-06 08:34:54 -05:00
Kris and GitHub
6fb7bc6a55
UX: refactor title editing CSS to improve layout ( #30109 )
2024-12-04 16:30:48 -05:00
Kris and GitHub
cfe04be68e
UX: fix topic map padding in low-content situations ( #30101 )
2024-12-04 09:39:14 -05:00
Kris and GitHub
0720017a15
A11Y: remove redundant alt text from github oneboxes ( #30083 )
2024-12-04 12:25:03 +11:00
Kris and GitHub
70b741e3b7
UX: adjust mobile chat text title alignment ( #30065 )
2024-12-03 14:11:33 -05:00
Kris and GitHub
6fa56dc34f
UX: attempt to reduce jumpy topic scroll in Firefox ( #29941 )
2024-11-26 13:17:06 -05:00
Kris and GitHub
01a506bf82
DEV: add order to posters column so it gets a classname ( #29866 )
2024-11-20 17:09:21 -05:00
Kris and GitHub
b31b130db5
FEATURE: add transformer to pass topic ID to simple invite generation ( #29861 )
2024-11-20 16:08:08 -05:00
Kris and GitHub
c91cdb8ff7
A11Y: make the uppy image uploader keyboard navigable ( #29807 )
2024-11-19 15:38:13 -05:00
Kris and GitHub
d7c6635cd4
A11Y: convert sortable topic list headers to proper buttons ( #29808 )
2024-11-19 15:38:03 -05:00
Kris and GitHub
ba9bc0accb
DEV: remove !important from btn-transparent background ( #29809 )
2024-11-19 09:38:10 +11:00
Kris and GitHub
db4f83bc6c
A11Y: update clickable search dropdown tips to be buttons ( #29762 )
2024-11-14 16:23:43 -05:00
Kris and GitHub
7ea1390346
UX: reduce bottom topic map threshold, with protections ( #29665 )
2024-11-13 07:58:44 -05:00
Kris and GitHub
0b619f4611
UX: lower min_post_count to show bottom topic map ( #29649 )
2024-11-07 20:10:18 -05:00
Kris and GitHub
2fe098f53b
UX: replace broken link SVG with new Font Awesome 6 name ( #29623 )
2024-11-06 13:35:07 -05:00
Kris and GitHub
8ea3b840bb
UX: remove extra margin from PM small actions ( #29571 )
2024-11-04 10:53:35 -05:00
Kris and GitHub
e817df0271
UX: align PM icon when editing title, allow shrink-to-fit ( #29570 )
2024-11-04 10:31:11 -05:00
Kris and GitHub
3ce006f4cb
REVERT: "A11Y: topic list links should not be headings ( #27700 )" ( #29520 )
...
This reverts commit 805e0f3d3e
2024-10-31 12:42:55 -04:00
Kris and GitHub
65b26d9b73
UX: Give ranked choice polls distinctive bullets in preview ( #29439 )
2024-10-28 11:10:37 -04:00
Kris and GitHub
0dad45d36c
UX: limit user-card focus ring to desktop ( #29435 )
2024-10-28 10:10:03 -04:00
Kris and GitHub
0bcd106e9a
A11Y: fix and improve user card accessibility ( #29399 )
2024-10-25 12:43:43 -04:00
Kris and GitHub
094dc1f91b
DEV: add "topic-list-heading-bottom" plugin outlet ( #29377 )
2024-10-23 17:54:31 -04:00
Kris and GitHub
f7af0b2a5f
UX: simplify and shorten new script flow for automations ( #29178 )
2024-10-23 14:04:17 -04:00
Kris and GitHub
50278ca4df
A11Y: add screenreader markup for category color pickers ( #29351 )
2024-10-22 18:38:13 -04:00
Kris and GitHub
4d7c9cb15e
A11Y: Label site setting buttons ( #29348 )
2024-10-22 18:04:42 -04:00
Kris and GitHub
880178e30f
A11Y: add aria-labels to sidebar footer buttons ( #29347 )
2024-10-22 18:04:36 -04:00
Kris and GitHub
632d9b2739
UX: fallback max-height for modal style ( #29321 )
2024-10-21 21:09:29 -04:00
Kris and GitHub
f650549c87
DEV: allow optional modal height vars to be set ( #29315 )
2024-10-21 14:00:28 -04:00
Kris and GitHub
bf805d59b4
DEV: add before and after mobile categories outlet ( #29238 )
2024-10-16 16:30:19 -04:00
Kris and GitHub
21d371da06
DEV: move groups data loading from controller to route ( #29130 )
2024-10-08 15:40:46 -04:00
Kris and GitHub
accdb604ec
A11Y: add aria-label to user profile link in topic list ( #29088 )
2024-10-04 16:02:12 -04:00
Kris and GitHub
75bb41625b
A11Y: announce "link copied!" confirmation for screen readers ( #29058 )
2024-10-02 15:54:38 -04:00
Kris and GitHub
f76652717e
UX: prevent user stream title from overflowing page ( #29032 )
2024-09-30 13:10:23 -04:00
Kris and GitHub
958bb17cdd
UX: Add label for delete own post button in review queue ( #28991 )
2024-09-30 10:35:16 -04:00
Kris and GitHub
7ba3291f52
DEV: add topic-list-after-columns outlet to mobile ( #28963 )
2024-09-18 17:29:42 -04:00
0d3b9f247e
DEV: remap all core icons for fontawesome 6 upgrade ( #28715 )
...
Followup to 30ac4e8bb2[email protected]
2024-09-13 16:50:52 +01:00
Kris and GitHub
8ca64c77fd
UX: tell 1Password to ignore the link name input ( #28559 )
2024-09-12 11:13:43 -04:00
Kris and GitHub
953f6b7aaa
FIX: replace shield-blank with shield-halved for font awesome ( #28804 )
2024-09-09 10:48:09 -04:00
Kris and GitHub
e95398c9cf
UX: remove btn-default class from chat thread tracking dropdown ( #28789 )
2024-09-06 15:14:29 -05:00
Kris and GitHub
22944dd55a
DEV: add below-sidebar-sections to sidebar dropdown mode ( #28780 )
2024-09-06 12:49:18 -04:00
Kris and GitHub
e347f965d9
FIX: don't use post ID as timeline collapse delay ( #28712 )
2024-09-03 14:01:59 -04:00
Kris and GitHub
8ee79700eb
UX: fix spacing in topic map views menu ( #28583 )
2024-08-27 13:23:03 -04:00
Kris and GitHub
56c8cf0509
UX: adjust software update banner for headerless pages ( #28496 )
2024-08-22 16:51:26 -04:00
Kris and GitHub
ff0bbf1b38
UX: don't use split subcategory color in docked header ( #28494 )
2024-08-22 16:36:59 -04:00
Kris and GitHub
3cb5234c9b
UX: fix textarea height on mobile ( #28495 )
2024-08-22 16:31:48 -04:00
