hanzoai/helpdesk
2
0
Fork 0
mirror of https://github.com/hanzoai/helpdesk.git synced 2026-10-12 16:56:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: code cleanup

Browse Source
This commit is contained in:
Pratik
2026-03-09 12:29:38 +05:30
parent 383794f093
commit 151b7704be
2 changed files with 17 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
helpdesk/api/agent_home/agent_home.py
+2 -17
View File
@@ -1,3 +1,5 @@
from helpdesk.api.agent_home.utils import calculate_percentage_change
from helpdesk.api.agent_home.utils import get_default_agent_dashboard
import json
from datetime import date, datetime, timedelta
@@ -9,23 +11,6 @@ from frappe.query_builder.functions import Avg, Count, Function
from helpdesk.utils import agent_only, format_time_difference
def calculate_percentage_change(current_value: float, previous_value: float) -> float:
"""
Calculate the percentage change between two values.
Returns 999 when there's no previous value but there is a current value.
Returns 0 when both values are zero.
"""
if previous_value > 0:
return round(((current_value - previous_value) / previous_value) * 100, 2)
elif current_value > 0:
return 999
return 0
def get_default_agent_dashboard():
return '[{"chart":"avg_resolution_time","layout":{"x":33,"y":0,"w":17,"h":10,"minW":16,"minH":10,"maxH":11}},{"chart":"avg_first_response_time","layout":{"x":16,"y":0,"w":17,"h":10,"minW":16,"minH":10,"maxH":11}},{"chart":"agent_tickets","layout":{"x":0,"y":0,"w":16,"h":10,"minW":16,"minH":10,"maxH":11}},{"chart":"pending_tickets","layout":{"x":0,"y":10,"w":50,"h":32,"minW":25,"minH":32,"maxH":32}},{"chart":"recent_feedback","layout":{"x":0,"y":66,"w":50,"h":21,"minW":50,"minH":21,"maxH":21}},{"chart":"avg_time_metrics","layout":{"x":0,"y":42,"w":50,"h":24,"minW":18,"minH":24,"maxH":44}}]'
@frappe.whitelist()
@agent_only
def get_dashboard(reset_layout: bool = False):
helpdesk/api/agent_home/utils.py
+15
View File
@@ -0,0 +1,15 @@
def get_default_agent_dashboard():
return '[{"chart":"avg_resolution_time","layout":{"x":33,"y":0,"w":17,"h":10,"minW":16,"minH":10,"maxH":11}},{"chart":"avg_first_response_time","layout":{"x":16,"y":0,"w":17,"h":10,"minW":16,"minH":10,"maxH":11}},{"chart":"agent_tickets","layout":{"x":0,"y":0,"w":16,"h":10,"minW":16,"minH":10,"maxH":11}},{"chart":"pending_tickets","layout":{"x":0,"y":10,"w":50,"h":32,"minW":25,"minH":32,"maxH":32}},{"chart":"recent_feedback","layout":{"x":0,"y":66,"w":50,"h":21,"minW":50,"minH":21,"maxH":21}},{"chart":"avg_time_metrics","layout":{"x":0,"y":42,"w":50,"h":24,"minW":18,"minH":24,"maxH":44}}]'
def calculate_percentage_change(current_value: float, previous_value: float) -> float:
"""
Calculate the percentage change between two values.
Returns 999 when there's no previous value but there is a current value.
Returns 0 when both values are zero.
"""
if previous_value > 0:
return round(((current_value - previous_value) / previous_value) * 100, 2)
elif current_value > 0:
return 999
return 0