chore: code cleanup

(cherry picked from commit 8de2ad89c0)
This commit is contained in:
Ritvik Sardana
2026-06-11 09:24:58 +00:00
committed by Mergify
parent 548a03231d
commit ca2e080128
3 changed files with 20 additions and 16 deletions
@@ -56,7 +56,7 @@ function onSyncStart() {
function onSyncEnd() {
isSyncing.value = false;
syncInfo.reload();
toast.success(__("Sync completed successfully."));
toast.success(__("Sync completed successfully"));
emit("synced");
}
+5 -15
View File
@@ -2,21 +2,11 @@ import frappe
from frappe.model import default_fields
from frappe.model.document import Document
from helpdesk.integrations.erpnext.utils import ALLOWED_DOCTYPES, should_sync
def find_target_for(doctype: str | None, value: str | None) -> tuple[str, str] | None:
"""Map (HD Customer, name) ↔ (Customer, name) via the link fields on each
side. Returns None when no counterpart exists or inputs are missing."""
if not doctype or not value:
return None
if doctype == "HD Customer":
erp = frappe.db.get_value("Customer", {"hd_customer": value}, "name")
return ("Customer", erp) if erp else None
if doctype == "Customer":
hd = frappe.db.get_value("HD Customer", {"erpnext_customer": value}, "name")
return ("HD Customer", hd) if hd else None
return None
from helpdesk.integrations.erpnext.utils import (
ALLOWED_DOCTYPES,
find_target_for,
should_sync,
)
class MirrorSyncMixin(Document):
+14
View File
@@ -176,3 +176,17 @@ def _resync_data_fields(self_doctype: str, self_name: str, other_name: str) -> N
hd_name,
update_modified=False,
)
def find_target_for(doctype: str | None, value: str | None) -> tuple[str, str] | None:
"""Map (HD Customer, name) ↔ (Customer, name) via the link fields on each
side. Returns None when no counterpart exists or inputs are missing."""
if not doctype or not value:
return None
if doctype == "HD Customer":
erp = frappe.db.get_value("Customer", {"hd_customer": value}, "name")
return ("Customer", erp) if erp else None
if doctype == "Customer":
hd = frappe.db.get_value("HD Customer", {"erpnext_customer": value}, "name")
return ("HD Customer", hd) if hd else None
return None