chore: upgrade @tsconfig/node14 (#14284)

package.json

@@ -14,7 +14,7 @@
     "@jest/test-utils": "workspace:^",
     "@lerna-lite/cli": "1.13.0",
     "@microsoft/api-extractor": "^7.35.0",
-    "@tsconfig/node14": "^1.0.3",
+    "@tsconfig/node14": "^14.1.0",
     "@tsd/typescript": "^5.0.4",
     "@types/babel__core": "^7.1.14",
     "@types/babel__generator": "^7.0.0",

scripts/verifyOldTs.mjs

@@ -26,6 +26,7 @@ const tsConfig = {
   extends: baseTsConfig.extends,
   compilerOptions: {
     esModuleInterop: false,
+    module: 'commonjs',
     moduleResolution: 'node',
     noEmit: true,
   },
@@ -50,7 +51,8 @@ function smoketest() {
     execa.sync('yarn', ['init', '--yes'], {cwd, stdio: 'inherit'});
     execa.sync(
       'yarn',
-      ['add', `typescript@~${tsVersion}`, '@tsconfig/node14'],
+      // TODO: do not set version of @tsconfig/node14 after we upgrade to a version of TS that supports `"moduleResolution": "node16"` (https://devblogs.microsoft.com/typescript/announcing-typescript-4-7/)
+      ['add', `typescript@~${tsVersion}`, '@tsconfig/node14@1'],
       {cwd, stdio: 'inherit'},
     );
     fs.writeFileSync(
@@ -97,6 +99,9 @@ function typeTests() {
       );
     }
 
+    // TODO: do not set version of @tsconfig/node14 after we upgrade to a version of TS that supports `"moduleResolution": "node16"` (https://devblogs.microsoft.com/typescript/announcing-typescript-4-7/)
+    execa.sync('yarn', ['add', '@tsconfig/node14@1'], {cwd});
+
     execa.sync(
       'yarn',
       [
@@ -138,7 +143,7 @@ function typeTests() {
 
     execa.sync('yarn', ['test-types'], {cwd, stdio: 'inherit'});
   } finally {
-    execa.sync('git', ['checkout', 'yarn.lock'], {cwd});
+    execa.sync('git', ['checkout', 'package.json', 'yarn.lock'], {cwd});
     execa.sync('yarn', ['install'], {cwd});
   }
 

tsconfig.json

@@ -1,6 +1,9 @@
 {
+  "$schema": "https://json.schemastore.org/tsconfig",
   "extends": "@tsconfig/node14/tsconfig.json",
   "compilerOptions": {
+    "module": "commonjs",
+    "moduleResolution": "node",
     "composite": true,
     "declaration": true,
     "emitDeclarationOnly": true,
@@ -16,8 +19,6 @@
     "noImplicitReturns": true,
     "noFallthroughCasesInSwitch": true,
 
-    /* Module Resolution Options */
-    "moduleResolution": "node",
     /* This needs to be false so our types are possible to consume without setting this */
     "esModuleInterop": false,
     "isolatedModules": true,

tsconfig.typetest.json

@@ -1,6 +1,8 @@
 {
   "extends": "@tsconfig/node14/tsconfig.json",
   "compilerOptions": {
+    "module": "commonjs",
+    "moduleResolution": "node",
     "noEmit": true,
     "noUnusedLocals": false,
     "noUnusedParameters": false,

yarn.lock

@@ -2846,7 +2846,7 @@ __metadata:
     "@jest/test-utils": "workspace:^"
     "@lerna-lite/cli": 1.13.0
     "@microsoft/api-extractor": ^7.35.0
-    "@tsconfig/node14": ^1.0.3
+    "@tsconfig/node14": ^14.1.0
     "@tsd/typescript": ^5.0.4
     "@types/babel__core": ^7.1.14
     "@types/babel__generator": ^7.0.0
@@ -4435,13 +4435,20 @@ __metadata:
   languageName: node
   linkType: hard
 
-"@tsconfig/node14@npm:^1.0.0, @tsconfig/node14@npm:^1.0.3":
+"@tsconfig/node14@npm:^1.0.0":
   version: 1.0.3
   resolution: "@tsconfig/node14@npm:1.0.3"
   checksum: 19275fe80c4c8d0ad0abed6a96dbf00642e88b220b090418609c4376e1cef81bf16237bf170ad1b341452feddb8115d8dd2e5acdfdea1b27422071163dc9ba9d
   languageName: node
   linkType: hard
 
+"@tsconfig/node14@npm:^14.1.0":
+  version: 14.1.0
+  resolution: "@tsconfig/node14@npm:14.1.0"
+  checksum: 8342dc30edbfaed11d1659b1a9819779bb69df210974a9e8a337b0624b1d9f5026f37e2dcc1d555adb3e4246a0ec35896b3ae5fe3fc69f3382d3bc11069cecc1
+  languageName: node
+  linkType: hard
+
 "@tsconfig/node16@npm:^1.0.2":
   version: 1.0.3
   resolution: "@tsconfig/node16@npm:1.0.3"