mirror of
https://github.com/hanzoai/lsp.git
synced 2026-09-30 22:52:48 +00:00
LLM.md: code-exec's copy is one call site away from this, not already broken
The previous note said code-exec 'has the same bug'. It has the same ORDERING — binds first, /tmp after — but binds its session tree at a fixed /work rather than at the tree's own absolute path, so nothing of its lands under the tmpfs. It fails the moment a bind path does. Naming which is which is the difference between a warning someone can act on and one they learn to ignore. Co-authored-by: Hanzo Dev <[email protected]>
This commit is contained in:
@@ -71,9 +71,14 @@ order that hid part of it.
|
||||
Sorting by depth makes an ancestor-after-descendant order unrepresentable, and
|
||||
`TestThePlanHidesNothing` asserts it with no kernel and no privileges.
|
||||
|
||||
**Any fork of this jailer has the same bug** — it was copied from
|
||||
hanzoai/code-exec's `internal/codeexec/jail_linux.go`, which orders its mounts
|
||||
the same way. See the CTO call below: this belongs in one module, not two files.
|
||||
**hanzoai/code-exec carries the same ordering, and it is one change away from
|
||||
the same bug.** This jailer was copied from its `internal/codeexec/jail_linux.go`,
|
||||
which also binds first and mounts `/tmp` after. It is not hit TODAY only because
|
||||
it binds the session tree at a fixed `/work` rather than at the tree's own
|
||||
absolute path, and its toolchain binds are outside `/tmp`; the day any bind path
|
||||
falls under `/tmp`, it fails exactly the way this did. That is a property of a
|
||||
call site, not of the jailer — which is the argument for the CTO call below: a
|
||||
boundary that exists in two files drifts, and this is what the drift looks like.
|
||||
|
||||
Off Linux there is no jail to require, and the daemon says so loudly in the log
|
||||
and on `/readyz`. The image is linux/amd64, so that case is a developer's
|
||||
|
||||
Reference in New Issue
Block a user