hanzoai/next.js
2
0
Fork 0
mirror of https://github.com/hanzoai/next.js.git synced 2026-09-24 17:00:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Include versions in externals error message (#68871)

Browse Source 
Now the expected and actual version numbers are included in the error
message:
```
Package @libsql/client (serverExternalPackages or default list) can't be external
The request @libsql/client matches serverExternalPackages (or the default list), but it can't be external:
The package resolves to a different version when requested from the project directory (0.9.0) compared to the package requested from the importing module (0.6.2).
Make sure to install the same version of the package in both locations.
```
This commit is contained in:
Niklas Mischkulnig
2024-08-14 13:24:58 +02:00
committed by GitHub
parent 4a9fef6435
commit ff339bbfb0
1 changed files with 16 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/next-core/src/next_server/resolve.rs
+16 -9
View File
@@ -308,21 +308,25 @@ impl AfterResolvePlugin for ExternalCjsModulesResolvePlugin {
);
};
let (Some(name), Some(version)) = (
package_json_file.get("name"),
package_json_file.get("version"),
package_json_file.get("name").and_then(|v| v.as_str()),
package_json_file.get("version").and_then(|v| v.as_str()),
) else {
return unable_to_externalize(
request_str.into(),
"The package.json of the package has not name or version.",
"The package.json of the package has no name or version.",
);
};
let (Some(name2), Some(version2)) = (
package_json_from_original_location.get("name"),
package_json_from_original_location.get("version"),
package_json_from_original_location
.get("name")
.and_then(|v| v.as_str()),
package_json_from_original_location
.get("version")
.and_then(|v| v.as_str()),
) else {
return unable_to_externalize(
request_str.into(),
"The package.json of the package resolved from project directory has not name \
"The package.json of the package resolved from project directory has no name \
or version.",
);
};
@@ -330,9 +334,12 @@ impl AfterResolvePlugin for ExternalCjsModulesResolvePlugin {
// this can't resolve with node.js from the original location, so bundle it
return unable_to_externalize(
request_str.into(),
"The package resolves to a different version when requested from the project \
directory compared to the package requested from the importing module.\nMake \
sure to install the same version of the package in both locations.",
&format!(
"The package resolves to a different version when requested from the \
project directory ({version}) compared to the package requested from the \
importing module ({version2}).\nMake sure to install the same version of \
the package in both locations."
),
);
}
}