Cong-Cong PanandGitHub
06a81414ac
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> let Rspack to pass the test cases it was previously able to pass. 1. update Rspack to 1.3.9 2. Moves `moduleSpansByCompilation` setting in `RspackProfilingPlugin` from the `compilation` hook to `thisCompilation`. `TraceEntryPointsPlugin` relies on `moduleSpansByCompilation` during its `thisCompilation` hook. Since the `compilation` hook triggers before `thisCompilation`, initializing the map earlier leads to: ``` Error: × TypeError: Cannot read properties of undefined (reading 'traceChild') ``` relate: https://github.com/vercel/next.js/pull/78011 3. The test case `test/integration/middleware-prefetch/tests/index.test.js` was failing due to an unreliable asset name matching strategy. Asset names follow the pattern: `static/chunks/pages/[pagename]-[hash].js`. Test was checking for `ssg-page-2-[hash].js` by looking for names starting with `ssg-page-2`. This could produce false positives when `ssg-page-[hash].js` happens to have a hash starting with `2`. 4. test dev `test/e2e/app-dir/dynamic-data/dynamic-data.test.ts` Test fails due to Rspack's lack of support for compilation.codeGenerationResults JS API. 5. test dev `test/e2e/app-dir/dynamic-href/dynamic-href.test.ts` Same compatibility issue as above. 6. test dev `test/development/acceptance-app/hydration-error.test.ts` Same compatibility issue as above. 6. test dev `test/development/app-dir/ssr-in-rsc/ssr-in-rsc.test.ts` Test fails due to differing error message formats between implementations.
Next.js
Getting Started
Used by some of the world's largest companies, Next.js enables you to create full-stack web applications by extending the latest React features, and integrating powerful Rust-based JavaScript tooling for the fastest builds.
- Visit our Learn Next.js course to get started with Next.js.
- Visit the Next.js Showcase to see more sites built with Next.js.
Documentation
Visit https://nextjs.org/docs to view the full documentation.
Community
The Next.js community can be found on GitHub Discussions where you can ask questions, voice ideas, and share your projects with other people.
To chat with other community members you can join the Next.js Discord server.
Do note that our Code of Conduct applies to all Next.js community channels. Users are highly encouraged to read and adhere to them to avoid repercussions.
Contributing
Contributions to Next.js are welcome and highly appreciated. However, before you jump right into it, we would like you to review our Contribution Guidelines to make sure you have a smooth experience contributing to Next.js.
Good First Issues:
We have a list of good first issues that contain bugs that have a relatively limited scope. This is a great place for newcomers and beginners alike to get started, gain experience, and get familiar with our contribution process.
Security
If you believe you have found a security vulnerability in Next.js, we encourage you to responsibly disclose this and NOT open a public issue. We will investigate all legitimate reports.
Our preference is that you make use of GitHub's private vulnerability reporting feature to disclose potential security vulnerabilities in our Open Source Software. To do this, please visit https://github.com/vercel/next.js/security and click the "Report a vulnerability" button.