mirror of
https://github.com/hanzoai/pack.git
synced 2026-09-30 23:43:13 +00:00
delete the root test with nothing to test
recipe_test.go is package main at the repo root and calls Detect, fileset and Plan.Recipe. None of those exist in the tree, and it imports moby/docker-image-spec, which go.sum no longer carries, so go vet ./... stops at the root package before it type-checks anything: recipe_test.go:10:2: missing go.sum entry for module providing package github.com/moby/docker-image-spec/specs-go/v1 Without the file the root is not a package and go vet ./... is clean. Co-authored-by: Hanzo Dev <[email protected]>
This commit is contained in:
Hanzo Dev
-224
@@ -1,224 +0,0 @@
|
||||
package main
|
||||
|
||||
import (
|
||||
"context"
|
||||
"strings"
|
||||
"testing"
|
||||
|
||||
"github.com/moby/buildkit/client/llb"
|
||||
"github.com/moby/buildkit/solver/pb"
|
||||
dockerspec "github.com/moby/docker-image-spec/specs-go/v1"
|
||||
)
|
||||
|
||||
// graph marshals a State and returns every source image identifier and every
|
||||
// exec argv in the LLB DAG, so recipes can be asserted without a buildkitd.
|
||||
func graph(t *testing.T, st llb.State) (sources []string, execs [][]string) {
|
||||
t.Helper()
|
||||
def, err := st.Marshal(context.Background())
|
||||
if err != nil {
|
||||
t.Fatalf("marshal: %v", err)
|
||||
}
|
||||
for _, dt := range def.Def {
|
||||
var op pb.Op
|
||||
if err := op.Unmarshal(dt); err != nil {
|
||||
t.Fatalf("unmarshal op: %v", err)
|
||||
}
|
||||
if s := op.GetSource(); s != nil {
|
||||
sources = append(sources, s.Identifier)
|
||||
}
|
||||
if e := op.GetExec(); e != nil && e.Meta != nil {
|
||||
execs = append(execs, e.Meta.Args)
|
||||
}
|
||||
}
|
||||
return sources, execs
|
||||
}
|
||||
|
||||
func hasSource(sources []string, sub string) bool {
|
||||
for _, s := range sources {
|
||||
if strings.Contains(s, sub) {
|
||||
return true
|
||||
}
|
||||
}
|
||||
return false
|
||||
}
|
||||
|
||||
func hasExec(execs [][]string, sub string) bool {
|
||||
for _, a := range execs {
|
||||
if strings.Contains(strings.Join(a, " "), sub) {
|
||||
return true
|
||||
}
|
||||
}
|
||||
return false
|
||||
}
|
||||
|
||||
func recipeFor(t *testing.T, npm Scripts, files ...string) Recipe {
|
||||
t.Helper()
|
||||
plan, err := Detect(fileset(files...), npm)
|
||||
if err != nil {
|
||||
t.Fatalf("detect: %v", err)
|
||||
}
|
||||
return plan.Recipe(llb.Local("context"))
|
||||
}
|
||||
|
||||
func TestGoRecipe(t *testing.T) {
|
||||
r := recipeFor(t, Scripts{}, "go.mod")
|
||||
sources, execs := graph(t, r.State)
|
||||
if !hasSource(sources, "golang:1.23-alpine") {
|
||||
t.Errorf("missing go builder image; sources=%v", sources)
|
||||
}
|
||||
if !hasSource(sources, "distroless/static") {
|
||||
t.Errorf("missing distroless runtime; sources=%v", sources)
|
||||
}
|
||||
if !hasExec(execs, "go build -o /out/app .") {
|
||||
t.Errorf("missing go build step; execs=%v", execs)
|
||||
}
|
||||
if len(r.Entrypoint) != 1 || r.Entrypoint[0] != "/app" {
|
||||
t.Errorf("entrypoint = %v", r.Entrypoint)
|
||||
}
|
||||
}
|
||||
|
||||
func TestNodeRecipe(t *testing.T) {
|
||||
r := recipeFor(t, Scripts{Start: true}, "package.json", "package-lock.json")
|
||||
sources, execs := graph(t, r.State)
|
||||
if !hasSource(sources, "node:22-alpine") {
|
||||
t.Errorf("missing node image; sources=%v", sources)
|
||||
}
|
||||
if !hasExec(execs, "npm ci") {
|
||||
t.Errorf("lockfile should build with npm ci; execs=%v", execs)
|
||||
}
|
||||
if !hasExec(execs, "npm run build --if-present") {
|
||||
t.Errorf("missing npm build step; execs=%v", execs)
|
||||
}
|
||||
if got := strings.Join(r.Entrypoint, " "); got != "npm start" {
|
||||
t.Errorf("entrypoint = %q", got)
|
||||
}
|
||||
|
||||
// Without a lockfile the install is npm install.
|
||||
_, execs = graph(t, recipeFor(t, Scripts{Start: true}, "package.json").State)
|
||||
if !hasExec(execs, "npm install") {
|
||||
t.Errorf("no lockfile should build with npm install; execs=%v", execs)
|
||||
}
|
||||
}
|
||||
|
||||
func TestPythonRecipe(t *testing.T) {
|
||||
r := recipeFor(t, Scripts{}, "requirements.txt")
|
||||
sources, execs := graph(t, r.State)
|
||||
if !hasSource(sources, "python:3.12-slim") {
|
||||
t.Errorf("missing python image; sources=%v", sources)
|
||||
}
|
||||
if !hasExec(execs, "pip install --no-cache-dir -r requirements.txt") {
|
||||
t.Errorf("missing pip install; execs=%v", execs)
|
||||
}
|
||||
if got := strings.Join(r.Entrypoint, " "); got != "python main.py" {
|
||||
t.Errorf("entrypoint = %q", got)
|
||||
}
|
||||
|
||||
// pyproject-only installs the project itself.
|
||||
_, execs = graph(t, recipeFor(t, Scripts{}, "pyproject.toml").State)
|
||||
if !hasExec(execs, "pip install --no-cache-dir .") {
|
||||
t.Errorf("pyproject should pip install .; execs=%v", execs)
|
||||
}
|
||||
}
|
||||
|
||||
// Plain HTML is already the site: it is exported as it is, unbuilt.
|
||||
func TestStaticRecipe(t *testing.T) {
|
||||
r := recipeFor(t, Scripts{}, "index.html")
|
||||
sources, execs := graph(t, r.State)
|
||||
if !hasSource(sources, "local://context") {
|
||||
t.Errorf("the context is the result; sources=%v", sources)
|
||||
}
|
||||
if len(execs) != 0 {
|
||||
t.Errorf("plain HTML needs no build; execs=%v", execs)
|
||||
}
|
||||
if len(sources) != 1 {
|
||||
t.Errorf("plain HTML pulls no image; sources=%v", sources)
|
||||
}
|
||||
}
|
||||
|
||||
// A generator is built, and only what the build wrote is exported.
|
||||
func TestGeneratedSiteRecipe(t *testing.T) {
|
||||
r := recipeFor(t, Scripts{Build: true}, "package.json", "package-lock.json")
|
||||
sources, execs := graph(t, r.State)
|
||||
if !hasSource(sources, "node:22-alpine") {
|
||||
t.Errorf("missing node image; sources=%v", sources)
|
||||
}
|
||||
if !hasExec(execs, "npm ci") {
|
||||
t.Errorf("lockfile should install with npm ci; execs=%v", execs)
|
||||
}
|
||||
if !hasExec(execs, "npm run build") {
|
||||
t.Errorf("missing build step; execs=%v", execs)
|
||||
}
|
||||
if hasExec(execs, "--if-present") {
|
||||
t.Errorf("the build script is known to exist here; execs=%v", execs)
|
||||
}
|
||||
// The output directory order, first match wins.
|
||||
if !hasExec(execs, "for d in dist build out public _site;") {
|
||||
t.Errorf("missing output directory order; execs=%v", execs)
|
||||
}
|
||||
// Nothing to fall back on: the source must never be exported instead.
|
||||
if !hasExec(execs, "exit 1") {
|
||||
t.Errorf("no build output should fail the build; execs=%v", execs)
|
||||
}
|
||||
|
||||
// Without a lockfile the install is npm install.
|
||||
_, execs = graph(t, recipeFor(t, Scripts{Build: true}, "package.json").State)
|
||||
if !hasExec(execs, "npm install") {
|
||||
t.Errorf("no lockfile should install with npm install; execs=%v", execs)
|
||||
}
|
||||
}
|
||||
|
||||
// The one difference that matters downstream: a site carries no image config,
|
||||
// an app carries one. build returns a bare ref for the first and an image for
|
||||
// the second.
|
||||
func TestOutputLane(t *testing.T) {
|
||||
cases := []struct {
|
||||
name string
|
||||
npm Scripts
|
||||
files []string
|
||||
want bool // files rather than an image
|
||||
}{
|
||||
{"plain site", Scripts{}, []string{"index.html"}, true},
|
||||
{"generated site", Scripts{Build: true}, []string{"package.json"}, true},
|
||||
{"go", Scripts{}, []string{"go.mod"}, false},
|
||||
{"node", Scripts{Start: true}, []string{"package.json"}, false},
|
||||
{"python", Scripts{}, []string{"requirements.txt"}, false},
|
||||
}
|
||||
for _, tc := range cases {
|
||||
t.Run(tc.name, func(t *testing.T) {
|
||||
r := recipeFor(t, tc.npm, tc.files...)
|
||||
if r.files() != tc.want {
|
||||
t.Fatalf("files() = %v, want %v", r.files(), tc.want)
|
||||
}
|
||||
if !tc.want {
|
||||
return
|
||||
}
|
||||
if r.Base != "" || len(r.Entrypoint) != 0 || r.WorkDir != "" || len(r.Ports) != 0 {
|
||||
t.Fatalf("a site carries no runtime config: %+v", r)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestImageOverlay(t *testing.T) {
|
||||
base := &dockerspec.DockerOCIImage{}
|
||||
base.Config.Env = []string{"PATH=/usr/local/bin:/usr/bin"}
|
||||
base.Config.Cmd = []string{"node"}
|
||||
|
||||
img := recipeFor(t, Scripts{Start: true}, "package.json").image(base)
|
||||
if strings.Join(img.Config.Entrypoint, " ") != "npm start" {
|
||||
t.Errorf("entrypoint = %v", img.Config.Entrypoint)
|
||||
}
|
||||
if img.Config.WorkingDir != "/app" {
|
||||
t.Errorf("workdir = %q", img.Config.WorkingDir)
|
||||
}
|
||||
if len(img.Config.Cmd) != 0 {
|
||||
t.Errorf("base cmd should be cleared, got %v", img.Config.Cmd)
|
||||
}
|
||||
if len(img.Config.Env) != 1 || img.Config.Env[0] != "PATH=/usr/local/bin:/usr/bin" {
|
||||
t.Errorf("base PATH must be preserved, got %v", img.Config.Env)
|
||||
}
|
||||
// Overlay must not mutate the caller's base config.
|
||||
if base.Config.WorkingDir != "" || len(base.Config.Cmd) != 1 {
|
||||
t.Errorf("base config was mutated: %+v", base.Config)
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user