hanzoai/pack
2
0
Fork 0
mirror of https://github.com/hanzoai/pack.git synced 2026-09-30 23:43:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(node): support LTS version queries, use LTS as default node version (#650)

Browse Source 
* feat(mise): support LTS version queries and improve version candidates

- Add support for resolving LTS and other non-semver version aliases in mise
- Introduce `versionQueryCandidates` to gracefully fall back from extracted semver to original version strings
- Add unit tests for LTS resolution and version query candidate generation

Generated-by: aiautocommit

* feat(node): update default Node version to lts

Generated-by: aiautocommit

* feat(mise): improve version resolution fallbacks and error messages

- Fallback to unconstrained release age queries when strict minimum age checks fail to respect pinned versions or custom configs.
- Include tried candidate versions in error messages to improve debugging when package lookups fail.

Generated-by: aiautocommit
This commit is contained in:
Michael Bianco
2026-07-31 06:35:56 -06:00
committed by GitHub
parent 22828fa009
commit 60c281787d
4 changed files with 102 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files
core/mise/mise.go
+62 -32
View File
@@ -60,38 +60,47 @@ func (m *Mise) GetLatestVersion(pkg, version string) (string, error) {
}
defer unlock()
semverVersion := utils.ExtractSemverVersion(version)
query := fmt.Sprintf("%s@%s", pkg, semverVersion)
baseEnv := []string{"MISE_NO_CONFIG=1", "MISE_PARANOID=1"}
// a user could eliminate the min release age in their config, or pin a version to a release
// if they do, we want to make sure they can still install that specific version they want, so we fallback to a env
// *without* the min age requirement after we've tried to query mise with this requirement first.
minAgeEnv := append([]string{fmt.Sprintf("MISE_MINIMUM_RELEASE_AGE=%s", MinimumReleaseAge)}, baseEnv...)
// Prefer versions older than MinimumReleaseAge when resolving fuzzy constraints
output, err := m.runCmdWithEnv(minAgeEnv, "latest", query)
var output string
for i, queryVersion := range versionQueryCandidates(version) {
// i.e. node@lts
query := fmt.Sprintf("%s@%s", pkg, queryVersion)
// Fall back without the age filter if nothing matched
// this occurs when a user locks to a specific version on their host which does not have a minimum version constraint
// NOTE as of 2026-06-01 `latest` on macOS vs linux has a different result when MISE_MINIMUM_RELEASE_AGE is specified. macOS seems to ignore
// this completely (at least, on the uv backend).
if err != nil || strings.TrimSpace(output) == "" {
output, err = m.runCmdWithEnv(baseEnv, "latest", query)
}
if i == 0 {
// Prefer versions old enough to avoid newly released regressions.
output, err = m.runCmdWithEnv(minAgeEnv, "latest", query)
if err == nil && strings.TrimSpace(output) != "" {
break
}
// If semver extraction fails, try with original version
// https://github.com/railwayapp/railpack/issues/203
if (err != nil || strings.TrimSpace(output) == "") && semverVersion != version {
query = fmt.Sprintf("%s@%s", pkg, version)
output, err = m.runCmdWithEnv(baseEnv, "latest", query)
}
if err != nil {
if strings.Contains(err.Error(), "not found in mise tool registry") {
return "", fmt.Errorf("package `%s` not available in Mise. Try installing as apt package instead", pkg)
// Fall back without the age filter when a pinned version is newer than
// MinimumReleaseAge. As of 2026-06-01, mise's uv backend also applies
// this setting inconsistently between macOS and Linux.
}
return "", err
output, err = m.runCmdWithEnv(baseEnv, "latest", query)
if err == nil && strings.TrimSpace(output) != "" {
break
}
}
// TODO should create an error docs entry for this
if err != nil {
triedVersions := strings.Join(versionQueryCandidates(version), ", ")
if strings.Contains(err.Error(), "not found in mise tool registry") {
return "", fmt.Errorf("package `%s` not available in Mise after trying versions: %s. Try installing as apt package instead", pkg, triedVersions)
}
return "", fmt.Errorf("failed to get latest version for package `%s` after trying versions: %s: %w", pkg, triedVersions, err)
}
// TODO seems like an odd case, we should write error docs for it and try to get reports on this error
latestVersion := strings.TrimSpace(output)
if latestVersion == "" {
return "", fmt.Errorf(ErrMiseGetLatestVersion, version, pkg)
@@ -107,16 +116,13 @@ func (m *Mise) GetAllVersions(pkg, version string) ([]string, error) {
}
defer unlock()
// Try with extracted semver version first
semverVersion := utils.ExtractSemverVersion(version)
query := fmt.Sprintf("%s@%s", pkg, semverVersion)
output, err := m.runCmdWithEnv([]string{"MISE_NO_CONFIG=1", "MISE_PARANOID=1"}, "ls-remote", query)
// If semver extraction fails, try with original version
// https://github.com/railwayapp/railpack/issues/203
if (err != nil || strings.TrimSpace(output) == "") && semverVersion != version {
query = fmt.Sprintf("%s@%s", pkg, version)
var output string
for _, queryVersion := range versionQueryCandidates(version) {
query := fmt.Sprintf("%s@%s", pkg, queryVersion)
output, err = m.runCmdWithEnv([]string{"MISE_NO_CONFIG=1", "MISE_PARANOID=1"}, "ls-remote", query)
if err == nil && strings.TrimSpace(output) != "" {
break
}
}
if err != nil {
@@ -140,6 +146,30 @@ func (m *Mise) GetAllVersions(pkg, version string) ([]string, error) {
return versions, nil
}
// versionQueryCandidates returns a slice of possible version strings to query with mise,
// normalizing semver versions but preserving special aliases (like "lts"). Semver normalization is
// attempted first for version resolution, then the original input is retried for cases like aliases.
//
// Examples:
//
// versionQueryCandidates("20.10.2") => []string{"20.10.2"}
// versionQueryCandidates("^20.10.2") => []string{"20.10.2", "^20.10.2"}
// versionQueryCandidates("lts") => []string{"lts"}
func versionQueryCandidates(version string) []string {
semverVersion := utils.ExtractSemverVersion(version)
if semverVersion == "" {
// Preserve mise aliases like `lts` instead of querying an empty version.
return []string{version}
}
if semverVersion == version {
return []string{version}
}
// Prefer the normalized semver, then retry idiomatic strings that mise accepts directly.
// https://github.com/railwayapp/railpack/issues/203
return []string{semverVersion, version}
}
// returns the JSON output of 'mise list --current --json' for the app
func (m *Mise) GetCurrentList(appDir string) (string, error) {
// MISE_TRUSTED_CONFIG_PATHS allows mise to use configs in the app directory without a trust warning
core/mise/mise_test.go
+38
View File
@@ -66,6 +66,44 @@ func TestMistGetLatestVersion(t *testing.T) {
}
}
func TestMiseGetLatestVersionLTS(t *testing.T) {
tempDir, err := os.MkdirTemp("", "mise-test")
if err != nil {
t.Fatalf("failed to create temp dir: %v", err)
}
defer func() { _ = os.RemoveAll(tempDir) }()
mise, err := New(tempDir)
if err != nil {
t.Fatalf("failed to create mise: %v", err)
}
latest, err := mise.GetLatestVersion("node", "lts")
require.NoError(t, err)
require.Regexp(t, `^\d+\.\d+\.\d+$`, latest)
}
func TestVersionQueryCandidates(t *testing.T) {
tests := []struct {
name string
version string
expected []string
}{
{name: "major", version: "22", expected: []string{"22"}},
{name: "major and minor", version: "22.1", expected: []string{"22.1"}},
{name: "full version", version: "22.1.3", expected: []string{"22.1.3"}},
{name: "prefixed version", version: "v22", expected: []string{"22", "v22"}},
{name: "embedded version", version: "node-22.1", expected: []string{"22.1", "node-22.1"}},
{name: "alias", version: "lts", expected: []string{"lts"}},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
require.Equal(t, tt.expected, versionQueryCandidates(tt.version))
})
}
}
func TestMiseGetAllVersions(t *testing.T) {
tempDir, err := os.MkdirTemp("", "mise-test")
if err != nil {
core/providers/node/node.go
+1 -1
View File
@@ -17,7 +17,7 @@ import (
type PackageManager string
const (
DEFAULT_NODE_VERSION = "22"
DEFAULT_NODE_VERSION = "lts"
DEFAULT_BUN_VERSION = "latest"
// not used by npm, but many other tools: next, jest, webpack, etc
docs/src/content/docs/languages/node.md
+1 -1
View File
@@ -20,7 +20,7 @@ The Node.js version is determined in the following order of priority:
3. Read from the `.nvmrc` file
4. Read from the `.node-version` file
5. Read from `mise.toml` or `.tool-versions` files
6. Defaults to `22`
6. Defaults to `lts`
This version resolution logic is applied consistently across all scenarios where
Node is needed, including when Bun is the primary package manager but Node is