devops: drop service mode from transport job (#40530)

This commit is contained in:
Pavel Feldman
2026-04-30 09:30:15 -07:00
committed by GitHub
parent e4002fce99
commit d57fb31e30
4 changed files with 5 additions and 30 deletions
+4 -6
View File
@@ -144,13 +144,11 @@ jobs:
flakiness-tenant-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_TENANT_ID }}
flakiness-subscription-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_SUBSCRIPTION_ID }}
transport_linux:
name: "Transport"
driver_linux:
name: "Driver"
environment: ${{ github.event_name == 'push' && 'allow-uploading-flakiness-results' || null }}
strategy:
fail-fast: false
matrix:
mode: [driver, service]
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v6
@@ -158,12 +156,12 @@ jobs:
with:
browsers-to-install: chromium
command: npm run ctest
bot-name: "${{ matrix.mode }}"
bot-name: "driver"
flakiness-client-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_CLIENT_ID }}
flakiness-tenant-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_TENANT_ID }}
flakiness-subscription-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_SUBSCRIPTION_ID }}
env:
PWTEST_MODE: ${{ matrix.mode }}
PWTEST_MODE: driver
tracing_linux:
name: Tracing ${{ matrix.browser }} ${{ matrix.channel }}
+1 -1
View File
@@ -16,7 +16,7 @@
import { oop, client } from '../../packages/playwright-core/lib/coreBundle';
export type TestModeName = 'default' | 'driver' | 'service' | 'service2' | 'wsl';
export type TestModeName = 'default' | 'driver';
const { start } = oop;
-4
View File
@@ -36,10 +36,6 @@ export const testModeTest = test.extend<TestModeTestFixtures, TestModeWorkerOpti
playwright: [async ({ mode }, run) => {
const testMode = {
'default': new DefaultTestMode(),
'service': new DefaultTestMode(),
'service2': new DefaultTestMode(),
'service-grid': new DefaultTestMode(),
'wsl': new DefaultTestMode(),
'driver': new DriverTestMode(),
}[mode];
const playwright = await testMode.setup();
-19
View File
@@ -59,25 +59,6 @@ const runId = process.env.PLAYWRIGHT_SERVICE_RUN_ID || new Date().toISOString();
let connectOptions: any;
let webServer: Config['webServer'];
if (mode === 'service') {
connectOptions = { wsEndpoint: 'ws://localhost:3333/' };
webServer = {
command: 'npx playwright run-server --port=3333',
url: 'http://localhost:3333',
reuseExistingServer: !process.env.CI,
};
}
if (mode === 'service2') {
process.env.PW_VERSION_OVERRIDE = process.env.PW_VERSION_OVERRIDE || '1.39';
connectOptions = {
wsEndpoint: `${process.env.PLAYWRIGHT_SERVICE_URL}?cap=${JSON.stringify({ os, runId })}`,
timeout: 3 * 60 * 1000,
exposeNetwork: '<loopback>',
headers: {
'x-mpt-access-key': process.env.PLAYWRIGHT_SERVICE_ACCESS_KEY!
}
};
}
if (channel === 'webkit-wsl') {
connectOptions = { wsEndpoint: 'ws://localhost:3777/' };
webServer = {