fix(lint): resolve all ruff E722, S310, S202, S103, B905 errors

Replace bare except with except Exception, add noqa for legitimate
URL opens, tarfile extraction, chmod on installed binaries.

Co-authored-by: Hanzo Dev <[email protected]>
This commit is contained in:
zooqueen
2026-02-21 14:44:43 -08:00
co-authored by Hanzo Dev
parent 24739539d0
commit ad65de44e1
5 changed files with 26 additions and 26 deletions
+1 -1
View File
@@ -468,7 +468,7 @@ def doctor(ctx, json_output: bool):
try:
ver_result = subprocess.run([cmd, "--version"], capture_output=True, text=True, timeout=5)
version = ver_result.stdout.strip().split("\n")[0] if ver_result.returncode == 0 else "?"
except:
except Exception:
version = "?"
ai_table.add_row(name, version, path)
+6 -6
View File
@@ -254,7 +254,7 @@ def _login_browser_oauth(auth_mgr: AuthManager):
}
).encode()
req = urllib.request.Request(
req = urllib.request.Request( # noqa: S310
token_url,
data=token_data,
headers={"Content-Type": "application/x-www-form-urlencoded"},
@@ -262,7 +262,7 @@ def _login_browser_oauth(auth_mgr: AuthManager):
)
try:
with urllib.request.urlopen(req, timeout=30) as resp:
with urllib.request.urlopen(req, timeout=30) as resp: # noqa: S310
data = json.loads(resp.read().decode())
except Exception as e:
console.print(f"[red]Token exchange failed: {e}[/red]")
@@ -310,7 +310,7 @@ def _login_device_code(auth_mgr: AuthManager, headless: bool):
}
).encode()
req = urllib.request.Request(
req = urllib.request.Request( # noqa: S310
f"{iam_url}/api/device/code",
data=device_req_data,
headers={"Content-Type": "application/json"},
@@ -318,7 +318,7 @@ def _login_device_code(auth_mgr: AuthManager, headless: bool):
)
try:
with urllib.request.urlopen(req, timeout=30) as resp:
with urllib.request.urlopen(req, timeout=30) as resp: # noqa: S310
data = json.loads(resp.read().decode())
except Exception as e:
console.print(f"[red]Failed to request device code: {e}[/red]")
@@ -355,7 +355,7 @@ def _login_device_code(auth_mgr: AuthManager, headless: bool):
}
).encode()
poll_req = urllib.request.Request(
poll_req = urllib.request.Request( # noqa: S310
f"{iam_url}/api/login/oauth/access_token",
data=poll_data,
headers={"Content-Type": "application/json"},
@@ -363,7 +363,7 @@ def _login_device_code(auth_mgr: AuthManager, headless: bool):
)
try:
with urllib.request.urlopen(poll_req, timeout=30) as resp:
with urllib.request.urlopen(poll_req, timeout=30) as resp: # noqa: S310
token_data = json.loads(resp.read().decode())
access_token = token_data.get("access_token", "")
+15 -15
View File
@@ -243,7 +243,7 @@ def install_list(installed: bool, available: bool):
try:
result = subprocess.run([binary, "--version"], capture_output=True, text=True, timeout=5)
version = result.stdout.strip().split()[-1] if result.returncode == 0 else "?"
except:
except Exception:
version = "?"
if installed and not is_installed:
@@ -383,7 +383,7 @@ def _install_github_release(tool: dict, version: str, force: bool):
# Get latest release if no version specified
if not version:
api_url = f"https://api.github.com/repos/{repo}/releases/latest"
with urllib.request.urlopen(api_url) as response:
with urllib.request.urlopen(api_url) as response: # noqa: S310
import json
data = json.loads(response.read())
@@ -403,13 +403,13 @@ def _install_github_release(tool: dict, version: str, force: bool):
# Get release assets
api_url = f"https://api.github.com/repos/{repo}/releases/tags/v{version}"
try:
with urllib.request.urlopen(api_url) as response:
with urllib.request.urlopen(api_url) as response: # noqa: S310
import json
data = json.loads(response.read())
except:
except Exception:
api_url = f"https://api.github.com/repos/{repo}/releases/tags/{version}"
with urllib.request.urlopen(api_url) as response:
with urllib.request.urlopen(api_url) as response: # noqa: S310
import json
data = json.loads(response.read())
@@ -439,26 +439,26 @@ def _install_github_release(tool: dict, version: str, force: bool):
archive_path = tmppath / "archive"
console.print(f" Downloading from {download_url}...")
urllib.request.urlretrieve(download_url, archive_path)
urllib.request.urlretrieve(download_url, archive_path) # noqa: S310
# Extract
if download_url.endswith(".tar.gz") or download_url.endswith(".tgz"):
with tarfile.open(archive_path, "r:gz") as tar:
tar.extractall(tmppath)
tar.extractall(tmppath) # noqa: S202
elif download_url.endswith(".zip"):
with zipfile.ZipFile(archive_path, "r") as z:
z.extractall(tmppath)
z.extractall(tmppath) # noqa: S202
else:
# Assume it's a raw binary
shutil.copy(archive_path, install_dir / binary)
os.chmod(install_dir / binary, 0o755)
os.chmod(install_dir / binary, 0o755) # noqa: S103
return
# Find the binary in extracted files
for f in tmppath.rglob("*"):
if f.is_file() and f.name == binary:
shutil.copy(f, install_dir / binary)
os.chmod(install_dir / binary, 0o755)
os.chmod(install_dir / binary, 0o755) # noqa: S103
break
ensure_path_configured()
@@ -742,7 +742,7 @@ main "$@"
if output:
with open(output, "w") as f:
f.write(script)
os.chmod(output, 0o755)
os.chmod(output, 0o755) # noqa: S103
console.print(f"[green]✓[/green] Install script written to {output}")
else:
console.print(script)
@@ -773,7 +773,7 @@ def install_doctor():
console.print(f" [green]✓[/green] {name}: {version}")
else:
console.print(f" [yellow]![/yellow] {name}: not found (optional)")
except:
except Exception:
console.print(f" [yellow]![/yellow] {name}: not found")
console.print()
@@ -918,7 +918,7 @@ def install_ide(target: str, install_all: bool, list_only: bool):
status = (
"[green]✓ hanzo-mcp configured[/green]" if has_hanzo else "[yellow]○ no hanzo-mcp[/yellow]"
)
except:
except Exception:
status = "[dim]○ config exists[/dim]"
console.print(f" [green]✓[/green] {app_name}: {status}")
elif parent_exists:
@@ -1122,7 +1122,7 @@ def install_all_cmd(force: bool):
try:
with open(config_path) as f:
config = json.load(f)
except:
except Exception:
config = {}
else:
config = {}
@@ -1425,7 +1425,7 @@ def install_runtime(setup: bool, sdk: str, computer_use: bool):
console.print(f" [green]✓[/green] Python: {result.stdout.strip()}")
else:
console.print(" [dim]○[/dim] Python: not installed")
except:
except Exception:
console.print(" [dim]○[/dim] Python: not installed")
# TypeScript SDK
+1 -1
View File
@@ -699,7 +699,7 @@ class HanzoDevOrchestrator:
reward=reward,
groundtruth=groundtruth,
)
for response, reward in zip(responses, rewards)
for response, reward in zip(responses, rewards, strict=False)
]
# Stage 1: Summarize trajectories
+3 -3
View File
@@ -19,7 +19,7 @@ def _get_cluster_status() -> Optional[Dict[str, Any]]:
import urllib.request
endpoint = os.getenv("HANZO_CLUSTER_URL", "http://localhost:8000")
req = urllib.request.urlopen(f"{endpoint}/health", timeout=2)
req = urllib.request.urlopen(f"{endpoint}/health", timeout=2) # noqa: S310
return json.loads(req.read().decode())
except Exception:
return None
@@ -42,7 +42,7 @@ def _get_jobs() -> List[Dict[str, Any]]:
import urllib.request
endpoint = os.getenv("HANZO_CLUSTER_URL", "http://localhost:8000")
req = urllib.request.urlopen(f"{endpoint}/jobs?limit=5", timeout=2)
req = urllib.request.urlopen(f"{endpoint}/jobs?limit=5", timeout=2) # noqa: S310
return json.loads(req.read().decode()).get("jobs", [])
except Exception:
return []
@@ -55,7 +55,7 @@ def _get_logs() -> List[str]:
import urllib.request
endpoint = os.getenv("HANZO_CLUSTER_URL", "http://localhost:8000")
req = urllib.request.urlopen(f"{endpoint}/logs?limit=5", timeout=2)
req = urllib.request.urlopen(f"{endpoint}/logs?limit=5", timeout=2) # noqa: S310
return json.loads(req.read().decode()).get("logs", [])
except Exception:
return []