hanzoai/react
2
0
Fork 0
mirror of https://github.com/hanzoai/react.git synced 2026-09-24 17:02:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

Treat Rollup "warnings" as errors (#12868)

Browse Source
This commit is contained in:
Dan Abramov
2018-05-21 15:38:46 +01:00
committed by GitHub
parent d4c85e7f5b
commit 12dd78f6d8
1 changed files with 14 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scripts/rollup/build.js
+14 -5
View File
@@ -420,10 +420,6 @@ async function createBundle(bundle, bundleType) {
}
function handleRollupWarning(warning) {
if (warning.code === 'UNRESOLVED_IMPORT') {
console.error(warning.message);
process.exit(1);
}
if (warning.code === 'UNUSED_EXTERNAL_IMPORT') {
const match = warning.message.match(/external module '([^']+)'/);
if (!match || typeof match[1] !== 'string') {
@@ -445,7 +441,20 @@ function handleRollupWarning(warning) {
// Don't warn. We will remove side effectless require() in a later pass.
return;
}
console.warn(warning.message || warning);
if (typeof warning.code === 'string') {
// This is a warning coming from Rollup itself.
// These tend to be important (e.g. clashes in namespaced exports)
// so we'll fail the build on any of them.
console.error();
console.error(warning.message || warning);
console.error();
process.exit(1);
} else {
// The warning is from one of the plugins.
// Maybe it's not important, so just print it.
console.warn(warning.message || warning);
}
}
function handleRollupError(error) {