mirror of
https://github.com/hanzoai/react.git
synced 2026-09-24 17:02:27 +00:00
fix[devtools/profilingCache-test]: specify correct version gate for test (#27008)
- Correctly gate the test to `[18.0.0, 18.2.0]` versions of react, as it was initially defined before https://github.com/facebook/react/pull/26742 - I have recently fixed the gating logic in https://github.com/facebook/react/pull/26955 and https://github.com/facebook/react/pull/26997, should be stable now - I have added a non-gated version of this test, which should run only for the current version of react, the one we build from sources - The test version for react `v[18.0.0, 18.2.0]` should expect `"priorityLevel": "Immediate"`, the other `"priorityLevel": "Normal"`, as it was changed in https://github.com/facebook/react/pull/26512
This commit is contained in:
@@ -938,11 +938,51 @@ describe('ProfilingCache', () => {
|
||||
}
|
||||
});
|
||||
|
||||
// @reactVersion >= 17
|
||||
// @reactVersion < 18
|
||||
// @reactVersion >= 18.0.0
|
||||
// @reactVersion <= 18.2.0
|
||||
it('should handle unexpectedly shallow suspense trees for react v[18.0.0 - 18.2.0]', () => {
|
||||
const container = document.createElement('div');
|
||||
|
||||
utils.act(() => store.profilerStore.startProfiling());
|
||||
utils.act(() => legacyRender(<React.Suspense />, container));
|
||||
utils.act(() => store.profilerStore.stopProfiling());
|
||||
|
||||
const rootID = store.roots[0];
|
||||
const commitData = store.profilerStore.getDataForRoot(rootID).commitData;
|
||||
expect(commitData).toMatchInlineSnapshot(`
|
||||
[
|
||||
{
|
||||
"changeDescriptions": Map {},
|
||||
"duration": 0,
|
||||
"effectDuration": null,
|
||||
"fiberActualDurations": Map {
|
||||
1 => 0,
|
||||
2 => 0,
|
||||
},
|
||||
"fiberSelfDurations": Map {
|
||||
1 => 0,
|
||||
2 => 0,
|
||||
},
|
||||
"passiveEffectDuration": null,
|
||||
"priorityLevel": "Immediate",
|
||||
"timestamp": 0,
|
||||
"updaters": [
|
||||
{
|
||||
"displayName": "render()",
|
||||
"hocDisplayNames": null,
|
||||
"id": 1,
|
||||
"key": null,
|
||||
"type": 11,
|
||||
},
|
||||
],
|
||||
},
|
||||
]
|
||||
`);
|
||||
});
|
||||
|
||||
// This test is not gated.
|
||||
// For this test we use the current version of react, built from source.
|
||||
it('should handle unexpectedly shallow suspense trees', () => {
|
||||
// This test only runs in v17 because it's a regression test for legacy
|
||||
// Suspense behavior, and the implementation details changed in v18.
|
||||
const container = document.createElement('div');
|
||||
|
||||
utils.act(() => store.profilerStore.startProfiling());
|
||||
|
||||
Reference in New Issue
Block a user