mirror of
https://github.com/hanzoai/react.git
synced 2026-09-24 17:02:27 +00:00
Fix ownerStackLimit feature gating for tests (#32726)
https://github.com/facebook/react/pull/32529 added a dynamic flag for this, but that breaks tests since the flags are not defined everywhere. However, this is a static value and the flag is only for supporting existing tests. So we can override it in the test config, and make it static at built time instead.
This commit is contained in:
@@ -29,7 +29,3 @@ export const enableUseEffectCRUDOverload = __VARIANT__;
|
||||
export const enableFastAddPropertiesInDiffing = __VARIANT__;
|
||||
export const enableLazyPublicInstanceInFabric = __VARIANT__;
|
||||
export const renameElementSymbol = __VARIANT__;
|
||||
export const ownerStackLimit: number = __VARIANT__
|
||||
? // Some value that doesn't impact existing tests
|
||||
500
|
||||
: 1e4;
|
||||
|
||||
@@ -31,7 +31,6 @@ export const {
|
||||
enableFastAddPropertiesInDiffing,
|
||||
enableLazyPublicInstanceInFabric,
|
||||
renameElementSymbol,
|
||||
ownerStackLimit,
|
||||
} = dynamicFlags;
|
||||
|
||||
// The rest of the flags are static for better dead code elimination.
|
||||
@@ -85,6 +84,7 @@ export const enableViewTransition = false;
|
||||
export const enableSwipeTransition = false;
|
||||
export const enableScrollEndPolyfill = true;
|
||||
export const enableFragmentRefs = false;
|
||||
export const ownerStackLimit = 1e4;
|
||||
|
||||
// Flow magic to verify the exports of this file match the original version.
|
||||
((((null: any): ExportsType): FeatureFlagsType): ExportsType);
|
||||
|
||||
@@ -43,11 +43,6 @@ export const enableComponentPerformanceTrack = __VARIANT__;
|
||||
export const enableScrollEndPolyfill = __VARIANT__;
|
||||
export const enableFragmentRefs = __VARIANT__;
|
||||
|
||||
export const ownerStackLimit: number = __VARIANT__
|
||||
? // Some value that doesn't impact existing tests
|
||||
500
|
||||
: 1e4;
|
||||
|
||||
// TODO: These flags are hard-coded to the default values used in open source.
|
||||
// Update the tests so that they pass in either mode, then set these
|
||||
// to __VARIANT__.
|
||||
|
||||
@@ -40,7 +40,6 @@ export const {
|
||||
enableComponentPerformanceTrack,
|
||||
enableScrollEndPolyfill,
|
||||
enableFragmentRefs,
|
||||
ownerStackLimit,
|
||||
} = dynamicFeatureFlags;
|
||||
|
||||
// On WWW, __EXPERIMENTAL__ is used for a new modern build.
|
||||
@@ -115,5 +114,7 @@ export const enableLazyPublicInstanceInFabric = false;
|
||||
|
||||
export const enableSwipeTransition = false;
|
||||
|
||||
export const ownerStackLimit = 1e4;
|
||||
|
||||
// Flow magic to verify the exports of this file match the original version.
|
||||
((((null: any): ExportsType): FeatureFlagsType): ExportsType);
|
||||
|
||||
@@ -17,6 +17,9 @@ jest.mock('shared/ReactFeatureFlags', () => {
|
||||
// we remove the flag.
|
||||
actual.disableClientCache = __VARIANT__;
|
||||
|
||||
// Some value that doesn't impact existing tests
|
||||
actual.ownerStackLimit = __VARIANT__ ? 500 : 1e4;
|
||||
|
||||
return actual;
|
||||
});
|
||||
|
||||
|
||||
@@ -22,6 +22,9 @@ jest.mock('shared/ReactFeatureFlags', () => {
|
||||
actual.enableScopeAPI = true;
|
||||
actual.enableTaint = false;
|
||||
|
||||
// Some value that doesn't impact existing tests
|
||||
actual.ownerStackLimit = __VARIANT__ ? 500 : 1e4;
|
||||
|
||||
return actual;
|
||||
});
|
||||
|
||||
|
||||
Reference in New Issue
Block a user