Andrew Clark
911a1e9705
Rendering into an empty React-rendered element should not warn
...
Only warn if the container has a React-rendered child.
2017-02-06 14:22:16 -08:00
Andrew Clark
bb0cb00daf
Warn if unmounting a tree that was rendered by a different copy of React
2017-02-02 14:30:12 -08:00
Andrew Clark
651a8e8587
Warn when rendering into React-rendered child that isn't a root
2017-02-02 12:18:18 -08:00
Andrew Clark
4a0e190c8a
Warn when mounting into document.body
2017-02-02 12:18:18 -08:00
Andrew Clark
c91d46fde3
Add extra invalid element info to invariant message
2017-02-02 12:18:18 -08:00
Pontus Abrahamsson and Dan Abramov
a98d305bea
Update conferences.md ( #8915 )
...
* Update conferences.md
* Move confs around
2017-02-02 13:37:27 +00:00
Omid Hezaveh and Dan Abramov
9476dfc91e
Explain arbitrariness of ref name in callback ( #8913 )
...
* Explain arbitrariness of ref name in callback
The sample code was confusing because it's not clear that "textInput" in this.textInput is an arbitrary name for the ref.
* Tweak wording
2017-02-02 13:33:12 +00:00
Dan Abramov and GitHub
5fd07d03b3
Fix indentation in tutorial ( #8914 )
2017-02-02 13:24:26 +00:00
Eduard and Kevin Lacker
9b52bb2ca6
Update tutorial.md ( #8896 )
...
* Update tutorial.md
The status <div> used in Board can be deleted as well from render.
* Little tweaks
2017-02-01 18:12:00 -08:00
Tiago Fernandez and Kevin Lacker
8c042a2439
Link to CodePen editor rather than final result ( #8849 )
...
People want to see the final JS/CSS/HTML, and the final result is already displayed by CodePen.
2017-02-01 18:02:44 -08:00
Jeffrey Wan and Kevin Lacker
20776d818a
Update tutorial.md ( #8792 )
...
* Update tutorial.md
* Fix quoting to be consistent
2017-02-01 17:42:19 -08:00
John Longanecker and Kevin Lacker
e5ec539897
Lifting State Up more legible ( #8691 )
2017-02-01 17:31:01 -08:00
Andrew Clark and GitHub
ba1481cd27
Merge pull request #8905 from acdlite/fiberfinddomnodeunmount
...
[Fiber] findDOMNode during componentWillUnmount
2017-01-31 16:05:05 -08:00
Andrew Clark and GitHub
c8fd4fcc23
Merge pull request #8908 from acdlite/fiberemptycomponent
...
[Fiber] Fix formatting of invalid element invariant
2017-01-31 16:03:54 -08:00
Andrew Clark
175c33edb6
Fix formatting of invalid element invariant
...
Message is slightly different for functional and class components.
2017-01-31 15:29:53 -08:00
Andrew Clark and GitHub
6195235407
Merge pull request #8893 from gaearon/fix-dom-prod-test
...
Add process.cwd to the test process shim
2017-01-31 15:04:39 -08:00
Andrew Clark and GitHub
f15f047491
Merge pull request #8906 from acdlite/warningnewline
...
Add missing newline to warning
2017-01-31 14:42:21 -08:00
Andrew Clark
f7dc8606e0
Add newline to warning
2017-01-31 14:41:14 -08:00
Andrew Clark
2975a34a1f
Don't swap the trees until after the first pass of the commit phase,
...
where componentWillUnmount is called, but before the second pass,
where componentDidMount/Update is called.
2017-01-31 14:39:52 -08:00
Andrew Clark and GitHub
a16f47d0d0
Merge pull request #8890 from acdlite/fiberfragmentinvariants
...
[Fiber] Throw on plain object children
2017-01-31 13:14:11 -08:00
Andrew Clark and GitHub
615c2f207f
Merge pull request #8897 from acdlite/fiberfixfinddomnode
...
[Fiber] Fix findDOMNode algorithm
2017-01-31 13:13:56 -08:00
Andrew Clark
de07331ab7
Remove legacy React element warning
2017-01-31 11:46:30 -08:00
Andrew Clark
662e68deb1
Run test script
2017-01-31 11:44:35 -08:00
Andrew Clark
e9bcee4ed8
Add missing portal case to updateSlot switch statement
2017-01-31 11:44:35 -08:00
Andrew Clark
d2b3f370c8
Allow object as textarea child
...
Preserves Stack behavior. There's already a warning for this.
2017-01-31 11:44:35 -08:00
Andrew Clark
a3d25a2429
Fallback to owner of returnFiber
...
Won't work if the returnFiber is a fragment. Not sure it matters;
warning will just be less descriptive.
2017-01-31 11:44:35 -08:00
Andrew Clark
5d3b01daf2
Throw on invalid object type children
...
Same behavior as Stack
2017-01-31 11:44:30 -08:00
Andrew Clark
6d13f4293d
Add invariant
...
Defensive coding to prevent an infinite loop.
2017-01-31 11:35:10 -08:00
Dan Abramov
01ede2b9c3
Suppress lint warnings
...
Using [] is intentional because we don't want to trigger Babel plugin.
2017-01-31 19:30:26 +00:00
Andrew Clark
a5601feaa3
Fix findDOMNode algorithm
2017-01-31 10:24:03 -08:00
Dan Abramov
c5c4080f7e
Reassign process.env.NODE_ENV instead of shimming process
2017-01-31 16:28:20 +00:00
Marius Skaar Ludvigsen and Brandon Dail
b1ed1b45e6
#6049 add support for onCancel and onClose event ( #6247 )
2017-01-31 08:10:48 -06:00
Richie Thomas and Brandon Dail
3ff01780e4
Added double newline delimiters to the following functions/files: ( #8777 )
...
* 'beginLifeCycleTimer' function of ReactDebugTool.js
* 'bindAutoBindMethod' function of ReactClass.js
* 'warnNoop' function of ReactServerUpdateQueue.js
* 'getInternalInstanceReadyForUpdate' function of ReactUpdateQueue.js
* 'warnNoop' function of ReactNoopUpdateQueue.js
* 'getDeclarationErrorAddendum' function of ReactDOMComponent.js
* 'getSourceInfoErrorAddendum' function of ReactElementValidator.js
* 'getDeclarationErrorAddendum' function of instantiateReactComponent.js and ReactElementValidator.js
* 'traverseAllChildrenImpl' function of traverseAllChildren.js
* 'attachRef' function of ReactRef.js
* 'mountIndeterminateComponent' function of ReactFiberBeginWork.js
* 'createFiberFromElementType' function of ReactFiber.js
* 'getDeclarationErrorAddendum' function of ReactDOMSelect.js
* 'unmountComponentAtNode' function of ReactMount.js
* 'getDeclarationErrorAddendum' function of ReactControlledValuePropTypes.js
* 'checkRenderMessage' function of CSSPropertyOperations.js
* 'getDeclarationErrorAddendum' function of ReactDomFiberSelect.js
* 'getCurrentComponentErrorInfo' function in 'ReactElementValidator'
* 'getDeclarationErrorAddendum' function in ReactDOMFiberComponent.js
2017-01-31 07:41:24 -06:00
Vladimir Kovpak and Brandon Dail
3cf4014566
Added undefined example ( #8899 )
...
Into section `Booleans, Null, and Undefined Are Ignored` I've added example with undefined.
2017-01-31 07:24:29 -06:00
Ben Alpert and Dan Abramov
e97838953f
Don't crash Fiber with old devtools ( #8900 )
...
Typo.
2017-01-31 13:06:53 +00:00
Roman Liutikov and Brandon Dail
a3366740f0
refer to object by name instead of function call context ( #8892 )
2017-01-30 18:32:26 -06:00
Senin Roman and Brandon Dail
81cb401c73
Fix incorrect markup for ie10 ( #8886 )
2017-01-30 18:32:07 -06:00
Dan Abramov
a128f333e1
Add process.cwd to the test process shim
2017-01-30 21:48:05 +00:00
Maksim Shastsel and Dan Abramov
24a4781198
Delete @nosideeffect annotation ( #8882 )
2017-01-30 21:42:17 +00:00
Dan Abramov and GitHub
735947cc7a
Fix lint ( #8888 )
2017-01-30 17:46:07 +00:00
MICHAEL JACKSON and Dan Abramov
be23547b2b
Update context example for react-router v4 beta ( #8889 )
...
* Update context example for [email protected]
* Style nits
2017-01-30 17:36:47 +00:00
Dan Abramov and GitHub
6cf875bf8c
Declare __REACT_DEVTOOLS_GLOBAL_HOOK__ for Flow ( #8884 )
2017-01-30 14:14:30 +00:00
Zac Braddy and Brian Vaughn
8f67749f91
Got rid of linting errors on windows machines and a number of linting warnings. ( #8846 )
2017-01-28 15:36:03 -08:00
Frank Yan and Brandon Dail
91ba8ec083
Fix typo in EventPropagators.js ( #8879 )
2017-01-27 18:36:21 -06:00
Dan Abramov and GitHub
4b2205ba30
[Fiber] Support React DevTools ( #8818 )
...
* Initial React DevTools support for Fiber
* Record a newly failing irrelevant test
This is fine because we don't use it in Stack anyway (at least not that part), and we also rely on Set/Map in other parts of code.
The newly failing test is the one saying "it works without Map/Set".
* Explicitly check for Fiber DevTools support
This lets us ignore pre-Fiber DevTools instead of crashing them by injecting a different API.
* Track the roots in DevTools instead
* Lol Dan this is not how warnings work in our codebase
* Move injection to the renderer
* Notify DevTools about unmounts
* Make it work in production
* Fix lint and flow
* Fixups
* Address feedback
2017-01-27 22:50:35 +00:00
Paul O’Shannessy and Brandon Dail
31bb5a790e
[examples] Use react-standalone ( #7669 )
...
[examples] Use babel-standalone
2017-01-26 11:57:01 -06:00
Sebastian Markbåge and GitHub
8bce057d21
Merge pull request #8840 from sebmarkbage/statelesscoroutines
...
[Fiber] Simplify coroutines by making yields stateless
2017-01-26 07:15:36 -08:00
Mitchel Humpherys and Brandon Dail
42aba84d23
installation.md: Add missing "as" ( #8871 )
2017-01-25 23:33:49 -06:00
Sebastian Markbåge and GitHub
356a81ec15
ReactElement is private to isomorphic React ( #8868 )
...
This fixes the build since this dependency is not reachable from React DOM.
2017-01-25 17:52:45 -08:00
Sebastian Markbage
88dd645615
Don't bail to .child of coroutines
...
This should bail to stateNode instead.
2017-01-25 17:50:21 -08:00