hanzoai/tasks
2
0
Fork 0
mirror of https://github.com/hanzoai/tasks.git synced 2026-10-04 02:04:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

Address deprecation warnings and always generate summary reports (#9743)

Browse Source 
## What changed?
* Upgrade the `actions/create-github-app-token` and `actions/setup-go`
because of deprecations notices for NodeJS
* Change the test summary to `!cancelled` so successful runs will still
show the failed tests in Summary.

## Why?
Deprecations warnings for the first bullet point. For the second bullet
point it's helpful to see the flaky tests on a successful run.

## How did you test it?
- [ ] built
- [ ] run locally and tested manually
- [ ] covered by existing tests
- [ ] added new unit test(s)
- [ ] added new functional test(s)

## Potential risks
Tests only
This commit is contained in:
Sean Kane
2026-03-30 18:27:40 +00:00
committed by GitHub
parent b435e2f727
commit 44d7cbe1b6
5 changed files with 32 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/ci-success-report.yml
+2 -2
View File
@@ -32,7 +32,7 @@ jobs:
steps:
- name: Generate token
id: generate_token
uses: actions/create-github-app-token@v1
uses: actions/create-github-app-token@v2
with:
app-id: ${{ secrets.TEMPORAL_CICD_APP_ID }}
private-key: ${{ secrets.TEMPORAL_CICD_PRIVATE_KEY }}
@@ -45,7 +45,7 @@ jobs:
token: ${{ steps.generate_token.outputs.token }}
- name: Set up Go
uses: actions/setup-go@v5
uses: actions/setup-go@v6
with:
go-version-file: 'go.mod'
.github/workflows/features-integration.yml
+1 -1
View File
@@ -56,7 +56,7 @@ jobs:
cp ./develop/docker-compose/docker-compose.yml /tmp/docker-compose.yml
- name: Upload Docker artifact
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v6
with:
name: temporal-server-docker
path: |
.github/workflows/flaky-tests-report.yml
+3 -3
View File
@@ -27,7 +27,7 @@ jobs:
steps:
- name: Generate token
id: generate_token
uses: actions/create-github-app-token@v1
uses: actions/create-github-app-token@v2
with:
app-id: ${{ secrets.TEMPORAL_CICD_APP_ID }}
private-key: ${{ secrets.TEMPORAL_CICD_PRIVATE_KEY }}
@@ -41,7 +41,7 @@ jobs:
fetch-depth: 0
- name: Set up Go
uses: actions/setup-go@v5
uses: actions/setup-go@v6
with:
go-version-file: "go.mod"
@@ -68,7 +68,7 @@ jobs:
--sha "$SHA"
- name: Upload generated reports
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v6
if: steps.process-flaky-tests.outcome == 'success'
with:
name: flaky-tests-reports-${{ github.run_number }}
.github/workflows/run-tests.yml
+25 -25
View File
@@ -228,7 +228,7 @@ jobs:
- name: Restore dependencies
id: restore-deps
uses: actions/cache/restore@v4
uses: actions/cache/restore@v5
with:
path: ~/go/pkg/mod
key: go-${{ runner.os }}${{ runner.arch }}-${{ hashFiles('go.mod') }}-deps-${{ hashFiles('go.sum') }}
@@ -236,14 +236,14 @@ jobs:
- run: make pre-build-functional-test-coverage
- name: Save dependencies
uses: actions/cache/save@v4
uses: actions/cache/save@v5
if: ${{ steps.restore-deps.outputs.cache-hit != 'true' }}
with:
path: ~/go/pkg/mod
key: ${{ steps.restore-deps.outputs.cache-primary-key }}
- name: Save build outputs
uses: actions/cache/save@v4
uses: actions/cache/save@v5
with:
path: ~/.cache/go-build
key: go-${{ runner.os }}${{ runner.arch }}-build-${{ env.COMMIT }}
@@ -266,13 +266,13 @@ jobs:
cache: false # do our own caching
- name: Restore dependencies
uses: actions/cache/restore@v4
uses: actions/cache/restore@v5
with:
path: ~/go/pkg/mod
key: go-${{ runner.os }}${{ runner.arch }}-${{ hashFiles('go.mod') }}-deps-${{ hashFiles('go.sum') }}
- name: Restore build outputs
uses: actions/cache/restore@v4
uses: actions/cache/restore@v5
with:
path: ~/.cache/go-build
key: go-${{ runner.os }}${{ runner.arch }}-build-${{ env.COMMIT }}
@@ -303,13 +303,13 @@ jobs:
cache: false # do our own caching
- name: Restore dependencies
uses: actions/cache/restore@v4
uses: actions/cache/restore@v5
with:
path: ~/go/pkg/mod
key: go-${{ runner.os }}${{ runner.arch }}-${{ hashFiles('go.mod') }}-deps-${{ hashFiles('go.sum') }}
- name: Restore build outputs
uses: actions/cache/restore@v4
uses: actions/cache/restore@v5
with:
path: ~/.cache/go-build
key: go-${{ runner.os }}${{ runner.arch }}-build-${{ env.COMMIT }}
@@ -329,8 +329,8 @@ jobs:
CRASH_REPORT_NAME="$GITHUB_JOB" make report-test-crash
- name: Generate test summary
uses: mikepenz/action-junit-report@v5.0.0-rc01
if: failure()
uses: mikepenz/action-junit-report@v6
if: ${{ !cancelled() }}
with:
report_paths: ./.testoutput/junit.*.xml
detailed_summary: true
@@ -363,7 +363,7 @@ jobs:
- name: Upload test results to GitHub
# Can't pin to major because the action linter doesn't recognize the include-hidden-files flag.
uses: actions/upload-artifact@v4.4.3
uses: actions/upload-artifact@v6
if: ${{ !cancelled() }}
with:
name: junit-xml--${{ github.run_id }}--${{ steps.get_job_id.outputs.job_id }}--${{ github.run_attempt }}--unit-test
@@ -397,13 +397,13 @@ jobs:
cache: false # do our own caching
- name: Restore dependencies
uses: actions/cache/restore@v4
uses: actions/cache/restore@v5
with:
path: ~/go/pkg/mod
key: go-${{ runner.os }}${{ runner.arch }}-${{ hashFiles('go.mod') }}-deps-${{ hashFiles('go.sum') }}
- name: Restore build outputs
uses: actions/cache/restore@v4
uses: actions/cache/restore@v5
with:
path: ~/.cache/go-build
key: go-${{ runner.os }}${{ runner.arch }}-build-${{ env.COMMIT }}
@@ -429,8 +429,8 @@ jobs:
CRASH_REPORT_NAME="$GITHUB_JOB" make report-test-crash
- name: Generate test summary
uses: mikepenz/action-junit-report@v5.0.0-rc01
if: failure()
uses: mikepenz/action-junit-report@v6
if: ${{ !cancelled() }}
with:
report_paths: ./.testoutput/junit.*.xml
detailed_summary: true
@@ -463,7 +463,7 @@ jobs:
- name: Upload test results to GitHub
# Can't pin to major because the action linter doesn't recognize the include-hidden-files flag.
uses: actions/upload-artifact@v4.4.3
uses: actions/upload-artifact@v6
if: ${{ !cancelled() }}
with:
name: junit-xml--${{ github.run_id }}--${{ steps.get_job_id.outputs.job_id }}--${{ github.run_attempt }}--integration-test
@@ -515,13 +515,13 @@ jobs:
cache: false # do our own caching
- name: Restore dependencies
uses: actions/cache/restore@v4
uses: actions/cache/restore@v5
with:
path: ~/go/pkg/mod
key: go-${{ runner.os }}${{ runner.arch }}-${{ hashFiles('go.mod') }}-deps-${{ hashFiles('go.sum') }}
- name: Restore build outputs
uses: actions/cache/restore@v4
uses: actions/cache/restore@v5
with:
path: ~/.cache/go-build
key: go-${{ runner.os }}${{ runner.arch }}-build-${{ env.COMMIT }}
@@ -568,8 +568,8 @@ jobs:
CRASH_REPORT_NAME="$GITHUB_JOB" make report-test-crash
- name: Generate test summary
uses: mikepenz/action-junit-report@v5.0.0-rc01
if: failure()
uses: mikepenz/action-junit-report@v6
if: ${{ !cancelled() }}
with:
report_paths: ./.testoutput/junit.*.xml
detailed_summary: true
@@ -595,7 +595,7 @@ jobs:
- name: Upload test results to GitHub
# Can't pin to major because the action linter doesn't recognize the include-hidden-files flag.
uses: actions/upload-artifact@v4.4.3
uses: actions/upload-artifact@v6
if: ${{ !cancelled() }}
with:
name: junit-xml--${{ github.run_id }}--${{ steps.get_job_id.outputs.job_id }}--${{ github.run_attempt }}--${{ matrix.name }}--${{ matrix.display_name }}--functional-test
@@ -604,7 +604,7 @@ jobs:
retention-days: 28
- name: Upload debug logs
uses: actions/upload-artifact@v4.4.3
uses: actions/upload-artifact@v6
if: ${{ !cancelled() }}
with:
name: debug-logs--${{ github.run_id }}--${{ steps.get_job_id.outputs.job_id }}--${{ github.run_attempt }}--${{ matrix.name }}--${{ matrix.display_name }}--functional-test
@@ -635,13 +635,13 @@ jobs:
cache: false
- name: Restore dependencies
uses: actions/cache/restore@v4
uses: actions/cache/restore@v5
with:
path: ~/go/pkg/mod
key: go-${{ runner.os }}${{ runner.arch }}-${{ hashFiles('go.mod') }}-deps-${{ hashFiles('go.sum') }}
- name: Restore build outputs
uses: actions/cache/restore@v4
uses: actions/cache/restore@v5
with:
path: ~/.cache/go-build
key: go-${{ runner.os }}${{ runner.arch }}-build-${{ env.COMMIT }}
@@ -705,10 +705,10 @@ jobs:
actions: read
steps:
- name: Checkout code
uses: actions/checkout@v4
uses: actions/checkout@v6
- name: Set up Go
uses: actions/setup-go@v5
uses: actions/setup-go@v6
with:
go-version-file: "go.mod"
cache: true
.github/workflows/trigger-version-info-service.yml
+1 -1
View File
@@ -19,7 +19,7 @@ jobs:
steps:
- name: Generate token
id: generate_token
uses: actions/create-github-app-token@v1
uses: actions/create-github-app-token@v2
with:
app-id: ${{ secrets.TEMPORAL_CICD_APP_ID }}
private-key: ${{ secrets.TEMPORAL_CICD_PRIVATE_KEY }}