mirror of
https://github.com/hanzoai/tasks.git
synced 2026-10-04 02:04:03 +00:00
## What changed? <!-- Describe what has changed in this PR --> Fix parse duration error type to be a ConverterError. ## Why? <!-- Tell your future self why have you made these changes --> If the parsing failed, it's an issue with user input, not an internal error. ## How did you test it? <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> Added tests to make sure errors returned by this function is always a ConverterError. ## Potential risks <!-- Assuming the worst case, what can be broken when deploying this change to production? --> ## Documentation <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> ## Is hotfix candidate? <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) -->
128 lines
3.6 KiB
Go
128 lines
3.6 KiB
Go
// The MIT License
|
|
//
|
|
// Copyright (c) 2021 Temporal Technologies Inc. All rights reserved.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
// of this software and associated documentation files (the "Software"), to deal
|
|
// in the Software without restriction, including without limitation the rights
|
|
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
// copies of the Software, and to permit persons to whom the Software is
|
|
// furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in
|
|
// all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
// THE SOFTWARE.
|
|
|
|
package timestamp
|
|
|
|
import (
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/suite"
|
|
)
|
|
|
|
type ParseDurationSuite struct {
|
|
suite.Suite
|
|
}
|
|
|
|
func TestParseDurationSuite(t *testing.T) {
|
|
suite.Run(t, new(ParseDurationSuite))
|
|
}
|
|
|
|
func (s *ParseDurationSuite) TestParseDuration() {
|
|
for _, c := range []struct {
|
|
input string
|
|
expected time.Duration // -1 means error
|
|
}{
|
|
{"1h", time.Hour},
|
|
{"3m30s", 3*time.Minute + 30*time.Second},
|
|
{"1d", 24 * time.Hour},
|
|
{"3d", 3 * 24 * time.Hour},
|
|
{"5d6h15m", 5*24*time.Hour + 6*time.Hour + 15*time.Minute},
|
|
{"5.25d15m", 5*24*time.Hour + 6*time.Hour + 15*time.Minute},
|
|
{".5d", 12 * time.Hour},
|
|
{"-10d12.25h", -(10*24*time.Hour + 12*time.Hour + 15*time.Minute)},
|
|
{"3m2h1d", 3*time.Minute + 2*time.Hour + 1*24*time.Hour},
|
|
{"8m7h6d5d4h3m", 8*time.Minute + 7*time.Hour + 6*24*time.Hour + 5*24*time.Hour + 4*time.Hour + 3*time.Minute},
|
|
{"7", -1}, // error
|
|
{"", -1}, // error
|
|
{"10000000h", -1}, // error out of bounds
|
|
} {
|
|
got, err := ParseDuration(c.input)
|
|
if c.expected == -1 {
|
|
s.Error(err)
|
|
} else {
|
|
s.Equal(c.expected, got)
|
|
}
|
|
}
|
|
}
|
|
|
|
func (s *ParseDurationSuite) TestParseDurationDefaultDays() {
|
|
for _, c := range []struct {
|
|
input string
|
|
expected time.Duration // -1 means error
|
|
}{
|
|
{"3m30s", 3*time.Minute + 30*time.Second},
|
|
{"7", 7 * 24 * time.Hour},
|
|
{"7.5", 7*24*time.Hour + 12*time.Hour},
|
|
{".75", 18 * time.Hour},
|
|
{"2.75", 2*24*time.Hour + 18*time.Hour},
|
|
{"", -1}, // error
|
|
} {
|
|
got, err := ParseDurationDefaultDays(c.input)
|
|
if c.expected == -1 {
|
|
s.Error(err)
|
|
} else {
|
|
s.Equal(c.expected, got)
|
|
}
|
|
}
|
|
}
|
|
|
|
func (s *ParseDurationSuite) TestParseDurationDefaultSeconds() {
|
|
for _, c := range []struct {
|
|
input string
|
|
expected time.Duration // -1 means error
|
|
}{
|
|
{"3m30s", 3*time.Minute + 30*time.Second},
|
|
{"7", 7 * time.Second},
|
|
{"", -1}, // error
|
|
} {
|
|
got, err := ParseDurationDefaultSeconds(c.input)
|
|
if c.expected == -1 {
|
|
s.Error(err)
|
|
} else {
|
|
s.Equal(c.expected, got)
|
|
}
|
|
}
|
|
}
|
|
|
|
func (s *ParseDurationSuite) TestParseHHMMSSDuration() {
|
|
for _, c := range []struct {
|
|
input string
|
|
expected time.Duration // -1 means error
|
|
}{
|
|
{"1:00:00", 1 * time.Hour},
|
|
{"123:05:10", 123*time.Hour + 5*time.Minute + 10*time.Second},
|
|
{"00:05:10", 5*time.Minute + 10*time.Second},
|
|
{"-12:05:10", -1},
|
|
{"12:61:10", -1},
|
|
{"12:05:61", -1},
|
|
{"", -1},
|
|
} {
|
|
got, err := ParseHHMMSSDuration(c.input)
|
|
if c.expected == -1 {
|
|
s.Error(err)
|
|
} else {
|
|
s.Equal(c.expected, got)
|
|
}
|
|
}
|
|
}
|