mirror of
https://github.com/hanzoai/yoga.git
synced 2026-10-30 19:34:29 +00:00
Summary: X-link: https://github.com/react/react-native/pull/57175 fixes https://github.com/facebook/yoga/issues/1665. **problem:** when all flex children are frozen to their min-width in the first pass, `totalFlexShrinkScaledFactors` is reduced to near-zero by floating-point cancellation rather than exactly 0. the guard in `distributeFreeSpaceSecondPass` uses exact equality (`== 0`), so it never fires, and the second pass divides `remainingFreeSpace` by a value on the order of 1e-7, producing a childSize on the order of 1e11 that overwhelms the min/max clamp. **fix:** replace the exact-zero check with a relative epsilon guard (`shrinkFactorMagnitude < 1e-6f`). when the magnitude is that small, all items were already frozen in the first pass; the safe fallback (`childFlexBasis + flexShrinkScaledFactor`) applies and the subsequent `boundAxisWithAutoMin` clamps correctly to minWidth. regression: `YGFlexShrinkBorderBug.flex_basis_0_border_minwidth_row` reproduces the original crash — 4 children, `borderWidth` difference of 1e-6 across them, all now compute to their correct minWidth. ## Changelog: [Internal] - X-link: https://github.com/facebook/yoga/pull/1974 Reviewed By: javache Differential Revision: D108030908 Pulled By: cipolleschi fbshipit-source-id: 3e8d4ef6773bc31703a54005bf610b2432f22d2d
49 lines
1.8 KiB
C++
49 lines
1.8 KiB
C++
/*
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
// Regression test for https://github.com/facebook/yoga/issues/1665
|
|
// flexBasis:0 + flexShrink:1 + borderWidth + minWidth produces an
|
|
// astronomically large width (~1.65e11) instead of being clamped to minWidth.
|
|
|
|
#include <gtest/gtest.h>
|
|
#include <yoga/Yoga.h>
|
|
|
|
TEST(YGFlexShrinkBorderBug, flex_basis_0_border_minwidth_row) {
|
|
YGConfigRef config = YGConfigNew();
|
|
YGNodeRef root = YGNodeNewWithConfig(config);
|
|
YGNodeStyleSetFlexDirection(root, YGFlexDirectionRow);
|
|
YGNodeStyleSetWidth(root, 393.0f);
|
|
YGNodeStyleSetHeight(root, 100.0f);
|
|
|
|
// Four row children: flexBasis:0, flexGrow:1, flexShrink:1, minWidth:160
|
|
// First child has borderWidth:0.594443, rest 0.594442.
|
|
// Bug: first child (and all others) get width ~1.65e11 instead of 160.
|
|
float borders[] = {0.594443f, 0.594442f, 0.594442f, 0.594442f};
|
|
for (size_t i = 0; i < 4; i++) {
|
|
YGNodeRef child = YGNodeNewWithConfig(config);
|
|
YGNodeStyleSetFlexBasis(child, 0.0f);
|
|
YGNodeStyleSetFlexGrow(child, 1.0f);
|
|
YGNodeStyleSetFlexShrink(child, 1.0f);
|
|
YGNodeStyleSetMinWidth(child, 160.0f);
|
|
YGNodeStyleSetBorder(child, YGEdgeAll, borders[i]);
|
|
YGNodeInsertChild(root, child, i);
|
|
}
|
|
|
|
YGNodeCalculateLayout(root, 393.0f, 100.0f, YGDirectionLTR);
|
|
|
|
for (size_t i = 0; i < 4; i++) {
|
|
YGNodeRef child = YGNodeGetChild(root, i);
|
|
EXPECT_GE(YGNodeLayoutGetWidth(child), 160.0f)
|
|
<< "child[" << i << "] width below minWidth";
|
|
EXPECT_LE(YGNodeLayoutGetWidth(child), 200.0f)
|
|
<< "child[" << i << "] width is astronomically large (bug)";
|
|
}
|
|
|
|
YGNodeFreeRecursive(root);
|
|
YGConfigFree(config);
|
|
}
|