lux/aml
2
0
Fork 0
mirror of https://github.com/luxfi/aml.git synced 2026-09-24 00:25:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

ci: the console job type-checks the console

Browse Source 
`npm --prefix ui exec tsc -- --noEmit` ran the compiler from the repo root,
where there is no tsconfig. tsc printed its usage and exited 1, so the job has
failed on every commit since it was added and the browser suite behind it has
never run in CI once — the 12 playwright tests were only ever green on a
developer's machine.

--prefix selects the package, not the working directory. `npm run` executes a
script from the package root, which is how every other node step in these two
workflows already reaches ui/, and ui/package.json already declares the script.

Co-authored-by: Hanzo Dev <[email protected]>
This commit is contained in:
zooqueen
2026-08-01 12:58:05 -07:00
co-authored by Hanzo Dev
parent f746f51ec4
commit d223e896f9
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.hanzo/workflows/ci.yml
+6 -1
View File
@@ -131,7 +131,12 @@ jobs:
# is what the image builds.
run: npm --prefix ui ci
- name: Typecheck
run: npm --prefix ui exec tsc -- --noEmit
# The console's own script, the same way every other step here reaches it.
# `npm --prefix ui exec tsc -- --noEmit` ran the compiler from the REPO
# root, where there is no tsconfig, so tsc printed its help and exited 1 —
# this job has never once passed, and the browser suite below it therefore
# never ran in CI at all.
run: npm --prefix ui run typecheck
- name: Build the bundle
run: |
npm --prefix ui run build