mirror of
https://github.com/luxfi/api.git
synced 2026-09-24 00:24:53 +00:00
zeekay
af717c32a9
Three real bugs in luxfi/api/zap: 1. Debug fmt.Fprintf(os.Stderr, ...) prints on every wire read/write/ handler invocation. Visible in production logs as [ZAP-WIRE-READ], [ZAP-CLIENT-READ], [ZAP-SERVER-WRITE], [ZAP-HANDLER]. Stripped. 2. Server's success path sent the handler's returned msgType directly without OR'ing MsgResponseFlag. Echo-style handlers (return same msgType) produced responses that looked like fresh inbound requests to the client demultiplexer, which dropped them. Tests caught this as 'Expected response type 137, got 9'. 3. Client treated every response as an error because the protocol used a single MsgResponseFlag for both success and error paths. Added MsgErrorFlag (0x40) — error responses now carry MsgResponseFlag AND MsgErrorFlag; success responses carry only MsgResponseFlag. All msg types must stay < 0x40 (the existing range 1-52 is fine).